7cc780d077
* fix: let Node.js perform microtask checkpoint in the main process * fix: don't specify v8::MicrotasksScope for explicit policy * fix: remove checkpoint from some call-sites We already perform checkpoint at the end of a task, either through MicrotaskRunner or through NodeBindings. There isn't a need to add them again when calling into JS except when dealing with promises. * fix: remove checkpoint from some call-sites We already perform checkpoint at the end of a task, either through MicrotaskRunner or through NodeBindings. There isn't a need to add them again when calling into JS except when dealing with promises. * fix incorrect specs * default constructor arguments are considered for explicit mark * add regression spec
38 lines
1.4 KiB
C++
38 lines
1.4 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/gin_helper/event_emitter_caller.h"
|
|
|
|
#include "shell/common/gin_helper/locker.h"
|
|
#include "shell/common/gin_helper/microtasks_scope.h"
|
|
#include "shell/common/node_includes.h"
|
|
|
|
namespace gin_helper {
|
|
|
|
namespace internal {
|
|
|
|
v8::Local<v8::Value> CallMethodWithArgs(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> obj,
|
|
const char* method,
|
|
ValueVector* args) {
|
|
// Perform microtask checkpoint after running JavaScript.
|
|
gin_helper::MicrotasksScope microtasks_scope(isolate, true);
|
|
// Use node::MakeCallback to call the callback, and it will also run pending
|
|
// tasks in Node.js.
|
|
v8::MaybeLocal<v8::Value> ret = node::MakeCallback(
|
|
isolate, obj, method, args->size(), args->data(), {0, 0});
|
|
// If the JS function throws an exception (doesn't return a value) the result
|
|
// of MakeCallback will be empty and therefore ToLocal will be false, in this
|
|
// case we need to return "false" as that indicates that the event emitter did
|
|
// not handle the event
|
|
v8::Local<v8::Value> localRet;
|
|
if (ret.ToLocal(&localRet)) {
|
|
return localRet;
|
|
}
|
|
return v8::Boolean::New(isolate, false);
|
|
}
|
|
|
|
} // namespace internal
|
|
|
|
} // namespace gin_helper
|