electron/shell
trop[bot] e99de2b5c6
test: ensure sender-pid hint is set in Linux notifications (#43951)
test: expect a `sender-pid` hint in Linux notifications.

This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.

This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.

By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 14:02:07 -05:00
..
app fix: delete UvTaskRunner's timers only after they're closed (#43598) 2024-09-06 11:18:52 -05:00
browser test: ensure sender-pid hint is set in Linux notifications (#43951) 2024-09-25 14:02:07 -05:00
common refactor: remove C-style void arg type for no-arg functions (#43942) 2024-09-25 12:13:22 -05:00
renderer refactor: declare gin::Wrapper subclasses as final (#43783) 2024-09-19 09:57:24 +02:00
services/node refactor: declare gin::Wrapper subclasses as final (#43783) 2024-09-19 09:57:24 +02:00
utility refactor: run Windows SelectFileDialog out of process (#42825) 2024-07-09 19:03:13 +02:00