16f459228b
Co-authored-by: Samuel Attard <sattard@salesforce.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
22 lines
1.1 KiB
Diff
22 lines
1.1 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Samuel Attard <samuel.r.attard@gmail.com>
|
|
Date: Thu, 18 Oct 2018 17:07:47 -0700
|
|
Subject: dump_syms.patch
|
|
|
|
dylib currently fails to resolve Squirrel.framework on OSX, we need to fix
|
|
this but it is not a blocker for releasing Electron. This patch removes
|
|
tthe hard fail on dylib resolve failure from dump_syms
|
|
|
|
diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py
|
|
index 3a98a881039282ec11aca87c0318c663b7c136b0..ffff58fe23acfb7d72153044449c926380e4022e 100755
|
|
--- a/components/crash/content/tools/generate_breakpad_symbols.py
|
|
+++ b/components/crash/content/tools/generate_breakpad_symbols.py
|
|
@@ -204,7 +204,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path):
|
|
'ERROR: failed to resolve %s, exe_path %s, loader_path %s, '
|
|
'rpaths %s' % (m.group(1), exe_path, loader_path,
|
|
', '.join(rpaths))), file=sys.stderr)
|
|
- sys.exit(1)
|
|
+ # sys.exit(1)
|
|
return deps
|
|
|
|
|