39baf68790
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: loc <andy@slack-corp.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
41 lines
1.2 KiB
Diff
41 lines
1.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
Date: Tue, 16 Apr 2019 10:43:04 -0700
|
|
Subject: build_gn.patch
|
|
|
|
We force V8 into 'shared library' mode so that it exports its symbols, which is
|
|
necessary for native modules to load.
|
|
|
|
Also, some fixes relating to mksnapshot on ARM.
|
|
|
|
diff --git a/BUILD.gn b/BUILD.gn
|
|
index c12bf2dc76ec831054e8ee8753bcc772fda06736..d0346a6537a9edbd04c6fd75a345d1fb50bcffa1 100644
|
|
--- a/BUILD.gn
|
|
+++ b/BUILD.gn
|
|
@@ -310,7 +310,7 @@ config("internal_config") {
|
|
":v8_header_features",
|
|
]
|
|
|
|
- if (is_component_build) {
|
|
+ if (is_component_build || is_electron_build) {
|
|
defines += [ "BUILDING_V8_SHARED" ]
|
|
}
|
|
}
|
|
@@ -3959,7 +3959,7 @@ if (current_toolchain == v8_generator_toolchain) {
|
|
"src/interpreter/bytecodes.h",
|
|
]
|
|
|
|
- configs = [ ":internal_config" ]
|
|
+ configs = [ ":internal_config_base" ]
|
|
|
|
deps = [
|
|
":v8_libbase",
|
|
@@ -3992,6 +3992,8 @@ if (current_toolchain == v8_snapshot_toolchain) {
|
|
|
|
configs = [ ":internal_config" ]
|
|
|
|
+ configs += [ "//electron/build/config:build_time_executable" ]
|
|
+
|
|
deps = [
|
|
":v8_base_without_compiler",
|
|
":v8_compiler_for_mksnapshot",
|