mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/shell/browser
History
Shelley Vohr 49096c2359
fix: throw on invalid webRequest filters (#19337) 
Closes #11371.

Previously, we didn't consider the return value of the webRequest URLPattern mate converter, which meant that when the pattern wasn't correctly parsed owing to invalid filter specification users would not be made aware of that fact and would just think that the filtering itself had failed. This corrects that error by moving the business logic of url pattern parsing out of the converter and into the function itself so that granular and specific errors can be thrown.

There's also no real reason that i'm aware of not to allow wider breadth of filters by letting users use a wildcard for effective TLD, so I also overrode that (default for the 1-arg Parse is not to allow that).

Finally, I added some examples of url filter types for users to reference.
2019-07-25 10:20:02 -07:00
..
api fix: throw on invalid webRequest filters (#19337) 2019-07-25 10:20:02 -07:00
extensions feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
lib refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
loader refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
mac refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
media chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
net chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
notifications refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
osr chore: bump chromium to b8ae827f4fead0b527079194b9899 (master) (#19112) 2019-07-09 10:00:24 +09:00
printing chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
resources Bump v7.0.0-nightly.20190725 2019-07-25 08:31:39 -07:00
ui chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
win refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_blob_reader.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_blob_reader.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_client.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
atom_browser_client.h chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
atom_browser_context.cc feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_browser_context.h feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_browser_main_parts.cc feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_browser_main_parts.h feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_browser_main_parts_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_main_parts_posix.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_download_manager_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_download_manager_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_gpu_client.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_gpu_client.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_javascript_dialog_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_javascript_dialog_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_navigation_throttle.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_navigation_throttle.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_paths.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_permission_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_permission_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_quota_permission_context.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_quota_permission_context.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_speech_recognition_manager_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_speech_recognition_manager_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_web_ui_controller_factory.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
atom_web_ui_controller_factory.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
auto_updater.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
auto_updater.h chore: fix linting after shell rename 2019-06-19 17:33:28 -07:00
auto_updater_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser.h feat: show optional authors in gtk about panel (#18964) 2019-06-25 11:31:14 -07:00
browser_linux.cc fix: set size of GTK about panel icon (#18957) 2019-06-25 22:17:30 -07:00
browser_mac.mm refactor: simplify RemoveFromLoginItems (#19179) 2019-07-15 14:36:23 -07:00
browser_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser_process_impl.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
browser_process_impl.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
browser_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
child_web_contents_tracker.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
child_web_contents_tracker.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
common_web_contents_delegate.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
common_web_contents_delegate.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
common_web_contents_delegate_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
common_web_contents_delegate_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
cookie_change_notifier.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
cookie_change_notifier.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
fake_location_provider.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
fake_location_provider.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
feature_list.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
feature_list.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
font_defaults.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
font_defaults.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
io_thread.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
io_thread.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
javascript_environment.cc chore: update to Node.js v12.4.0 (#18924) 2019-07-15 18:58:39 -07:00
javascript_environment.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
login_handler.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
login_handler.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
microtasks_runner.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
microtasks_runner.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_mac.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_views.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
native_window.h chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
native_window_mac.h chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
native_window_mac.mm chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
native_window_observer.h feat: add rotate gesture for macOS (#19294) 2019-07-23 14:42:26 -05:00
native_window_views.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
native_window_views.h chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
native_window_views_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
node_debugger.cc fix: ensure we wait for the inspect to disconnect 2019-07-24 14:43:49 -07:00
node_debugger.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
pref_store_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
pref_store_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
relauncher.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
relauncher.h chore: fix linting after shell rename 2019-06-19 17:33:28 -07:00
relauncher_linux.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
relauncher_mac.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
relauncher_win.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
session_preferences.cc fix: ignore non-absolute session preload script paths when sandboxed (#19066) 2019-07-03 08:05:45 -07:00
session_preferences.h fix: ignore non-absolute session preload script paths when sandboxed (#19066) 2019-07-03 08:05:45 -07:00
special_storage_policy.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
special_storage_policy.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
unresponsive_suppressor.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
unresponsive_suppressor.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_permission_helper.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
web_contents_permission_helper.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
web_contents_preferences.cc chore: pass base::StringPiece args by value (#19432) 2019-07-25 10:19:04 -05:00
web_contents_preferences.h chore: pass base::StringPiece args by value (#19432) 2019-07-25 10:19:04 -05:00
web_contents_zoom_controller.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_zoom_controller.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_dialog_helper.cc chore: DirectoryLister memory management improvement (#18634) 2019-07-01 07:58:06 -07:00
web_dialog_helper.h chore: DirectoryLister memory management improvement (#18634) 2019-07-01 07:58:06 -07:00
web_view_guest_delegate.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
web_view_guest_delegate.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
web_view_manager.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
web_view_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
zoom_level_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
zoom_level_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00