electron/atom/browser/ui/win
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
atom_desktop_native_widget_aura.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_desktop_native_widget_aura.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_desktop_window_tree_host_win.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_desktop_window_tree_host_win.h clang-format atom files 2018-04-18 20:48:45 -04:00
jump_list.cc chore: fix some more warnings in windows build (#13431) 2018-06-26 02:00:20 +02:00
jump_list.h chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
message_handler_delegate.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
message_handler_delegate.h clang-format atom files 2018-04-18 20:48:45 -04:00
notify_icon.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
notify_icon.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
notify_icon_host.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
notify_icon_host.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
taskbar_host.cc chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
taskbar_host.h chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00