
* Update to Chromium 68.0.3440.128 and Node 10.10.0
* update v8, ffmpeg, chromium, crashpad, boringssl, and webrtc patches
* fix SSL_get_tlsext_status_type patch
* pass encryption_modes_supported to CdmInfo
* kNoSandbox moved into service_manager
* bump CHROME_VERSION_STRING
TODO: automatically pull in the real chrome version
* PathService -> base::PathService
* net::X509Certificate::Equals -> net::X509Certificate::EqualsExcludingChain
* use content::ChildProcessTerminationInfo
* GetHandle() -> GetProcess().Handle()
* ScopedNestableTaskAllower doesn't take an argument
* net::HttpAuthCache::ClearEntriesAddedWithin -> ClearAllEntries
* std::unique_ptr<WebContents>
* blink::WebFullscreenOptions
* OnAudioStateChanged doesn't take a WebContents
* content::RESULT_CODE_NORMAL_EXIT -> service_manager::RESULT_CODE_NORMAL_EXIT
* MessageLoopCurrent
* WasResized -> SynchronizeVisualProperties
* SetTimeStamp takes a base::TimeTicks
* ExecuteScriptInIsolatedWorld is single-script only
* DispatchNonPersistentCloseEvent takes a callback now
* expose URLRequestContextGetter::{Add,Remove}Observer
* test: remove no longer existing Chromium test deps
cc_blink_unittests has been removed in
https://chromium-review.googlesource.com/1053765
mojo_common_unittests has been removed in
https://chromium-review.googlesource.com/1028000
* SetFdLimit -> IncreaseFdLimitTo
NOTE: the behaviour of this API has changed slightly, and we should
mention that in the notes.
* MessageLoop::QuitWhenIdleClosure -> RunLoop::QuitCurrentWhenIdleClosureDeprecated
* certificate_transparency moved out of net/
pending a clearer decision about what to do with CT
in the mean time, copy CreateLogVerifiersForKnownLogs from deleted chromium source
* add secure_origin_whitelist to chrome source list
NOTE: is this something we actually want? cc @deepak1556
* DrainBackgroundTasks -> DrainTasks
* use new node options parser
* fix disable_scroll_begin_dcheck.patch
* ViewsDelegate::CreateWebContents went away
see 1031314
* kZygoteProcess moved into service_manager
* test: minor improvements to the Node spec
- reformat some parts
- better failures reporting with `expect`
- skip some tests instead of marking them as passed
* chromium removed *_posix.cc from the source filters
* test: fix :electron_tests compilation
* better crash diagnostics in ffmpeg test
* fix: enable back a DCHECK in viz::ServerSharedBitmapManager
Fixes #14327.
Backports https://chromium-review.googlesource.com/802574.
* chore: update linux sysroots
* chore: remove obsolete "install-sysroot.py" script
* test: fix frame-subscriber test on Mac
* disable OSR for now
* test: make before-input-event test more robust
* test: make run-as-node --inspect test more robust on windows
* roll node to v10.11.0
* avoid duplicate files when building a zip
* disable failing assert in beginFrameSubscription dirty-rectangle test
* experiment with is_cfi = false
* fix: build torque with x64 toolchain
Co-Authored-By: Alexey Kuzmin <github@alexeykuzmin.com>
* test: disable the "app.relaunch" test on Linux
* chore: bump node to get header tar file
* chore: bump node to fix tar.py line endings
235 lines
10 KiB
Diff
235 lines
10 KiB
Diff
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
|
|
index 321a12f74202..7a53675a2139 100644
|
|
--- a/content/browser/frame_host/render_frame_host_impl.cc
|
|
+++ b/content/browser/frame_host/render_frame_host_impl.cc
|
|
@@ -3058,6 +3058,38 @@ void RenderFrameHostImpl::CreateNewWindow(
|
|
"frame_tree_node", frame_tree_node_->frame_tree_node_id(), "url",
|
|
params->target_url.possibly_invalid_spec());
|
|
|
|
+ scoped_refptr<network::ResourceRequestBody> body;
|
|
+ if (params->body->has_object) {
|
|
+ body = new network::ResourceRequestBody;
|
|
+ std::vector<network::DataElement> elements;
|
|
+ for (const auto& iter : params->body->elements) {
|
|
+ network::DataElement element;
|
|
+ switch (iter->type) {
|
|
+ case network::DataElement::TYPE_BYTES: {
|
|
+ element.SetToBytes(iter->bytes.data(), iter->bytes.length());
|
|
+ break;
|
|
+ }
|
|
+ case network::DataElement::TYPE_FILE: {
|
|
+ element.SetToFilePathRange(iter->path, iter->offset, iter->length,
|
|
+ iter->expected_modification_time);
|
|
+ break;
|
|
+ }
|
|
+ case network::DataElement::TYPE_BLOB: {
|
|
+ element.SetToBlobRange(iter->blob_uuid, iter->offset, iter->length);
|
|
+ break;
|
|
+ }
|
|
+ case network::DataElement::TYPE_DATA_PIPE:
|
|
+ default:
|
|
+ NOTREACHED();
|
|
+ break;
|
|
+ }
|
|
+ elements.push_back(std::move(element));
|
|
+ }
|
|
+ body->swap_elements(&elements);
|
|
+ body->set_identifier(params->body->identifier);
|
|
+ body->set_contains_sensitive_info(params->body->contains_sensitive_info);
|
|
+ }
|
|
+
|
|
bool no_javascript_access = false;
|
|
|
|
// Filter out URLs to which navigation is disallowed from this context.
|
|
@@ -3080,8 +3112,9 @@ void RenderFrameHostImpl::CreateNewWindow(
|
|
frame_tree_node_->frame_tree()->GetMainFrame()->GetLastCommittedURL(),
|
|
last_committed_origin_.GetURL(), params->window_container_type,
|
|
params->target_url, params->referrer, params->frame_name,
|
|
- params->disposition, *params->features, params->user_gesture,
|
|
- params->opener_suppressed, &no_javascript_access);
|
|
+ params->disposition, *params->features, params->additional_features,
|
|
+ body, params->user_gesture, params->opener_suppressed,
|
|
+ &no_javascript_access);
|
|
|
|
if (!can_create_window) {
|
|
std::move(callback).Run(mojom::CreateNewWindowStatus::kIgnore, nullptr);
|
|
diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc
|
|
index 9c298b182440..2fcbde75ba47 100644
|
|
--- a/content/browser/security_exploit_browsertest.cc
|
|
+++ b/content/browser/security_exploit_browsertest.cc
|
|
@@ -293,6 +293,7 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest,
|
|
|
|
mojom::CreateNewWindowParamsPtr params = mojom::CreateNewWindowParams::New();
|
|
params->target_url = GURL("about:blank");
|
|
+ params->body = mojom::ResourceRequestBody::New();
|
|
pending_rfh->CreateNewWindow(
|
|
std::move(params), base::BindOnce([](mojom::CreateNewWindowStatus,
|
|
mojom::CreateNewWindowReplyPtr) {}));
|
|
diff --git a/content/common/frame.mojom b/content/common/frame.mojom
|
|
index 09b5766c0794..edb604c80d3f 100644
|
|
--- a/content/common/frame.mojom
|
|
+++ b/content/common/frame.mojom
|
|
@@ -11,6 +11,8 @@ import "content/public/common/resource_type.mojom";
|
|
import "content/public/common/resource_load_info.mojom";
|
|
import "content/public/common/transferrable_url_loader.mojom";
|
|
import "content/public/common/window_container_type.mojom";
|
|
+import "mojo/public/mojom/base/file_path.mojom";
|
|
+import "mojo/public/mojom/base/time.mojom";
|
|
import "mojo/public/mojom/base/string16.mojom";
|
|
import "mojo/public/mojom/base/unguessable_token.mojom";
|
|
import "services/network/public/mojom/url_loader.mojom";
|
|
@@ -148,6 +150,24 @@ interface FrameFactory {
|
|
CreateFrame(int32 frame_routing_id, Frame& frame);
|
|
};
|
|
|
|
+struct DataElement {
|
|
+ int32 type;
|
|
+ int64 length;
|
|
+ string bytes;
|
|
+ mojo_base.mojom.FilePath path;
|
|
+ int64 offset;
|
|
+ mojo_base.mojom.Time expected_modification_time;
|
|
+ url.mojom.Url filesystem_url;
|
|
+ string blob_uuid;
|
|
+};
|
|
+
|
|
+struct ResourceRequestBody {
|
|
+ bool has_object;
|
|
+ int64 identifier;
|
|
+ bool contains_sensitive_info;
|
|
+ array<DataElement> elements;
|
|
+};
|
|
+
|
|
struct CreateNewWindowParams {
|
|
// True if this open request came in the context of a user gesture.
|
|
bool user_gesture;
|
|
@@ -184,6 +204,10 @@ struct CreateNewWindowParams {
|
|
|
|
// The window features to use for the new window.
|
|
blink.mojom.WindowFeatures features;
|
|
+
|
|
+ // Extra fields added by Electron.
|
|
+ array<string> additional_features;
|
|
+ ResourceRequestBody body;
|
|
};
|
|
|
|
// Operation result when the renderer asks the browser to create a new window.
|
|
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
|
|
index a8927d0ba8da..396ae3d82ba2 100644
|
|
--- a/content/public/browser/content_browser_client.cc
|
|
+++ b/content/public/browser/content_browser_client.cc
|
|
@@ -401,6 +401,8 @@ bool ContentBrowserClient::CanCreateWindow(
|
|
const std::string& frame_name,
|
|
WindowOpenDisposition disposition,
|
|
const blink::mojom::WindowFeatures& features,
|
|
+ const std::vector<std::string>& additional_features,
|
|
+ const scoped_refptr<network::ResourceRequestBody>& body,
|
|
bool user_gesture,
|
|
bool opener_suppressed,
|
|
bool* no_javascript_access) {
|
|
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
|
|
index e9c6b810e050..3ca627448e33 100644
|
|
--- a/content/public/browser/content_browser_client.h
|
|
+++ b/content/public/browser/content_browser_client.h
|
|
@@ -153,6 +153,7 @@ class RenderFrameHost;
|
|
class RenderProcessHost;
|
|
class RenderViewHost;
|
|
class ResourceContext;
|
|
+class ResourceRequestBody;
|
|
class ServiceManagerConnection;
|
|
class SiteInstance;
|
|
class SpeechRecognitionManagerDelegate;
|
|
@@ -651,6 +652,8 @@ class CONTENT_EXPORT ContentBrowserClient {
|
|
const std::string& frame_name,
|
|
WindowOpenDisposition disposition,
|
|
const blink::mojom::WindowFeatures& features,
|
|
+ const std::vector<std::string>& additional_features,
|
|
+ const scoped_refptr<network::ResourceRequestBody>& body,
|
|
bool user_gesture,
|
|
bool opener_suppressed,
|
|
bool* no_javascript_access);
|
|
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
|
|
index 4aba7a9e290e..a13cc1599d70 100644
|
|
--- a/content/renderer/render_view_impl.cc
|
|
+++ b/content/renderer/render_view_impl.cc
|
|
@@ -78,6 +78,7 @@
|
|
#include "content/renderer/ime_event_guard.h"
|
|
#include "content/renderer/internal_document_state_data.h"
|
|
#include "content/renderer/loader/request_extra_data.h"
|
|
+#include "content/renderer/loader/web_url_request_util.h"
|
|
#include "content/renderer/media/audio_device_factory.h"
|
|
#include "content/renderer/media/stream/media_stream_device_observer.h"
|
|
#include "content/renderer/media/video_capture_impl_manager.h"
|
|
@@ -1243,6 +1244,46 @@ WebView* RenderViewImpl::CreateView(WebLocalFrame* creator,
|
|
}
|
|
params->features = ConvertWebWindowFeaturesToMojoWindowFeatures(features);
|
|
|
|
+ params->body = mojom::ResourceRequestBody::New();
|
|
+ auto body = GetRequestBodyForWebURLRequest(request);
|
|
+ if (body) {
|
|
+ params->body->has_object = true;
|
|
+ params->body->identifier = body->identifier();
|
|
+ params->body->contains_sensitive_info = body->contains_sensitive_info();
|
|
+ for (const auto& element : *body->elements()) {
|
|
+ content::mojom::DataElementPtr ptr = content::mojom::DataElement::New();
|
|
+ ptr->type = element.type();
|
|
+ switch (element.type()) {
|
|
+ case network::DataElement::TYPE_BYTES: {
|
|
+ ptr->bytes = std::string(element.bytes(), element.length());
|
|
+ break;
|
|
+ }
|
|
+ case network::DataElement::TYPE_FILE: {
|
|
+ ptr->path = element.path();
|
|
+ ptr->offset = element.offset();
|
|
+ ptr->length = element.length();
|
|
+ ptr->expected_modification_time = element.expected_modification_time();
|
|
+ break;
|
|
+ }
|
|
+ case network::DataElement::TYPE_BLOB: {
|
|
+ ptr->blob_uuid = element.blob_uuid();
|
|
+ ptr->offset = element.offset();
|
|
+ ptr->length = element.length();
|
|
+ break;
|
|
+ }
|
|
+ case network::DataElement::TYPE_CHUNKED_DATA_PIPE:
|
|
+ case network::DataElement::TYPE_RAW_FILE:
|
|
+ case network::DataElement::TYPE_DATA_PIPE:
|
|
+ case network::DataElement::TYPE_UNKNOWN:
|
|
+ NOTREACHED();
|
|
+ break;
|
|
+ }
|
|
+ params->body->elements.push_back(std::move(ptr));
|
|
+ }
|
|
+ } else {
|
|
+ params->body->has_object = false;
|
|
+ }
|
|
+
|
|
// We preserve this information before sending the message since |params| is
|
|
// moved on send.
|
|
bool is_background_tab =
|
|
diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.cc b/content/shell/browser/layout_test/layout_test_content_browser_client.cc
|
|
index 3a908d742130..52294125b799 100644
|
|
--- a/content/shell/browser/layout_test/layout_test_content_browser_client.cc
|
|
+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.cc
|
|
@@ -247,6 +247,8 @@ bool LayoutTestContentBrowserClient::CanCreateWindow(
|
|
const std::string& frame_name,
|
|
WindowOpenDisposition disposition,
|
|
const blink::mojom::WindowFeatures& features,
|
|
+ const std::vector<std::string>& additional_features,
|
|
+ const scoped_refptr<network::ResourceRequestBody>& body,
|
|
bool user_gesture,
|
|
bool opener_suppressed,
|
|
bool* no_javascript_access) {
|
|
diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.h b/content/shell/browser/layout_test/layout_test_content_browser_client.h
|
|
index d0ba19167522..3d1154b3cb8a 100644
|
|
--- a/content/shell/browser/layout_test/layout_test_content_browser_client.h
|
|
+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.h
|
|
@@ -67,6 +67,8 @@ class LayoutTestContentBrowserClient : public ShellContentBrowserClient {
|
|
const std::string& frame_name,
|
|
WindowOpenDisposition disposition,
|
|
const blink::mojom::WindowFeatures& features,
|
|
+ const std::vector<std::string>& additional_features,
|
|
+ const scoped_refptr<network::ResourceRequestBody>& body,
|
|
bool user_gesture,
|
|
bool opener_suppressed,
|
|
bool* no_javascript_access) override;
|