6ff111a141
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
55 lines
1.6 KiB
C++
55 lines
1.6 KiB
C++
// Copyright (c) 2014 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ATOM_BROWSER_API_EVENT_H_
|
|
#define ATOM_BROWSER_API_EVENT_H_
|
|
|
|
#include "content/public/browser/web_contents_observer.h"
|
|
#include "native_mate/handle.h"
|
|
#include "native_mate/wrappable.h"
|
|
|
|
namespace IPC {
|
|
class Message;
|
|
}
|
|
|
|
namespace mate {
|
|
|
|
class Event : public Wrappable<Event>, public content::WebContentsObserver {
|
|
public:
|
|
static Handle<Event> Create(v8::Isolate* isolate);
|
|
|
|
static void BuildPrototype(v8::Isolate* isolate,
|
|
v8::Local<v8::FunctionTemplate> prototype);
|
|
|
|
// Pass the sender and message to be replied.
|
|
void SetSenderAndMessage(content::RenderFrameHost* sender,
|
|
IPC::Message* message);
|
|
|
|
// event.PreventDefault().
|
|
void PreventDefault(v8::Isolate* isolate);
|
|
|
|
// event.sendReply(array), used for replying synchronous message.
|
|
bool SendReply(const base::ListValue& result);
|
|
|
|
protected:
|
|
explicit Event(v8::Isolate* isolate);
|
|
~Event() override;
|
|
|
|
// content::WebContentsObserver implementations:
|
|
void RenderFrameDeleted(content::RenderFrameHost* rfh) override;
|
|
void RenderFrameHostChanged(content::RenderFrameHost* old_rfh,
|
|
content::RenderFrameHost* new_rfh) override;
|
|
void FrameDeleted(content::RenderFrameHost* rfh) override;
|
|
|
|
private:
|
|
// Replyer for the synchronous messages.
|
|
content::RenderFrameHost* sender_ = nullptr;
|
|
IPC::Message* message_ = nullptr;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(Event);
|
|
};
|
|
|
|
} // namespace mate
|
|
|
|
#endif // ATOM_BROWSER_API_EVENT_H_
|