![electron-roller[bot]](/assets/img/avatar_default.png)
* chore: bump chromium in DEPS to 137.0.7107.0 * chore: bump chromium in DEPS to 137.0.7109.0 * chore: bump chromium in DEPS to 137.0.7111.0 * chore: bump chromium in DEPS to 137.0.7113.0 * 6384240: Remove double-declaration for accessibility on macOS |6384240
* 6422872: Remove unused includes in isolation_info_mojom_traits.h |6422872
* chore: update patches * 6400733: Avoid ipc_message_macros.h usage in some foo_param_traits_macros.h files |6400733
* chore: update patches * 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
* chore: iwyu * refactor: prefer value initialization over memset() From the looks up upstream commits in base/, it looks like memset() could trigger `-Wunsafe-buffer-usage` warnings soon? Value initialization is more C++ish and less error-prone anyway, due to memset()'s easily swappable parameters. * refactor: NotifyIcon::InitIconData() returns a NOTIFYICONDATA This follows F.20 in the C++ Core Guidelines and also removes the need for memset() * 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
remove all uses of: - strcmp() * fixup! 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
* 6433203: Add a PassKey to RegisterDeleteDelegateCallback(). |6433203
* chore: bump chromium in DEPS to 137.0.7115.0 * 6387077: [PermissionOptions] Generalize PermissionRequestDescription |6387077
* chore: update patches * 6387077: [PermissionOptions] Generalize PermissionRequestDescription |6387077
* fix: add pragma for MacSDK unsafe buffers | 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
* chore: bump chromium in DEPS to 137.0.7117.0 * chore: update patches * chore: update filesnames.libcxx.gni * 6431756: Replace SetOwnedByWidget() bool arg with a PassKey. |6431756
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription |6387077
* 6428345: Remove ExtensionService usage from ChromeExtensionRegistrarDelegate |6428345
* 6384315: Migrate extensions_enabled from ExtensionService to Registrar |6384315
* 6428749: [extensions] Refactor ExtensionService for AddNewAndUpdateExtension. |6428749
* chore: bump chromium in DEPS to 137.0.7119.0 * 6440290: corner-shape: support inset shadow |6440290
* 6429230: FSA: Move blocked paths to the PermissionContext class |6429230
* chore: update patches * chore: bump chromium in DEPS to 137.0.7121.0 * chore: update patches * fix: partially revert 6443473: Remove ItemDelete from the Mac version of AppleKeychain |6443473
* fix: update filenames.libcxx.gni * chore: bump chromium in DEPS to 137.0.7123.0 * chore: update patches * chore: "grandfather in" electron views too Lock further access to View::set_owned_by_client() |6448510
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch corner-shape: support inset shadow |6440290
* refactor: grandfather in AutofillPopupView as a subclass of WidgetDelegateView Add a PassKey for std::make_unique<WidgetDelegateView>() |6442265
* Provide dbus appmenu information on Wayland |6405535
* [extensions] Move OnExtensionInstalled out of ExtensionService. |6443325
* refactor: grandfather in NativeWindowViews for delete callbacks 6433203: Add a PassKey to RegisterDeleteDelegateCallback(). |6433203
* chore: merge the four "grandfather" patches into one * [A11yPerformance] Remove IsAccessibilityAllowed() | 6404386: [A11yPerformance] Remove IsAccessibilityAllowed() |6404386
NB: the changes here are copied from the upstream changes in chrome/browser/ui/webui/accessibility/accessibility_ui.cc * 6420753: [PermissionOptions] Use PermissionDescriptorPtr in PermissionController |6420753
* 6429573: [accessibility] Move mode change out of AccessibilityNotificationWaiter |6429573
* chore: e patches all * 6419936: [win] Change ScreenWin public static methods to virtual |6419936
* 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
remove all uses of: - fprintf() - fputs() - snprintf() - vsnprintf() * fix: size conversion FTBFS on Win * 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
remove all uses of: - wcscpy_s() * 6423410: Enable unsafe buffer warnings for chromium, try #3. |6423410
remove all uses of: - wcsncpy_s() * chore: update mas_avoid_private_macos_api_usage.patch.patch 6394283: Remove double-declaration for accessibility on iOS |6394283
Lots of context shear in this commit but the only interesting part is: -+ return nullptr; ++ return {}; Which is needed because the return type is sometimes not a pointer. * chore: e patches all * chore: disable -Wmacro-redefined warning in electron_main_win.cc * chore: bump chromium in DEPS to 137.0.7123.5 * refactor: patch electron PermissionTypes into blink 6387077: [PermissionOptions] Generalize PermissionRequestDescription |6387077
* chore: e patches all * chore: remove the box_painter_base.cc part of feat_corner_smoothing_css_rule_and_blink_painting.patch as per code review @ https://github.com/electron/electron/pull/46482#pullrequestreview-2777338370 * test: enable window-smaller-than-64x64 test on Linux * chore: bump chromium in DEPS to 137.0.7124.1 * chore: bump chromium in DEPS to 137.0.7125.1 * chore: bump chromium in DEPS to 137.0.7127.3 * 6459201: [Extensions] Remove ExtensionSystem::FinishDelayedInstallationIfReady() |6459201
* 6454796: [Extensions] Move (most) registrar delayed install logic to //extensions |6454796
* chore: bump chromium in DEPS to 137.0.7128.1 * chore: e patches all * chore: node ./script/gen-libc++-filenames.js * [views] Gate DesktopWindowTreeHostWin::window_enlargement_ behind flag Refs6428649
* feat: allow opt-out animated_content_sampler. Refs6438681
* Trigger CI --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
108 lines
4.5 KiB
Diff
108 lines
4.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: deepak1556 <hop2deep@gmail.com>
|
|
Date: Thu, 13 Oct 2022 20:30:12 +0900
|
|
Subject: Preconnect manager
|
|
|
|
* Patch disables the profile related changes added in
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/3928470.
|
|
* Also avoids including chrome/browser/predictors/resource_prefetch_predictor.h
|
|
in favor of defining PreconnectRequest in this file since we don't build
|
|
the header.
|
|
|
|
diff --git a/chrome/browser/predictors/preconnect_manager.cc b/chrome/browser/predictors/preconnect_manager.cc
|
|
index 5741fefef3a3a803a4e463ada1980d5d09a9ebe3..e8c4ccb63425a4097794dc33eccc64d54b384af9 100644
|
|
--- a/chrome/browser/predictors/preconnect_manager.cc
|
|
+++ b/chrome/browser/predictors/preconnect_manager.cc
|
|
@@ -15,9 +15,11 @@
|
|
#include "base/types/optional_util.h"
|
|
#include "chrome/browser/predictors/predictors_features.h"
|
|
#include "chrome/browser/predictors/predictors_traffic_annotations.h"
|
|
+#if 0
|
|
#include "chrome/browser/predictors/resource_prefetch_predictor.h"
|
|
#include "chrome/browser/preloading/preloading_prefs.h"
|
|
#include "chrome/browser/profiles/profile.h"
|
|
+#endif
|
|
#include "content/public/browser/browser_context.h"
|
|
#include "content/public/browser/browser_task_traits.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
@@ -29,6 +31,20 @@ namespace predictors {
|
|
|
|
const bool kAllowCredentialsOnPreconnectByDefault = true;
|
|
|
|
+// NOTE(nornagon): this is copied from
|
|
+// //chrome/browser/predictors/resource_prefetch_predictor.cc we don't need
|
|
+// anything in that file other than this constructor.
|
|
+PreconnectRequest::PreconnectRequest(
|
|
+ const url::Origin& origin,
|
|
+ int num_sockets,
|
|
+ const net::NetworkAnonymizationKey& network_anonymization_key)
|
|
+ : origin(origin),
|
|
+ num_sockets(num_sockets),
|
|
+ network_anonymization_key(network_anonymization_key) {
|
|
+ DCHECK_GE(num_sockets, 0);
|
|
+ DCHECK(!network_anonymization_key.IsEmpty());
|
|
+}
|
|
+
|
|
PreconnectedRequestStats::PreconnectedRequestStats(const url::Origin& origin,
|
|
bool was_preconnected)
|
|
: origin(origin), was_preconnected(was_preconnected) {}
|
|
@@ -95,12 +111,15 @@ PreconnectManager::PreconnectManager(base::WeakPtr<Delegate> delegate,
|
|
PreconnectManager::~PreconnectManager() = default;
|
|
|
|
bool PreconnectManager::IsEnabled() {
|
|
+#if 0
|
|
Profile* profile = Profile::FromBrowserContext(browser_context_);
|
|
if (!profile) {
|
|
return false;
|
|
}
|
|
return prefetch::IsSomePreloadingEnabled(*profile->GetPrefs()) ==
|
|
content::PreloadingEligibility::kEligible;
|
|
+#endif
|
|
+ return true;
|
|
}
|
|
|
|
void PreconnectManager::Start(const GURL& url,
|
|
diff --git a/chrome/browser/predictors/preconnect_manager.h b/chrome/browser/predictors/preconnect_manager.h
|
|
index 107c0f79ccf10eb5d16181213e12c93f1abc62d6..9babefff03899de91519474956ba1297fbd1c95d 100644
|
|
--- a/chrome/browser/predictors/preconnect_manager.h
|
|
+++ b/chrome/browser/predictors/preconnect_manager.h
|
|
@@ -17,7 +17,9 @@
|
|
#include "base/time/time.h"
|
|
#include "chrome/browser/predictors/proxy_lookup_client_impl.h"
|
|
#include "chrome/browser/predictors/resolve_host_client_impl.h"
|
|
+#if 0
|
|
#include "chrome/browser/predictors/resource_prefetch_predictor.h"
|
|
+#endif
|
|
#include "content/public/browser/storage_partition_config.h"
|
|
#include "net/base/network_anonymization_key.h"
|
|
#include "url/gurl.h"
|
|
@@ -34,7 +36,28 @@ class NetworkContext;
|
|
|
|
namespace predictors {
|
|
|
|
-struct PreconnectRequest;
|
|
+// Stores all values needed to trigger a preconnect/preresolve job to a single
|
|
+// origin.
|
|
+struct PreconnectRequest {
|
|
+ // |network_anonymization_key| specifies the key that network requests for the
|
|
+ // preconnected URL are expected to use. If a request is issued with a
|
|
+ // different key, it may not use the preconnected socket. It has no effect
|
|
+ // when |num_sockets| == 0.
|
|
+ PreconnectRequest(
|
|
+ const url::Origin& origin,
|
|
+ int num_sockets,
|
|
+ const net::NetworkAnonymizationKey& network_anonymization_key);
|
|
+ PreconnectRequest(const PreconnectRequest&) = default;
|
|
+ PreconnectRequest(PreconnectRequest&&) = default;
|
|
+ PreconnectRequest& operator=(const PreconnectRequest&) = default;
|
|
+ PreconnectRequest& operator=(PreconnectRequest&&) = default;
|
|
+
|
|
+ url::Origin origin;
|
|
+ // A zero-value means that we need to preresolve a host only.
|
|
+ int num_sockets = 0;
|
|
+ bool allow_credentials = true;
|
|
+ net::NetworkAnonymizationKey network_anonymization_key;
|
|
+};
|
|
|
|
struct PreconnectedRequestStats {
|
|
PreconnectedRequestStats(const url::Origin& origin, bool was_preconnected);
|