electron/brightray
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
browser fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
common fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
BUILD.gn chore: remove unsupported DISABLE_NACL define 2018-09-12 12:09:41 -07:00
CPPLINT.cfg Add clang-format script and precommit hook (#12651) 2018-04-27 13:01:12 -04:00
LICENSE
LICENSE-CHROMIUM