electron/atom/common/native_mate_converters
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
accelerator_converter.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
accelerator_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
blink_converter.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
blink_converter.h The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
callback.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
callback.h clang-format atom files 2018-04-18 20:48:45 -04:00
content_converter.cc chore: Annotate fallthrough switch paths with FALLTHROUGH 2018-06-20 14:38:18 -07:00
content_converter.h The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
file_path_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
gfx_converter.cc Add gfx:PointF support to mate::Converter 2018-06-19 11:49:45 +10:00
gfx_converter.h Add gfx:PointF support to mate::Converter 2018-06-19 11:49:45 +10:00
gurl_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
image_converter.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
image_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
net_converter.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
net_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
network_converter.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
network_converter.h Create network_converter for services/network/* types 2018-06-19 11:49:42 +10:00
string16_converter.h don't use native_mate/compat.h macros (#12984) 2018-05-18 09:08:28 +09:00
ui_base_types_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
v8_value_converter.cc refactor: remove deprecated GetAs methods (#13425) 2018-06-27 14:52:48 -07:00
v8_value_converter.h perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
value_converter.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
value_converter.h refactor: remove instances of createDeepCopy (#13703) 2018-08-04 07:23:07 +10:00