electron/atom/browser/ui/views
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
autofill_popup_view.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
autofill_popup_view.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
frameless_view.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
frameless_view.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
global_menu_bar_x11.cc Wrap X11 headers in ui/gfx/x/x11.h 2018-06-19 11:49:43 +10:00
global_menu_bar_x11.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
menu_bar.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
menu_bar.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
menu_delegate.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
menu_delegate.h refactor: chromium-style warnings in linux code (#12949) 2018-05-16 14:12:45 -05:00
menu_model_adapter.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
menu_model_adapter.h Fix chromium-style errors (#12802) 2018-05-03 09:04:22 -05:00
native_frame_view.cc fix: unused variable warnings in linux code (#12950) 2018-05-15 13:49:27 -05:00
native_frame_view.h fix: unused variable warnings in linux code (#12950) 2018-05-15 13:49:27 -05:00
root_view.cc check content view in SetMenuBarVisibility 2018-05-15 14:12:47 +09:00
root_view.h refactor: NativeWindowViews should not be a View (#12750) 2018-05-01 13:28:22 +09:00
submenu_button.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
submenu_button.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
win_frame_view.cc chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
win_frame_view.h chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00