electron/atom/browser/osr
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
osr_output_device.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
osr_output_device.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
osr_render_widget_host_view.cc chore: fix a chromium-style error 2018-09-11 20:24:03 +02:00
osr_render_widget_host_view.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
osr_render_widget_host_view_mac.mm fix: fix osr compilation on Windows 2018-09-11 20:24:03 +02:00
osr_view_proxy.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
osr_view_proxy.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
osr_web_contents_view.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
osr_web_contents_view.h Update OSR code 2018-06-19 11:49:44 +10:00
osr_web_contents_view_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00