mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/atom/browser/api
History
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583) 
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
atom_api_app.cc Remove the memory property from getAppMetrics 2018-09-11 20:24:03 +02:00
atom_api_app.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_app_mas.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_api_auto_updater.cc
atom_api_auto_updater.h
atom_api_box_layout.cc Add View.addChildView API 2018-05-24 15:36:29 +09:00
atom_api_box_layout.h Add View.addChildView API 2018-05-24 15:36:29 +09:00
atom_api_browser_view.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_browser_view.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_browser_window.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_browser_window.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_browser_window_mac.mm fix: use InspectableWebContentsView as content view 2018-07-16 10:20:35 +09:00
atom_api_browser_window_views.cc
atom_api_button.cc feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_button.h feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_content_tracing.cc
atom_api_cookies.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_cookies.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_debugger.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_debugger.h chore: enable debugger api specs (#14475) 2018-09-07 00:44:22 +10:00
atom_api_desktop_capturer.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_desktop_capturer.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_dialog.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_download_item.cc Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
atom_api_download_item.h Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
atom_api_global_shortcut.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_global_shortcut.h
atom_api_in_app_purchase.cc
atom_api_in_app_purchase.h
atom_api_label_button.cc feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_label_button.h feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_layout_manager.cc Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
atom_api_layout_manager.h Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
atom_api_menu.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_menu.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_menu_mac.h
atom_api_menu_mac.mm Fix: Prevent menu update while it's open (#12809) 2018-05-17 11:19:28 +10:00
atom_api_menu_views.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_menu_views.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_net.cc
atom_api_net.h
atom_api_net_log.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_net_log.h feat: netLog API for dynamic logging control (#13068) 2018-06-19 11:45:58 +10:00
atom_api_notification.cc REVIEW: Remove the notification close-closure in favour of an explicit method 2018-06-19 11:49:40 +10:00
atom_api_notification.h
atom_api_power_monitor.cc
atom_api_power_monitor.h
atom_api_power_monitor_mac.mm
atom_api_power_monitor_win.cc
atom_api_power_save_blocker.cc Remove redundant device::PowerSaveBlocker enums. 2018-06-19 11:49:41 +10:00
atom_api_power_save_blocker.h Remove redundant device::PowerSaveBlocker enums. 2018-06-19 11:49:41 +10:00
atom_api_protocol.cc [GURL] (1 of 2) Prep for stripping "username:password" from internal schemes 2018-09-11 20:24:03 +02:00
atom_api_protocol.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_render_process_preferences.cc
atom_api_render_process_preferences.h
atom_api_screen.cc remove screen.getMenuBarHeight() deprecation 2018-05-23 09:11:48 -07:00
atom_api_screen.h remove screen.getMenuBarHeight() deprecation 2018-05-23 09:11:48 -07:00
atom_api_session.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_session.h feat: add session.setPermissionCheckHandler (#13925) 2018-08-28 09:05:08 -05:00
atom_api_system_preferences.cc
atom_api_system_preferences.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_system_preferences_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_api_system_preferences_win.cc refactor: DwmGetColorizationColor does not have to be dynamically resolved 2018-07-12 22:28:44 +02:00
atom_api_text_field.cc feat: add SetText for TextField 2018-06-18 16:51:36 +09:00
atom_api_text_field.h feat: add SetText for TextField 2018-06-18 16:51:36 +09:00
atom_api_top_level_window.cc fix: Invalidate weak ptrs before window Javascript object is destroyed (#14532) 2018-09-12 13:58:04 -05:00
atom_api_top_level_window.h fix: notify focus change right away rather not on next tick (#14453) 2018-09-07 13:21:58 -05:00
atom_api_tray.cc fix: don't crash on tray.setContextMenu(null) (#14322) 2018-08-27 11:58:47 -05:00
atom_api_tray.h
atom_api_url_request.cc feat: add getUploadProgress API to the net API (#13783) 2018-07-27 07:15:48 -07:00
atom_api_url_request.h feat: add getUploadProgress API to the net API (#13783) 2018-07-27 07:15:48 -07:00
atom_api_view.cc build: add missing enable_view_api flag (#14351) 2018-08-28 10:55:31 -07:00
atom_api_view.h Put View APIs under a build flag 2018-05-24 15:44:07 +09:00
atom_api_web_contents.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_web_contents.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_web_contents_mac.mm Include missing header 2018-06-19 11:49:41 +10:00
atom_api_web_contents_osr.cc Update OSR code 2018-06-19 11:49:44 +10:00
atom_api_web_contents_view.cc Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
atom_api_web_contents_view.h
atom_api_web_request.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_web_request.h
atom_api_web_view_manager.cc fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
event.cc perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
event.h perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
event_emitter.cc update native-mate ref 2018-06-19 11:49:41 +10:00
event_emitter.h
event_subscriber.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
event_subscriber.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
frame_subscriber.cc fix: don't invoke callback after FrameSubscriber is destroyed (#13657) 2018-07-13 19:54:49 +10:00
frame_subscriber.h fix: don't invoke callback after FrameSubscriber is destroyed (#13657) 2018-07-13 19:54:49 +10:00
save_page_handler.cc Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
save_page_handler.h Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
trackable_object.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
trackable_object.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00