![trop[bot]](/assets/img/avatar_default.png)
* refactor: pass an isolate when calling GetCreationContextChecked() in V8FunctionInvoker Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in RendererClientBase Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in ScriptExecutionCallback::Completed() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in ScriptExecutionCallback::CopyResultToCallingContextAndFinalize() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in electron::GetRenderFrame() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in gin_helper::internal::CallMethodWithArgs() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in OverrideGlobalPropertyFromIsolatedWorld() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in OverrideGlobalValueFromIsolatedWorld() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in ProxyFunctionWrapper() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: pass an isolate when calling GetCreationContextChecked() in PassValueToOtherContextInner() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! refactor: pass an isolate when calling GetCreationContextChecked() in electron::GetRenderFrame() Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
43 lines
1.6 KiB
C++
43 lines
1.6 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/gin_helper/event_emitter_caller.h"
|
|
|
|
#include "shell/common/node_includes.h"
|
|
|
|
namespace gin_helper::internal {
|
|
|
|
v8::Local<v8::Value> CallMethodWithArgs(
|
|
v8::Isolate* isolate,
|
|
v8::Local<v8::Object> obj,
|
|
const char* method,
|
|
const base::span<v8::Local<v8::Value>> args) {
|
|
v8::EscapableHandleScope handle_scope{isolate};
|
|
|
|
// CallbackScope and MakeCallback both require an active node::Environment
|
|
if (!node::Environment::GetCurrent(isolate))
|
|
return handle_scope.Escape(v8::False(isolate));
|
|
|
|
node::CallbackScope callback_scope{isolate, v8::Object::New(isolate),
|
|
node::async_context{0, 0}};
|
|
|
|
// Perform microtask checkpoint after running JavaScript.
|
|
v8::MicrotasksScope microtasks_scope(obj->GetCreationContextChecked(isolate),
|
|
v8::MicrotasksScope::kRunMicrotasks);
|
|
|
|
// node::MakeCallback will also run pending tasks in Node.js.
|
|
v8::MaybeLocal<v8::Value> ret = node::MakeCallback(
|
|
isolate, obj, method, args.size(), args.data(), {0, 0});
|
|
|
|
// If the JS function throws an exception (doesn't return a value) the result
|
|
// of MakeCallback will be empty and therefore ToLocal will be false, in this
|
|
// case we need to return "false" as that indicates that the event emitter did
|
|
// not handle the event
|
|
if (v8::Local<v8::Value> localRet; ret.ToLocal(&localRet))
|
|
return handle_scope.Escape(localRet);
|
|
|
|
return handle_scope.Escape(v8::False(isolate));
|
|
}
|
|
|
|
} // namespace gin_helper::internal
|