d426b92326* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment() Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615 Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: use v8::Isolate::GetCurrent() in Initialize() methods Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
78 lines
2.7 KiB
C++
78 lines
2.7 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "base/command_line.h"
|
|
#include "base/files/file_path.h"
|
|
#include "base/strings/string_util.h"
|
|
#include "services/network/public/cpp/network_switches.h"
|
|
#include "shell/common/gin_converters/base_converter.h"
|
|
#include "shell/common/gin_converters/file_path_converter.h"
|
|
#include "shell/common/gin_helper/dictionary.h"
|
|
#include "shell/common/node_includes.h"
|
|
#include "third_party/abseil-cpp/absl/strings/ascii.h"
|
|
|
|
namespace {
|
|
bool HasSwitch(const std::string& switch_string) {
|
|
auto switch_str = base::ToLowerASCII(switch_string);
|
|
|
|
auto* command_line = base::CommandLine::ForCurrentProcess();
|
|
return command_line->HasSwitch(switch_str);
|
|
}
|
|
|
|
base::CommandLine::StringType GetSwitchValue(gin_helper::ErrorThrower thrower,
|
|
const std::string& switch_string) {
|
|
auto switch_str = base::ToLowerASCII(switch_string);
|
|
|
|
auto* command_line = base::CommandLine::ForCurrentProcess();
|
|
return command_line->GetSwitchValueNative(switch_str);
|
|
}
|
|
|
|
void AppendSwitch(const std::string& switch_string,
|
|
gin_helper::Arguments* args) {
|
|
auto switch_str = base::ToLowerASCII(switch_string);
|
|
auto* command_line = base::CommandLine::ForCurrentProcess();
|
|
if (base::EndsWith(switch_string, "-path",
|
|
base::CompareCase::INSENSITIVE_ASCII) ||
|
|
switch_string == network::switches::kLogNetLog) {
|
|
base::FilePath path;
|
|
args->GetNext(&path);
|
|
command_line->AppendSwitchPath(switch_str, path);
|
|
return;
|
|
}
|
|
|
|
base::CommandLine::StringType value;
|
|
if (args->GetNext(&value))
|
|
command_line->AppendSwitchNative(switch_str, value);
|
|
else
|
|
command_line->AppendSwitch(switch_str);
|
|
}
|
|
|
|
void RemoveSwitch(const std::string& switch_string) {
|
|
auto switch_str = base::ToLowerASCII(switch_string);
|
|
|
|
auto* command_line = base::CommandLine::ForCurrentProcess();
|
|
command_line->RemoveSwitch(switch_str);
|
|
}
|
|
|
|
void AppendArg(const std::string& arg) {
|
|
auto* command_line = base::CommandLine::ForCurrentProcess();
|
|
command_line->AppendArg(arg);
|
|
}
|
|
|
|
void Initialize(v8::Local<v8::Object> exports,
|
|
v8::Local<v8::Value> unused,
|
|
v8::Local<v8::Context> context,
|
|
void* priv) {
|
|
v8::Isolate* const isolate = v8::Isolate::GetCurrent();
|
|
gin_helper::Dictionary dict{isolate, exports};
|
|
dict.SetMethod("hasSwitch", &HasSwitch);
|
|
dict.SetMethod("getSwitchValue", &GetSwitchValue);
|
|
dict.SetMethod("appendSwitch", &AppendSwitch);
|
|
dict.SetMethod("removeSwitch", &RemoveSwitch);
|
|
dict.SetMethod("appendArgument", &AppendArg);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_common_command_line, Initialize)
|