d02c9f8bc6
* chore: bump chromium in DEPS to 111.0.5522.0 * chore: bump chromium in DEPS to 111.0.5524.0 * chore: bump chromium in DEPS to 111.0.5526.0 * chore: bump chromium in DEPS to 111.0.5528.0 * chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4132807 Fix simple code shear * chore: update patches/chromium/unsandboxed_ppapi_processes_skip_zygote.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4130675 Fix simple code shear * chore: update patches/chromium/hack_plugin_response_interceptor_to_point_to_electron.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/chromium/disable_unload_metrics.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126173 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/chromium/feat_add_data_parameter_to_processsingleton.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/chromium/preconnect_manager.patch https://chromium-review.googlesource.com/c/chromium/src/+/4144281 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches/v8/force_cppheapcreateparams_to_be_noncopyable.patch https://chromium-review.googlesource.com/c/v8/v8/+/3533019 Fix simple code shear; applied cleanly w/patch-fuzz * chore: update patches * chore: update patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4128765 Upstream added a new call to HeaderContext(), whose signature we have patched * chore: bump chromium in DEPS to 111.0.5530.0 * chore: update patches * Move ChildProcessHost* from content/common to content/browser Xref: Move ChildProcessHost* from content/common to content/browser * Remove RenderViewHostChanged Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103 [upstream removal of RenderViewHostChanged] Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4092763 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4093234 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133892 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103 [examples of upstream code adjusting to the change] Upstream handles this change in roughly two approaches: 1. Move the code over to RenderFrameHostChanged(old_host, new_host) but test for new_host->IsInPrimaryMainFrame() before acting 2. Migrate to the PrimaryPageChanged(page) API and use page.GetMainDocument() to get the RenderFrameHost. I've chosen 1. because electron_api_web_contents needed that pointer to old_host to call RemoveInputEventListener(), but I may be missing some context & would appreciate review on this commit. * Make electron/shell/browser/relauncher_win.cc use <winternl.h> Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4129135 Many internal Windows types are now available in winternl.h so upstrem no longer defines the types themselves. * Move ChildProcessHost* from content/common to content/browser Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134795 * fixup! Make electron/shell/browser/relauncher_win.cc use <winternl.h> winternl.h does not define the field we need, so clone the struct Chromium was using into unnamed namespace * fixup! Move ChildProcessHost* from content/common to content/browser chore: update #includes too * chore: bump chromium in DEPS to 111.0.5532.0 * chore: sync patches/chromium/pepper_plugin_support.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323 manually reync patch; no code changes * chore: sync patches/chromium/mas_no_private_api.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4143865 the content/common/pseudonymization_salt.cc patch is no longer needed * chore: sync patches/chromium/mas_disable_remote_accessibility.patch patch-fuzz update; no manual changes * chore: sync patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4111725 manually reync patch; no code changes * chore: sync patches/chromium/create_browser_v8_snapshot_file_name_fuse.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323 manually reync patch; no code changes * chore: sync patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4127230 patch-fuzz update; no manual changes * chore: rebuild patches * fixup! Remove RenderViewHostChanged Use PrimaryPageChanged() * chore: remove unused method TabsUpdateFunction::OnExecuteCodeFinished() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133991 This private, already-unused function showed up as a FTBFS because it took a base::ListValue parameter and ListValue was removed upstream. * task posting v3: remove includes of runner handles and IWYU task runners Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323 * chore: lint * chore: more lint * fixup! task posting v3: remove includes of runner handles and IWYU task runners macOS, too * fixup! task posting v3: remove includes of runner handles and IWYU task runners * chore: bump chromium in DEPS to 111.0.5534.0 * chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141862 patch-fuzz update; no manual changes * chore: sync patches/chromium/logging_win32_only_create_a_console_if_logging_to_stderr.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4153110 Sync to minor upstream changes. Add const correctness. * chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch https://chromium-review.googlesource.com/c/chromium/src/+/4141862 patch-fuzz update; no manual changes * chore: patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch sync https://chromium-review.googlesource.com/c/v8/v8/+/4147787 patch-fuzz update; no manual changes * chore: update patches * chore: bump chromium in DEPS to 111.0.5536.0 * chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863 Sync with upstream code changes. Minor code golf for readability. Note: upstream is laying groundwork for being able to work off of env vars instead of switches. Doesn't affect us yet but worth being aware of. > + // Environment variables could be supported in the future, but are not > + // currently supported when launching with the zygote. * chore: update patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126836 patch-fuzz update; no manual changes * chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863 manual sync * chore: sync electron/patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch https://chromium-review.googlesource.com/c/v8/v8/+/4147788 fuzz-patch * chore: rebuild patches * chore: bump chromium in DEPS to 111.0.5538.0 * chore: bump chromium in DEPS to 111.0.5540.0 * chore: update patches * Remove sdk_forward_declarations https://chromium-review.googlesource.com/c/chromium/src/+/4166680 * task posting v3: Remove task runner handles from codebase entirely Refs https://chromium-review.googlesource.com/c/chromium/src/+/4150928 * Cleanup child_process_launcher_helper* Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863 * fix: utilityprocess spec on macOS * fix: build on windows Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863 * chore: fix lint * chore: bump chromium 111.0.5544.3 * chore: gen filenames.libcxx.gni * Add check for Executable+Writable handles in renderer processes. Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774416 * fixup! Add check for Executable+Writable handles in renderer processes. * 4143761: [110] Disable SwiftShader for WebGL on M1 Macs. https://chromium-review.googlesource.com/c/chromium/src/+/4143761 (cherry picked from commit 2f74db3c2139424c416f92d9169aeaa8a2f9c1ec) * chore: bump chromium to 111.0.5555.0 * 56085: Remove hmac.h include from ssl.h. https://boringssl-review.googlesource.com/c/boringssl/+/56085 * 4167020: Remove forwarding headers https://chromium-review.googlesource.com/c/chromium/src/+/4167020 * chore: bump chromium to 111.0.5559.0 * 4181044: Restrict WebCursor usage to RenderWidgetHostViewAura https://chromium-review.googlesource.com/c/chromium/src/+/4181044 * 4189437: views: rename ink_drop_host_view to ink_drop_host https://chromium-review.googlesource.com/c/chromium/src/+/4189437 * chore: bump chromium to 111.0.5560.0 * 4167016: win7dep: remove non aeroglass code https://chromium-review.googlesource.com/c/chromium/src/+/4167016 * fixup after rebase: Remove forwarding header s https://chromium-review.googlesource.com/c/chromium/src/+/4167020 * 4125755: Reland "Reject getDisplayMedia calls without user activation" https://chromium-review.googlesource.com/c/chromium/src/+/4125755 * test: add workaround * chore: update patches * fix: alter coreModuleRegExp to prevent arm crash * Revert "fix: alter coreModuleRegExp to prevent arm crash" This reverts commit 7e50630c98137831a711c5abdbc8809e60cf1d73. * 4218354: Disable the use of preserve_most on arm64 Windows https://chromium-review.googlesource.com/c/v8/v8/+/4218354 * chore: review changes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
327 lines
11 KiB
C++
327 lines
11 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/browser/javascript_environment.h"
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <unordered_set>
|
|
#include <utility>
|
|
|
|
#include "base/allocator/partition_alloc_features.h"
|
|
#include "base/allocator/partition_allocator/partition_alloc.h"
|
|
#include "base/bits.h"
|
|
#include "base/command_line.h"
|
|
#include "base/feature_list.h"
|
|
#include "base/task/current_thread.h"
|
|
#include "base/task/single_thread_task_runner.h"
|
|
#include "base/task/thread_pool/initialization_util.h"
|
|
#include "base/trace_event/trace_event.h"
|
|
#include "gin/array_buffer.h"
|
|
#include "gin/v8_initializer.h"
|
|
#include "shell/browser/microtasks_runner.h"
|
|
#include "shell/common/gin_helper/cleaned_up_at_exit.h"
|
|
#include "shell/common/node_includes.h"
|
|
#include "third_party/blink/public/common/switches.h"
|
|
#include "third_party/electron_node/src/node_wasm_web_api.h"
|
|
|
|
namespace {
|
|
v8::Isolate* g_isolate;
|
|
}
|
|
|
|
namespace gin {
|
|
|
|
class ConvertableToTraceFormatWrapper final
|
|
: public base::trace_event::ConvertableToTraceFormat {
|
|
public:
|
|
explicit ConvertableToTraceFormatWrapper(
|
|
std::unique_ptr<v8::ConvertableToTraceFormat> inner)
|
|
: inner_(std::move(inner)) {}
|
|
~ConvertableToTraceFormatWrapper() override = default;
|
|
|
|
// disable copy
|
|
ConvertableToTraceFormatWrapper(const ConvertableToTraceFormatWrapper&) =
|
|
delete;
|
|
ConvertableToTraceFormatWrapper& operator=(
|
|
const ConvertableToTraceFormatWrapper&) = delete;
|
|
|
|
void AppendAsTraceFormat(std::string* out) const final {
|
|
inner_->AppendAsTraceFormat(out);
|
|
}
|
|
|
|
private:
|
|
std::unique_ptr<v8::ConvertableToTraceFormat> inner_;
|
|
};
|
|
|
|
} // namespace gin
|
|
|
|
// Allow std::unique_ptr<v8::ConvertableToTraceFormat> to be a valid
|
|
// initialization value for trace macros.
|
|
template <>
|
|
struct base::trace_event::TraceValue::Helper<
|
|
std::unique_ptr<v8::ConvertableToTraceFormat>> {
|
|
static constexpr unsigned char kType = TRACE_VALUE_TYPE_CONVERTABLE;
|
|
static inline void SetValue(
|
|
TraceValue* v,
|
|
std::unique_ptr<v8::ConvertableToTraceFormat> value) {
|
|
// NOTE: |as_convertable| is an owning pointer, so using new here
|
|
// is acceptable.
|
|
v->as_convertable =
|
|
new gin::ConvertableToTraceFormatWrapper(std::move(value));
|
|
}
|
|
};
|
|
|
|
namespace electron {
|
|
|
|
JavascriptEnvironment::JavascriptEnvironment(uv_loop_t* event_loop,
|
|
bool setup_wasm_streaming)
|
|
: isolate_(Initialize(event_loop, setup_wasm_streaming)),
|
|
isolate_holder_(base::SingleThreadTaskRunner::GetCurrentDefault(),
|
|
gin::IsolateHolder::kSingleThread,
|
|
gin::IsolateHolder::kAllowAtomicsWait,
|
|
gin::IsolateHolder::IsolateType::kUtility,
|
|
gin::IsolateHolder::IsolateCreationMode::kNormal,
|
|
nullptr,
|
|
nullptr,
|
|
isolate_),
|
|
locker_(isolate_) {
|
|
isolate_->Enter();
|
|
v8::HandleScope scope(isolate_);
|
|
auto context = node::NewContext(isolate_);
|
|
context_ = v8::Global<v8::Context>(isolate_, context);
|
|
context->Enter();
|
|
}
|
|
|
|
JavascriptEnvironment::~JavascriptEnvironment() {
|
|
DCHECK_NE(platform_, nullptr);
|
|
platform_->DrainTasks(isolate_);
|
|
|
|
{
|
|
v8::HandleScope scope(isolate_);
|
|
context_.Get(isolate_)->Exit();
|
|
}
|
|
isolate_->Exit();
|
|
g_isolate = nullptr;
|
|
|
|
platform_->UnregisterIsolate(isolate_);
|
|
}
|
|
|
|
class EnabledStateObserverImpl final
|
|
: public base::trace_event::TraceLog::EnabledStateObserver {
|
|
public:
|
|
EnabledStateObserverImpl() {
|
|
base::trace_event::TraceLog::GetInstance()->AddEnabledStateObserver(this);
|
|
}
|
|
|
|
~EnabledStateObserverImpl() override {
|
|
base::trace_event::TraceLog::GetInstance()->RemoveEnabledStateObserver(
|
|
this);
|
|
}
|
|
|
|
// disable copy
|
|
EnabledStateObserverImpl(const EnabledStateObserverImpl&) = delete;
|
|
EnabledStateObserverImpl& operator=(const EnabledStateObserverImpl&) = delete;
|
|
|
|
void OnTraceLogEnabled() final {
|
|
base::AutoLock lock(mutex_);
|
|
for (auto* o : observers_) {
|
|
o->OnTraceEnabled();
|
|
}
|
|
}
|
|
|
|
void OnTraceLogDisabled() final {
|
|
base::AutoLock lock(mutex_);
|
|
for (auto* o : observers_) {
|
|
o->OnTraceDisabled();
|
|
}
|
|
}
|
|
|
|
void AddObserver(v8::TracingController::TraceStateObserver* observer) {
|
|
{
|
|
base::AutoLock lock(mutex_);
|
|
DCHECK(!observers_.count(observer));
|
|
observers_.insert(observer);
|
|
}
|
|
|
|
// Fire the observer if recording is already in progress.
|
|
if (base::trace_event::TraceLog::GetInstance()->IsEnabled())
|
|
observer->OnTraceEnabled();
|
|
}
|
|
|
|
void RemoveObserver(v8::TracingController::TraceStateObserver* observer) {
|
|
base::AutoLock lock(mutex_);
|
|
DCHECK_EQ(observers_.count(observer), 1lu);
|
|
observers_.erase(observer);
|
|
}
|
|
|
|
private:
|
|
base::Lock mutex_;
|
|
std::unordered_set<v8::TracingController::TraceStateObserver*> observers_;
|
|
};
|
|
|
|
base::LazyInstance<EnabledStateObserverImpl>::Leaky g_trace_state_dispatcher =
|
|
LAZY_INSTANCE_INITIALIZER;
|
|
|
|
class TracingControllerImpl : public node::tracing::TracingController {
|
|
public:
|
|
TracingControllerImpl() = default;
|
|
~TracingControllerImpl() override = default;
|
|
|
|
// disable copy
|
|
TracingControllerImpl(const TracingControllerImpl&) = delete;
|
|
TracingControllerImpl& operator=(const TracingControllerImpl&) = delete;
|
|
|
|
// TracingController implementation.
|
|
const uint8_t* GetCategoryGroupEnabled(const char* name) override {
|
|
return TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(name);
|
|
}
|
|
uint64_t AddTraceEvent(
|
|
char phase,
|
|
const uint8_t* category_enabled_flag,
|
|
const char* name,
|
|
const char* scope,
|
|
uint64_t id,
|
|
uint64_t bind_id,
|
|
int32_t num_args,
|
|
const char** arg_names,
|
|
const uint8_t* arg_types,
|
|
const uint64_t* arg_values,
|
|
std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertables,
|
|
unsigned int flags) override {
|
|
base::trace_event::TraceArguments args(
|
|
num_args, arg_names, arg_types,
|
|
reinterpret_cast<const unsigned long long*>( // NOLINT(runtime/int)
|
|
arg_values),
|
|
arg_convertables);
|
|
DCHECK_LE(num_args, 2);
|
|
base::trace_event::TraceEventHandle handle =
|
|
TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_BIND_ID(
|
|
phase, category_enabled_flag, name, scope, id, bind_id, &args,
|
|
flags);
|
|
uint64_t result;
|
|
memcpy(&result, &handle, sizeof(result));
|
|
return result;
|
|
}
|
|
uint64_t AddTraceEventWithTimestamp(
|
|
char phase,
|
|
const uint8_t* category_enabled_flag,
|
|
const char* name,
|
|
const char* scope,
|
|
uint64_t id,
|
|
uint64_t bind_id,
|
|
int32_t num_args,
|
|
const char** arg_names,
|
|
const uint8_t* arg_types,
|
|
const uint64_t* arg_values,
|
|
std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertables,
|
|
unsigned int flags,
|
|
int64_t timestampMicroseconds) override {
|
|
base::trace_event::TraceArguments args(
|
|
num_args, arg_names, arg_types,
|
|
reinterpret_cast<const unsigned long long*>( // NOLINT(runtime/int)
|
|
arg_values),
|
|
arg_convertables);
|
|
DCHECK_LE(num_args, 2);
|
|
base::TimeTicks timestamp =
|
|
base::TimeTicks() + base::Microseconds(timestampMicroseconds);
|
|
base::trace_event::TraceEventHandle handle =
|
|
TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_THREAD_ID_AND_TIMESTAMP(
|
|
phase, category_enabled_flag, name, scope, id, bind_id,
|
|
TRACE_EVENT_API_CURRENT_THREAD_ID, timestamp, &args, flags);
|
|
uint64_t result;
|
|
memcpy(&result, &handle, sizeof(result));
|
|
return result;
|
|
}
|
|
void UpdateTraceEventDuration(const uint8_t* category_enabled_flag,
|
|
const char* name,
|
|
uint64_t handle) override {
|
|
base::trace_event::TraceEventHandle traceEventHandle;
|
|
memcpy(&traceEventHandle, &handle, sizeof(handle));
|
|
TRACE_EVENT_API_UPDATE_TRACE_EVENT_DURATION(category_enabled_flag, name,
|
|
traceEventHandle);
|
|
}
|
|
void AddTraceStateObserver(TraceStateObserver* observer) override {
|
|
g_trace_state_dispatcher.Get().AddObserver(observer);
|
|
}
|
|
void RemoveTraceStateObserver(TraceStateObserver* observer) override {
|
|
g_trace_state_dispatcher.Get().RemoveObserver(observer);
|
|
}
|
|
};
|
|
|
|
v8::Isolate* JavascriptEnvironment::Initialize(uv_loop_t* event_loop,
|
|
bool setup_wasm_streaming) {
|
|
auto* cmd = base::CommandLine::ForCurrentProcess();
|
|
|
|
// --js-flags.
|
|
std::string js_flags =
|
|
cmd->GetSwitchValueASCII(blink::switches::kJavaScriptFlags);
|
|
js_flags.append(" --no-freeze-flags-after-init");
|
|
if (!js_flags.empty())
|
|
v8::V8::SetFlagsFromString(js_flags.c_str(), js_flags.size());
|
|
|
|
// The V8Platform of gin relies on Chromium's task schedule, which has not
|
|
// been started at this point, so we have to rely on Node's V8Platform.
|
|
auto* tracing_agent = node::CreateAgent();
|
|
auto* tracing_controller = new TracingControllerImpl();
|
|
node::tracing::TraceEventHelper::SetAgent(tracing_agent);
|
|
platform_ = node::MultiIsolatePlatform::Create(
|
|
base::RecommendedMaxNumberOfThreadsInThreadGroup(3, 8, 0.1, 0),
|
|
tracing_controller, gin::V8Platform::PageAllocator());
|
|
|
|
v8::V8::InitializePlatform(platform_.get());
|
|
gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode,
|
|
gin::ArrayBufferAllocator::SharedInstance(),
|
|
nullptr /* external_reference_table */,
|
|
js_flags, nullptr /* fatal_error_callback */,
|
|
nullptr /* oom_error_callback */,
|
|
false /* create_v8_platform */);
|
|
|
|
v8::Isolate* isolate = v8::Isolate::Allocate();
|
|
platform_->RegisterIsolate(isolate, event_loop);
|
|
|
|
// This is done here because V8 checks for the callback in NewContext.
|
|
// Our setup order doesn't allow for calling SetupIsolateForNode
|
|
// before NewContext without polluting JavaScriptEnvironment with
|
|
// Node.js logic and so we conditionally do it here to keep
|
|
// concerns separate.
|
|
if (setup_wasm_streaming) {
|
|
isolate->SetWasmStreamingCallback(
|
|
node::wasm_web_api::StartStreamingCompilation);
|
|
}
|
|
|
|
g_isolate = isolate;
|
|
|
|
return isolate;
|
|
}
|
|
|
|
// static
|
|
v8::Isolate* JavascriptEnvironment::GetIsolate() {
|
|
CHECK(g_isolate);
|
|
return g_isolate;
|
|
}
|
|
|
|
void JavascriptEnvironment::CreateMicrotasksRunner() {
|
|
DCHECK(!microtasks_runner_);
|
|
microtasks_runner_ = std::make_unique<MicrotasksRunner>(isolate());
|
|
base::CurrentThread::Get()->AddTaskObserver(microtasks_runner_.get());
|
|
}
|
|
|
|
void JavascriptEnvironment::DestroyMicrotasksRunner() {
|
|
DCHECK(microtasks_runner_);
|
|
{
|
|
v8::HandleScope scope(isolate_);
|
|
gin_helper::CleanedUpAtExit::DoCleanup();
|
|
}
|
|
base::CurrentThread::Get()->RemoveTaskObserver(microtasks_runner_.get());
|
|
}
|
|
|
|
NodeEnvironment::NodeEnvironment(node::Environment* env) : env_(env) {}
|
|
|
|
NodeEnvironment::~NodeEnvironment() {
|
|
auto* isolate_data = env_->isolate_data();
|
|
node::FreeEnvironment(env_);
|
|
node::FreeIsolateData(isolate_data);
|
|
}
|
|
|
|
} // namespace electron
|