3b3f2112d5* fix: remove use of deprecated v8::String::Value Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month, so let's stop using it. The replacement code mostly does the same as v8::String::Value(); but since our test only cares about the length and not the contents, we get a small perf win of not needing to allocate a char array and not needing to call Local::String::Write(). Upstream V8_DEPRECATE_SOON: Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk v8::String::Value() implementation: https://chromium.googlesource.com/v8/v8/+/20226b740bfa1a1e46dff80363232dfd3da50de8/src/api/api.cc#10883 History on why we used it: https://github.com/electron/electron/pull/19792/commits/80c1a9739d191d2e393e56e2b254fb72bf6859e9 https://github.com/electron/electron/pull/19792/commits/f49ed30f7205d7295ab035c6f1b3702cf7e3217c Co-authored-by: Charles Kerr <charles@charleskerr.com> * Update shell/common/gin_converters/file_path_converter.h Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! Update shell/common/gin_converters/file_path_converter.h do not return success for all non-Null non-Strings Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> |
||
|---|---|---|
| .. | ||
| app | ||
| browser | ||
| common | ||
| renderer | ||
| services/node | ||
| utility | ||