b5ed025267
* build: use github actions for windows (#44136)
* build: test windows runner
* build: try build windows on windows?
* build: take win/cross changes
* build: use bash as default shell always
* build: configure git for windows build tools
* build: bash as default
* build: configure windows correctly
* build: use sha1sum
* build: force windows cipd init and python3 existence
* just pain
* build: restore cache on windows
* build: use build-tools gclient
* build: sync gclient vars to build windows job
* build: output depshash for debugging
* build: past sam was a silly goose
* build: depshash logging
* build: force lf endings for lock and DEPS
* build: platform strings are hard
* build: checkout on windows host
* sup
* no check
* idk
* sigh
* ...
* no double checkout
* build: yolo some stuff
* build: run gn-check for windows on linux hosts for speed
* use container...
* cry ?
* build: e d
* e d
* no log
* fix toolchain on windows cross check
* build: use powershell to add mksnapshot_args
* build: enable x86 and arm64 windows builds too
* clean up
* maybe not needed
* build: keep action around for post step
* build: configure git global on win
* build: ia32 zip manifest
* build: no patch depot_tools for tests
* build: get arm64 windows closer to working
* build: windows tar is ass
* 32 bit on 32 bit
* maybe bash
* build: set up nodejs
* correct windows sharding
* fix some spec runner stuff
* fix windows tests
* overwrite -Force
* sigh
* screen res
* wat
* logs
* ... more logs
* line endings will be the death of me
* remove 1080p force thing
* vsctools + logging
* disable some fullscreen tests on GHA
* no progress
* run all CI
* install visual studio on arm64
* windows hax for non windows
* maybe arm sdk
* clean up depshash logic
* build: use single check per platform
* ensure clean args
* fix loop
* remove debug
* update default build image sha for dispatch
* plzzzz
* one more try
* arm64 vctools
* sad
* build: fix non-dispatch windows gn check
* chore: debug datadog-ci location
* chore: update build-tools for newer toolchain
* chore: set path for datadog-ci
* try this
* chore: fixup gn check
* fixup gn-check some more
* fixup windows gn check
* chore: fixup windows gn check
* test: use cmd for Windows testing
* fixup use cmd for testing on Windows
* fixup windows GN check
* fixup npm config arch for x86
* Can we set test files via powershell
* fixup to set test files via powershell
* fixup set test files via powershell
* Don't check cross instance cache disk space on Windows
* Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing (AGAIN)
* use powershell if in powershell
* fixup use powershell if in powershell
* chore: remove no longer needed changes to depot_tools
xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094
and https://chromium-review.googlesource.com/c/chromium/src/+/5844046
* chore: try using 7zip on Windows to extract tarball
* Revert "chore: try using 7zip on Windows to extract tarball"
This reverts commit c7432b6a37857fd0746b8f1776fbd1103dba0b85.
* test: debug failing tests on GHA windows
* fix: ftbfs when including simdjson in Node.js
(cherry picked from commit 48e44c40d61b7aa843a990d4e0c8dec676b4ce8f)
* chore: try to track down Windows testing hang
* use correct timeout
* try this
* see if this helps
* try to figure out why node is running
* shard tests to try to narrow down WOA lockup
* try to narrow down problem test
* Narrow down blocking test more
* do we need a combo to repro
* see if this cleans up the tests
* fixup navigator.usb test
* remove logging from problematic tests
* Revert "shard tests to try to narrow down WOA lockup"
This reverts commit a1806583769678491814cb8b008131c32be4e8fb.
* remove logging
* debug keyboard test
* add timeout for Windows since arm64 sometimes hangs
* see if this helps
* put back original timeout
* try to use screenCapture to get screenshots of what is going on on WOA
* try using electron screencapture to debug WOA hang
* chore: turn off privacy experience
* run screenshot on both shards
* fixup screencap
* try to narrow down hanging spec
* chore: cleanup servers left open
* cleanup tests
* Revert "try to narrow down hanging spec"
This reverts commit a0f959f5382f4012a9919ac535d42c5333eb7d5f.
* cleanup test debugging
* fixup extensions spec
* cleanup unneeded items
* run wtf with 2 shards instead of 6
* Revert "run wtf with 2 shards instead of 6"
This reverts commit ca2d282129ee42c535d80f9876d6fa0dc6c08344.
* debug windows version on woa
* dump more info
* Get detailed CPU info
* revert debugging
* use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* try to track down which tests trigger hang
* one or more of these combinations should hang
* break up web contents spec to find hang
* further break down api-web-contents to find hang
* test: ensure all webContents are closed
* test: fix require is not defined error
* see if api-web-contents spec is now good
* test: ensure all webContents are closed
* Revert "try to track down which tests trigger hang"
This reverts commit 07298d6ffeb4873ef7615a8ec3d1a6696e354ff4.
* chore: use alternate location for windows toolchain
* Reapply "try to track down which tests trigger hang"
This reverts commit 0321f76d01069ef325339b6fe6ed39700eae2b6b.
* try to narrow down problem test
* fix TEST_SHARD env var
* no, really fix TEST_SHARD env var
* see if this fixes it
* test: cleanup any remaining windows and webcontents
* see if new cleanup helps
* dont destroy webcontents for now
* fixup dont destroy webcontents for now
* Only cleanup right before process.exit
* see if this fixes the hang
* actually destroy webcontents
* Revert "Reapply "try to track down which tests trigger hang""
This reverts commit cdee7de049ce6bb5f67bbcc64882c56aa2c73027.
* see if this helps
* Revert "see if this helps"
This reverts commit 9a15a69cf7dbc456db7a61efa5b6870535bae993.
* Is it all about the web contents?
* it is all about the webcontents
but which one?
* Narrow down problem webcontents test
* try to speed up git install on WOA
* disable problematic test on WOA
* remove debugging
* remove debugging from choco installs
* Revert "disable problematic test on WOA"
This reverts commit e060fb0839b73d53cfde1f8acdca634f8e267937.
* Revert "remove debugging"
This reverts commit f18dd8b1a555f56bb06d0ea996a6eff31b424bf1.
* run against all the tests in the failing shard
* don't run visibility tests first
* remove debugging
* 3 is a magic number
* Revert "3 is a magic number"
This reverts commit 36b91ccf9f03a4b34230cd69ceca482f7d8428c1.
* match what Appveyor runs exactly
* Revert "match what Appveyor runs exactly"
This reverts commit 7260dd432216c62696e4bc864930f17c857eabbe.
* chore: sort files alphabetically
* find out what spec is leaving stuff open
* chore: Checkout PR HEAD commit
instead of merge commit
* try using app.exit instead of process.exit
* test: cleanup BrowserWindows and webContents
* Revert "chore: sort files alphabetically"
This reverts commit d9e217ffb1522076e150fce9e43a31bf56716acb.
* chore: use win32 to match process.platform
Needed for build-tools to download from PRs
* chore: cache yarn dir
* fixup cache yarn
* fixup use win32 to match process.platform
* fixup use win32 to match process.platform
* fixup cache yarn
* Add debugging for WOA hang
* Add debugging for failing keyboard lock test
* Revert "Add debugging for WOA hang"
This reverts commit 8df03d568d15a269e4026140d1158e8cdf551dec.
* try using process.kill
* add more debugging to keyboard.lock test
* Revert "Add debugging for failing keyboard lock test"
* remove debugging
* test: disable keyboard.lock on Windows
* test: disable fullscreen tests on Windows
* test: only force test suite exit on WOA
* fixup test: only force test suite exit on WOA
* cleanup tests
* extract yarn caching/install to action
* try using bash to run windows tests
* remove left over debugging
* standardize on 'win' for Windows builds
* use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
* fixup use 'x86' for arch for manifest files
* standardize on 'win' for Windows builds
* fixup use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit be1a3dce83
)
* chore: update build tools to correct sha
---------
Co-authored-by: Samuel Attard <sam@electronjs.org>
270 lines
10 KiB
TypeScript
270 lines
10 KiB
TypeScript
import { BrowserWindow, ipcMain, WebContents } from 'electron/main';
|
|
|
|
import { expect } from 'chai';
|
|
|
|
import { once } from 'node:events';
|
|
import * as path from 'node:path';
|
|
|
|
import { defer } from './lib/spec-helpers';
|
|
|
|
describe('webFrame module', () => {
|
|
const fixtures = path.resolve(__dirname, 'fixtures');
|
|
|
|
it('can use executeJavaScript', async () => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: true,
|
|
preload: path.join(fixtures, 'pages', 'world-safe-preload.js')
|
|
}
|
|
});
|
|
defer(() => w.close());
|
|
const isSafe = once(ipcMain, 'executejs-safe');
|
|
w.loadURL('about:blank');
|
|
const [, wasSafe] = await isSafe;
|
|
expect(wasSafe).to.equal(true);
|
|
});
|
|
|
|
it('can use executeJavaScript and catch conversion errors', async () => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: true,
|
|
preload: path.join(fixtures, 'pages', 'world-safe-preload-error.js')
|
|
}
|
|
});
|
|
defer(() => w.close());
|
|
const execError = once(ipcMain, 'executejs-safe');
|
|
w.loadURL('about:blank');
|
|
const [, error] = await execError;
|
|
expect(error).to.not.equal(null, 'Error should not be null');
|
|
expect(error).to.have.property('message', 'Uncaught Error: An object could not be cloned.');
|
|
});
|
|
|
|
it('calls a spellcheck provider', async () => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: false
|
|
}
|
|
});
|
|
defer(() => w.close());
|
|
await w.loadFile(path.join(fixtures, 'pages', 'webframe-spell-check.html'));
|
|
w.focus();
|
|
await w.webContents.executeJavaScript('document.querySelector("input").focus()', true);
|
|
|
|
const spellCheckerFeedback =
|
|
new Promise<[string[], boolean]>(resolve => {
|
|
ipcMain.on('spec-spell-check', (e, words, callbackDefined) => {
|
|
if (words.length === 5) {
|
|
// The API calls the provider after every completed word.
|
|
// The promise is resolved only after this event is received with all words.
|
|
resolve([words, callbackDefined]);
|
|
}
|
|
});
|
|
});
|
|
const inputText = 'spleling test you\'re ';
|
|
for (const keyCode of inputText) {
|
|
w.webContents.sendInputEvent({ type: 'char', keyCode });
|
|
}
|
|
const [words, callbackDefined] = await spellCheckerFeedback;
|
|
expect(words.sort()).to.deep.equal(['spleling', 'test', 'you\'re', 'you', 're'].sort());
|
|
expect(callbackDefined).to.be.true();
|
|
});
|
|
|
|
describe('api', () => {
|
|
let w: WebContents;
|
|
let win: BrowserWindow;
|
|
before(async () => {
|
|
win = new BrowserWindow({ show: false, webPreferences: { contextIsolation: false, nodeIntegration: true } });
|
|
await win.loadURL('data:text/html,<iframe name="test"></iframe>');
|
|
w = win.webContents;
|
|
await w.executeJavaScript(`
|
|
var { webFrame } = require('electron');
|
|
var isSameWebFrame = (a, b) => a.context === b.context;
|
|
childFrame = webFrame.firstChild;
|
|
null
|
|
`);
|
|
});
|
|
|
|
after(() => {
|
|
win.close();
|
|
win = null as unknown as BrowserWindow;
|
|
});
|
|
|
|
describe('top', () => {
|
|
it('is self for top frame', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(webFrame.top, webFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
|
|
it('is self for child frame', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(childFrame.top, webFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('opener', () => {
|
|
it('is null for top frame', async () => {
|
|
const equal = await w.executeJavaScript('webFrame.opener === null');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('parent', () => {
|
|
it('is null for top frame', async () => {
|
|
const equal = await w.executeJavaScript('webFrame.parent === null');
|
|
expect(equal).to.be.true();
|
|
});
|
|
|
|
it('is top frame for child frame', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(childFrame.parent, webFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('firstChild', () => {
|
|
it('is child frame for top frame', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(webFrame.firstChild, childFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
|
|
it('is null for child frame', async () => {
|
|
const equal = await w.executeJavaScript('childFrame.firstChild === null');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('getFrameForSelector()', () => {
|
|
it('does not crash when not found', async () => {
|
|
const equal = await w.executeJavaScript('webFrame.getFrameForSelector("unexist-selector") === null');
|
|
expect(equal).to.be.true();
|
|
});
|
|
|
|
it('returns the webFrame when found', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(webFrame.getFrameForSelector("iframe"), childFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('findFrameByName()', () => {
|
|
it('does not crash when not found', async () => {
|
|
const equal = await w.executeJavaScript('webFrame.findFrameByName("unexist-name") === null');
|
|
expect(equal).to.be.true();
|
|
});
|
|
|
|
it('returns the webFrame when found', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(webFrame.findFrameByName("test"), childFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('findFrameByRoutingId()', () => {
|
|
it('does not crash when not found', async () => {
|
|
const equal = await w.executeJavaScript('webFrame.findFrameByRoutingId(-1) === null');
|
|
expect(equal).to.be.true();
|
|
});
|
|
|
|
it('returns the webFrame when found', async () => {
|
|
const equal = await w.executeJavaScript('isSameWebFrame(webFrame.findFrameByRoutingId(childFrame.routingId), childFrame)');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('setZoomFactor()', () => {
|
|
it('works', async () => {
|
|
const equal = await w.executeJavaScript('childFrame.setZoomFactor(2.0); childFrame.getZoomFactor() === 2.0');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('setZoomLevel()', () => {
|
|
it('works', async () => {
|
|
const equal = await w.executeJavaScript('childFrame.setZoomLevel(5); childFrame.getZoomLevel() === 5');
|
|
expect(equal).to.be.true();
|
|
});
|
|
});
|
|
|
|
describe('getResourceUsage()', () => {
|
|
it('works', async () => {
|
|
const result = await w.executeJavaScript('childFrame.getResourceUsage()');
|
|
expect(result).to.have.property('images').that.is.an('object');
|
|
expect(result).to.have.property('scripts').that.is.an('object');
|
|
expect(result).to.have.property('cssStyleSheets').that.is.an('object');
|
|
expect(result).to.have.property('xslStyleSheets').that.is.an('object');
|
|
expect(result).to.have.property('fonts').that.is.an('object');
|
|
expect(result).to.have.property('other').that.is.an('object');
|
|
});
|
|
});
|
|
|
|
describe('executeJavaScript', () => {
|
|
it('executeJavaScript() yields results via a promise and a sync callback', async () => {
|
|
const { callbackResult, callbackError, result } = await w.executeJavaScript(`new Promise(resolve => {
|
|
let callbackResult, callbackError;
|
|
childFrame
|
|
.executeJavaScript('1 + 1', (result, error) => {
|
|
callbackResult = result;
|
|
callbackError = error;
|
|
}).then(result => resolve({callbackResult, callbackError, result}))
|
|
})`);
|
|
|
|
expect(callbackResult).to.equal(2);
|
|
expect(callbackError).to.be.undefined();
|
|
expect(result).to.equal(2);
|
|
});
|
|
|
|
it('executeJavaScriptInIsolatedWorld() yields results via a promise and a sync callback', async () => {
|
|
const { callbackResult, callbackError, result } = await w.executeJavaScript(`new Promise(resolve => {
|
|
let callbackResult, callbackError;
|
|
childFrame
|
|
.executeJavaScriptInIsolatedWorld(999, [{code: '1 + 1'}], (result, error) => {
|
|
callbackResult = result;
|
|
callbackError = error;
|
|
}).then(result => resolve({callbackResult, callbackError, result}))
|
|
})`);
|
|
|
|
expect(callbackResult).to.equal(2);
|
|
expect(callbackError).to.be.undefined();
|
|
expect(result).to.equal(2);
|
|
});
|
|
|
|
it('executeJavaScript() yields errors via a promise and a sync callback', async () => {
|
|
const { callbackResult, callbackError, error } = await w.executeJavaScript(`new Promise(resolve => {
|
|
let callbackResult, callbackError;
|
|
childFrame
|
|
.executeJavaScript('thisShouldProduceAnError()', (result, error) => {
|
|
callbackResult = result;
|
|
callbackError = error;
|
|
}).then(result => {throw new Error}, error => resolve({callbackResult, callbackError, error}))
|
|
})`);
|
|
|
|
expect(callbackResult).to.be.undefined();
|
|
expect(callbackError).to.be.an('error');
|
|
expect(error).to.be.an('error');
|
|
});
|
|
|
|
it('executeJavaScriptInIsolatedWorld() yields errors via a promise and a sync callback', async () => {
|
|
const { callbackResult, callbackError, error } = await w.executeJavaScript(`new Promise(resolve => {
|
|
let callbackResult, callbackError;
|
|
childFrame
|
|
.executeJavaScriptInIsolatedWorld(999, [{code: 'thisShouldProduceAnError()'}], (result, error) => {
|
|
callbackResult = result;
|
|
callbackError = error;
|
|
}).then(result => {throw new Error}, error => resolve({callbackResult, callbackError, error}))
|
|
})`);
|
|
|
|
expect(callbackResult).to.be.undefined();
|
|
expect(callbackError).to.be.an('error');
|
|
expect(error).to.be.an('error');
|
|
});
|
|
|
|
it('executeJavaScript(InIsolatedWorld) can be used without a callback', async () => {
|
|
expect(await w.executeJavaScript('webFrame.executeJavaScript(\'1 + 1\')')).to.equal(2);
|
|
expect(await w.executeJavaScript('webFrame.executeJavaScriptInIsolatedWorld(999, [{code: \'1 + 1\'}])')).to.equal(2);
|
|
});
|
|
});
|
|
});
|
|
});
|