bc527f6b51
* refactor: bundle the browser and renderer process electron code * Bundles browser/init and renderer/init * Improves load performance of main process by ~40% * Improves load performance of renderer process by ~30% * Prevents users from importing our "requiring" our internal logic such as ipc-main-internal. This makes those message buses safer as they are less accessible, there is still some more work to be done though to lock down those buses completely. * The electron.asar file now only contains 2 files, as a future improvement maybe we can use atom_natives to ship these two files embedded in the binary * This also removes our dependency on browserify which had some strange edge cases that caused us to have to hack around require-order and stopped us using certain ES6/7 features we should have been able to use (async / await in some files in the sandboxed renderer init script) TLDR: Things are faster and better :) * fix: I really do not want to talk about it * chore: add performance improvements from debugging * fix: resolve the provided path so webpack thinks it is absolute * chore: fixup per PR review * fix: use webpacks ProvidePlugin to keep global, process and Buffer alive after deletion from global scope for use in internal code * fix: bundle worker/init as well to make node-in-workers work * chore: update wording as per feedback * chore: make the timers hack work when yarn is not used
23 lines
966 B
JavaScript
23 lines
966 B
JavaScript
const chai = require('chai')
|
|
const { expect } = chai
|
|
|
|
describe('feature-string parsing', () => {
|
|
it('is indifferent to whitespace around keys and values', () => {
|
|
const parseFeaturesString = require('../lib/common/parse-features-string')
|
|
const checkParse = (string, parsed) => {
|
|
const features = {}
|
|
parseFeaturesString(string, (k, v) => { features[k] = v })
|
|
expect(features).to.deep.equal(parsed)
|
|
}
|
|
checkParse('a=yes,c=d', { a: true, c: 'd' })
|
|
checkParse('a=yes ,c=d', { a: true, c: 'd' })
|
|
checkParse('a=yes, c=d', { a: true, c: 'd' })
|
|
checkParse('a=yes , c=d', { a: true, c: 'd' })
|
|
checkParse(' a=yes , c=d', { a: true, c: 'd' })
|
|
checkParse(' a= yes , c=d', { a: true, c: 'd' })
|
|
checkParse(' a = yes , c=d', { a: true, c: 'd' })
|
|
checkParse(' a = yes , c =d', { a: true, c: 'd' })
|
|
checkParse(' a = yes , c = d', { a: true, c: 'd' })
|
|
checkParse(' a = yes , c = d ', { a: true, c: 'd' })
|
|
})
|
|
})
|