electron/shell/common/electron_command_line.cc
Charles Kerr dffe00b232
fix: -Wunsafe-buffer-usage warnings with argc, argv (#44366)
* refactor: move uv_setup_args() calls to startup

* refactor: call base::CommandLine::Init() before ContentMain()

* feat: add ElectronCommandLine::AsUtf8()

* refactor: call base::CommandLine::Init() before NodeMain()

* refactor: use ElectronCommandLine::AsUtf8() in NodeMain()

* fix: -Wunsafe-buffer-usage warning in ElectronCommandLine::Init()

* chore: add a DCHECK to confirm ElectronCommandLine was initialized before AsUtf8() is called

* chore: const correctness in ElectronCommandLine::Init() args

* chore: add ElectronCommandLine to macOS Electron Helper app

* chore: move argc, argvc setup into electron_library_main on macOS

* chore: revert BUILD.gn changes

* fix: WideToUTF8() call in ElectronCommandLine::AsUtf8()

* build: add uv to the include paths for app/electron_main_linux

* build: add uv to the include paths for app/electron_library_main.mm

* chore: revert unrelated changes

these were intended for another branch
2024-10-29 13:23:08 +01:00

45 lines
1.2 KiB
C++

// Copyright (c) 2013 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "shell/common/electron_command_line.h"
#include "base/command_line.h"
#include "base/containers/to_vector.h"
#include "base/strings/utf_string_conversions.h"
namespace electron {
// static
base::CommandLine::StringVector ElectronCommandLine::argv_;
// static
void ElectronCommandLine::Init(int argc,
base::CommandLine::CharType const* const* argv) {
DCHECK(argv_.empty());
// Safety: as is normal in command lines, argc and argv must correspond
// to one another. Otherwise there will be out-of-bounds accesses.
argv_.assign(argv, UNSAFE_BUFFERS(argv + argc));
}
// static
std::vector<std::string> ElectronCommandLine::AsUtf8() {
DCHECK(!argv_.empty());
#if BUILDFLAG(IS_WIN)
return base::ToVector(
argv_, [](const auto& wstr) { return base::WideToUTF8(wstr); });
#else
return argv_;
#endif
}
#if BUILDFLAG(IS_LINUX)
// static
void ElectronCommandLine::InitializeFromCommandLine() {
argv_ = base::CommandLine::ForCurrentProcess()->argv();
}
#endif
} // namespace electron