![electron-roller[bot]](/assets/img/avatar_default.png) 89117fdd99
			
		
	
	
	
	
	89117fdd99* chore: bump chromium in DEPS to 118.0.5951.0 * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4727894 No logic changes, but patch needed to be manually re-applied due to upstream code shear * chore: update port_autofill_colors_to_the_color_pipeline.patch No manual changes; patch applied with fuzz * chore: update patches * chore: bump chromium in DEPS to 118.0.5953.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5955.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5957.0 * chore: update patches * chore: include path of native_web_keyboard_event.h Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689 * chore: remove reference to eextensions/browser/notification-types.h Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4771627 * chore: update references to renamed upstream field NativeWebKeyboardEvent.skip_if_unhandled (formerly known as skip_in_browser Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4758689 Need a second pair of eyes on this commit. In particular the reference in content_converter.cc, skipInBrowser, seems to not be set or documented anywhere? Is this unused/vestigal code? * chore: sync signature of ElectronExtensionsBrowserClient::IsValidContext() to upstream change Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4784198 * chore: add auto_pip_setting_helper.[cc,h] to chromium_src build Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4688277 Exiting upstream code used by chromium_src now depends on this new upstream class * chore: bump chromium in DEPS to 118.0.5959.0 * chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch Xref: add_maximized_parameter_to_linuxui_getwindowframeprovider.patch manually adjust patch to minor upstream chagnes * chore: update patches * chore: bump chromium in DEPS to 118.0.5961.0 * chore: bump chromium in DEPS to 118.0.5963.0 * chore: update patches * 4780994: Rename various base files to "apple" since iOS uses them too https://chromium-review.googlesource.com/c/chromium/src/+/4780994 * Many files moved from `mac` -> `apple` This commit follows a handful of CLs that simply rename files/symbols to change `mac` to `apple` to signify their use across both macOS and iOS: - 4784010: Move scoped_nsautorelease_pool to base/apple, leave a forwarding header - 4790744: Move foundation_util to base/apple, leave a forwarding header - 4790741: Move scoped_cftypreref to base/apple, leave a forwarding header - 4787627: Move and rename macOS+iOS base/ files in PA to "apple" - 4780399: Move OSStatus logging to base/apple - 4787387: Remove forwarding headers - 4781113: Rename message_pump_mac to "apple" because iOS uses it too * fixup minor patch update error A function param got dropped from this patch somewhere earlier * chore: bump chromium in DEPS to 118.0.5965.2 * chore: update patches * 4799213: Move ScopedTypeRef and ScopedCFTypeRef into base:🍎: https://chromium-review.googlesource.com/c/chromium/src/+/4799213 * Fix removed include to BrowserContext In crrev.com/c/4767962 an include to BrowserContext was removed, which was necessary for compilation. This broke only for us because "chrome/browser/profiles/profile.h" includes that class, but we remove all references to profiles. * chore: bump chromium in DEPS to 118.0.5967.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5969.0 * chore: update patches * chore: bump chromium in DEPS to 118.0.5971.0 * chore: bump chromium in DEPS to 118.0.5973.0 * chore: update patches * 4772121: [OOPIF PDF] Replace PDFWebContentsHelper with PDFDocumentHelper https://chromium-review.googlesource.com/c/chromium/src/+/4772121 * 4811164: [Extensions] Do some cleanup in ChromeManagementAPIDelegate. https://chromium-review.googlesource.com/c/chromium/src/+/4811164 * 4809488: Remove duplicate dnd functionality between Web and Renderer prefs https://chromium-review.googlesource.com/c/chromium/src/+/4809488 Given that this is no longer an option of web preferences, we should consider deprecating this option and then removing it. * chore: bump chromium in DEPS to 118.0.5975.0 * chore: update patches * fixup! chore: add auto_pip_settings_helper.{cc|h} to chromium_src build * Reland "[windows] Remove RegKey::DeleteEmptyKey" Refs https://chromium-review.googlesource.com/c/chromium/src/+/4813255 * Ensure StrCat means StrCat Refs https://chromium-review.googlesource.com/c/chromium/src/+/1117180 * fixup! Remove RegKey::DeleteEmptyKey * Consistently reject large p and large q in DH Refs https://boringssl-review.googlesource.com/c/boringssl/+/62226 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com>
		
			
				
	
	
		
			146 lines
		
	
	
	
		
			5.3 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			146 lines
		
	
	
	
		
			5.3 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 | |
| From: Cheng Zhao <zcbenz@gmail.com>
 | |
| Date: Thu, 20 Sep 2018 17:48:49 -0700
 | |
| Subject: mas: disable private window-frame APIs
 | |
| 
 | |
| Disable private window frame APIs (NSNextStepFrame and NSThemeFrame) for MAS
 | |
| build.
 | |
| 
 | |
| diff --git a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | |
| index 9db1a07aabdbc5ebcf5d971664a8783a3d4810a3..eed51d0af307a0bb1c6cbbcbe2dbd3c906d0999c 100644
 | |
| --- a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | |
| +++ b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | |
| @@ -10,6 +10,7 @@
 | |
|  #include "components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h"
 | |
|  #include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
|  @interface NSWindow (PrivateBrowserNativeWidgetAPI)
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
 | |
|  @end
 | |
| @@ -70,10 +71,13 @@ - (BOOL)_shouldCenterTrafficLights {
 | |
|  
 | |
|  @end
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @implementation BrowserNativeWidgetWindow
 | |
|  
 | |
|  // NSWindow (PrivateAPI) overrides.
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | |
|    // - NSThemeFrame and its subclasses will be nil if it's missing at runtime.
 | |
|    if ([BrowserWindowFrame class])
 | |
| @@ -120,6 +124,8 @@ - (BOOL)_usesCustomDrawing {
 | |
|    return NO;
 | |
|  }
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  // Handle "Move focus to the window toolbar" configured in System Preferences ->
 | |
|  // Keyboard -> Shortcuts -> Keyboard. Usually Ctrl+F5. The argument (|unknown|)
 | |
|  // tends to just be nil.
 | |
| diff --git a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | |
| index 3a815ebf505bd95fa7f6b61ba433d98fbfe20225..dbbebbdc1735bc14224dfcde0b7fe3a6fd9f9e40 100644
 | |
| --- a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | |
| +++ b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | |
| @@ -4,6 +4,8 @@
 | |
|  
 | |
|  #import "components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.h"
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
| +
 | |
|  @interface NSWindow (PrivateAPI)
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
 | |
|  @end
 | |
| @@ -18,8 +20,12 @@ - (CGFloat)_titlebarHeight {
 | |
|  }
 | |
|  @end
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @implementation NativeWidgetMacFramelessNSWindow
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
| +
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | |
|    if ([NativeWidgetMacFramelessNSWindowFrame class]) {
 | |
|      return [NativeWidgetMacFramelessNSWindowFrame class];
 | |
| @@ -27,4 +33,6 @@ + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | |
|    return [super frameViewClassForStyleMask:windowStyle];
 | |
|  }
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @end
 | |
| diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | |
| index 94ac4fa8db42cb70fa5032a0c1eeb10ad94b8d9a..048cfe7b16d74845492c9317f1ed9790fed36250 100644
 | |
| --- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | |
| +++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | |
| @@ -17,6 +17,7 @@ class NativeWidgetNSWindowBridge;
 | |
|  
 | |
|  @protocol WindowTouchBarDelegate;
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
|  // Weak lets Chrome launch even if a future macOS doesn't have the below classes
 | |
|  WEAK_IMPORT_ATTRIBUTE
 | |
|  @interface NSNextStepFrame : NSView
 | |
| @@ -33,6 +34,7 @@ REMOTE_COCOA_APP_SHIM_EXPORT
 | |
|  REMOTE_COCOA_APP_SHIM_EXPORT
 | |
|  @interface NativeWidgetMacNSWindowTitledFrame : NSThemeFrame
 | |
|  @end
 | |
| +#endif
 | |
|  
 | |
|  // The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that
 | |
|  // can only be accomplished by overriding methods.
 | |
| diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | |
| index d52272fd1de2a7cd54841aec05d30fdae112c1ee..cc17da89fb9972f57f0686029b6e7a0f95354409 100644
 | |
| --- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | |
| +++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | |
| @@ -113,7 +113,9 @@ void OrderChildWindow(NSWindow* child_window,
 | |
|  }  // namespace
 | |
|  
 | |
|  @interface NSWindow (Private)
 | |
| +#if !IS_MAS_BUILD()
 | |
|  + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle;
 | |
| +#endif
 | |
|  - (BOOL)hasKeyAppearance;
 | |
|  - (long long)_resizeDirectionForMouseLocation:(CGPoint)location;
 | |
|  - (BOOL)_isConsideredOpenForPersistentState;
 | |
| @@ -161,6 +163,8 @@ - (void)cr_mouseDownOnFrameView:(NSEvent*)event {
 | |
|  }
 | |
|  @end
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
| +
 | |
|  @implementation NativeWidgetMacNSWindowTitledFrame
 | |
|  - (void)mouseDown:(NSEvent*)event {
 | |
|    if (self.window.isMovable)
 | |
| @@ -187,6 +191,8 @@ - (BOOL)usesCustomDrawing {
 | |
|  }
 | |
|  @end
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @implementation NativeWidgetMacNSWindow {
 | |
|   @private
 | |
|    CommandDispatcher* __strong _commandDispatcher;
 | |
| @@ -396,6 +402,8 @@ - (NSAccessibilityRole)accessibilityRole {
 | |
|  
 | |
|  // NSWindow overrides.
 | |
|  
 | |
| +#if !IS_MAS_BUILD()
 | |
| +
 | |
|  + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
 | |
|    if (windowStyle & NSWindowStyleMaskTitled) {
 | |
|      if (Class customFrame = [NativeWidgetMacNSWindowTitledFrame class])
 | |
| @@ -407,6 +415,8 @@ + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
 | |
|    return [super frameViewClassForStyleMask:windowStyle];
 | |
|  }
 | |
|  
 | |
| +#endif
 | |
| +
 | |
|  - (BOOL)_isTitleHidden {
 | |
|    bool shouldShowWindowTitle = YES;
 | |
|    if (_bridge)
 |