ab66c4b7f9
Adds a patch that reverts https://chromium-review.googlesource.com/c/v8/v8/+/1526195 in order to let native modules build. nan has a strong dependency on the IsNearDeath method. This needs to be solved upstream in nan or V8.
28 lines
801 B
Diff
28 lines
801 B
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Ales Pergl <alpergl@microsoft.com>
|
|
Date: Mon, 22 Oct 2018 10:47:12 -0700
|
|
Subject: build_gn.patch
|
|
|
|
|
|
diff --git a/BUILD.gn b/BUILD.gn
|
|
index b843e32765a93fe50ccc78427558daeb3447c2a8..1eefb5b89c8a91ee3a9eb9f4a5b22cc499d97539 100644
|
|
--- a/BUILD.gn
|
|
+++ b/BUILD.gn
|
|
@@ -246,7 +246,7 @@ config("internal_config") {
|
|
":v8_header_features",
|
|
]
|
|
|
|
- if (is_component_build) {
|
|
+ if (is_component_build || is_electron_build) {
|
|
defines += [ "BUILDING_V8_SHARED" ]
|
|
}
|
|
}
|
|
@@ -3558,6 +3558,8 @@ if (v8_use_snapshot && current_toolchain == v8_snapshot_toolchain) {
|
|
|
|
configs = [ ":internal_config" ]
|
|
|
|
+ configs += [ "//electron/build/config:build_time_executable" ]
|
|
+
|
|
deps = [
|
|
":v8_base",
|
|
":v8_init",
|