56 lines
2 KiB
Diff
56 lines
2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Nitish Sakhawalkar <nitsakh@icloud.com>
|
|
Date: Thu, 11 Apr 2019 11:50:49 -0700
|
|
Subject: fix: export DebugOptions
|
|
|
|
|
|
diff --git a/src/node_options.cc b/src/node_options.cc
|
|
index 021fc5d70b250b39ac76028b5d384608d51f7248..11c910bbd17c8b8e345862e11a24aba7822c31b6 100644
|
|
--- a/src/node_options.cc
|
|
+++ b/src/node_options.cc
|
|
@@ -202,11 +202,6 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors) {
|
|
|
|
namespace options_parser {
|
|
|
|
-class DebugOptionsParser : public OptionsParser<DebugOptions> {
|
|
- public:
|
|
- DebugOptionsParser();
|
|
-};
|
|
-
|
|
class EnvironmentOptionsParser : public OptionsParser<EnvironmentOptions> {
|
|
public:
|
|
EnvironmentOptionsParser();
|
|
diff --git a/src/node_options.h b/src/node_options.h
|
|
index 34c54511e1bb8bba201994802f7fd53c4217cece..35daba3291c8358a44f9fca53df34b35c5423d15 100644
|
|
--- a/src/node_options.h
|
|
+++ b/src/node_options.h
|
|
@@ -59,7 +59,7 @@ struct InspectPublishUid {
|
|
// to keep them separate since they are a group of options applying to a very
|
|
// specific part of Node. It might also make more sense for them to be
|
|
// per-Isolate, rather than per-Environment.
|
|
-class DebugOptions : public Options {
|
|
+class NODE_EXTERN DebugOptions : public Options {
|
|
public:
|
|
DebugOptions() = default;
|
|
DebugOptions(const DebugOptions&) = default;
|
|
@@ -236,7 +236,7 @@ class PerProcessOptions : public Options {
|
|
|
|
namespace options_parser {
|
|
|
|
-HostPort SplitHostPort(const std::string& arg,
|
|
+HostPort NODE_EXTERN SplitHostPort(const std::string& arg,
|
|
std::vector<std::string>* errors);
|
|
void GetOptions(const v8::FunctionCallbackInfo<v8::Value>& args);
|
|
|
|
@@ -429,6 +429,11 @@ class OptionsParser {
|
|
friend void GetOptions(const v8::FunctionCallbackInfo<v8::Value>& args);
|
|
};
|
|
|
|
+class NODE_EXTERN DebugOptionsParser : public OptionsParser<DebugOptions> {
|
|
+ public:
|
|
+ DebugOptionsParser();
|
|
+};
|
|
+
|
|
using StringVector = std::vector<std::string>;
|
|
template <class OptionsType, class = Options>
|
|
void Parse(
|