 a4de915b74
			
		
	
	
	
	
	a4de915b74* chore: bump chromium in DEPS to db7d7b3e7cb2bc925f2abfde526280cfdfc21a41 * Update patches * chore: bump chromium in DEPS to 5613e1b99a44fcbe22f3910f803ca76903a77ec1 * Update patches * Network service: Remove primary_network_context bool. https://chromium-review.googlesource.com/c/chromium/src/+/2204678 * WebContentsObserver now implements OnRendererResponsive https://chromium-review.googlesource.com/c/chromium/src/+/2211066 * update patches * Fixup printing patch * chore: bump chromium in DEPS to e387b972cdd7160c416fa6c64a724e2258aa0218 * update patches * [printing] Move PrintHostMsg_DidPrintContent_Params to print.mojom https://chromium-review.googlesource.com/c/chromium/src/+/2212110 * [XProto] Move items from ::x11::XProto to ::x11 https://chromium-review.googlesource.com/c/chromium/src/+/2218476 * revert Add IChromeAccessible This was added in https://chromium-review.googlesource.com/c/chromium/src/+/2206224 but it breaks WOA builds because third_party/win_build_output/midl/ui/accessibility/platform/arm64 does not exist. The link above says that the new interface is behind a feature flag which is disabled by default so it is safe to remove for now. * rebaseline ichromeaccessible for Windows arm64 This patch will not be needed once we get the next roll. * Update to 1b9e01844e8bf1aaafc4a52c0c62af7f56d9637b to get arm64 fix * update patches * chore: bump chromium in DEPS to 096aefa04092ea00f7b68d8d19345883f20db3c3 * chore: bump chromium in DEPS to a524a45ffd1d6fd46a7a86138fe2b22df5b6651a * chore: update patches * Window Placement: Gate cross-screen fullscreen behavior on permission https://chromium-review.googlesource.com/c/chromium/src/+/2203268 * chore: add spec for https://crbug.com/1085836 * chore: bump chromium in DEPS to ff6c4f4b826d66c2e32380bf5d1eb5e1fe37faef * update patches Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com>
		
			
				
	
	
		
			146 lines
		
	
	
	
		
			4.9 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			146 lines
		
	
	
	
		
			4.9 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 | |
| From: Cheng Zhao <zcbenz@gmail.com>
 | |
| Date: Thu, 20 Sep 2018 17:48:49 -0700
 | |
| Subject: mas_disable_custom_window_frame.patch
 | |
| 
 | |
| Disable private window frame APIs (NSNextStepFrame and NSThemeFrame) for MAS
 | |
| build.
 | |
| 
 | |
| diff --git a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | |
| index cf88f696a46ff0ac84bcf466b44d1080438426c1..7672eee30a811001a0149edfa4eed9dc6a4b11f6 100644
 | |
| --- a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | |
| +++ b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | |
| @@ -9,6 +9,7 @@
 | |
|  #include "components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h"
 | |
|  #include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
|  @interface NSWindow (PrivateBrowserNativeWidgetAPI)
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
 | |
|  @end
 | |
| @@ -63,10 +64,13 @@
 | |
|  
 | |
|  @end
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @implementation BrowserNativeWidgetWindow
 | |
|  
 | |
|  // NSWindow (PrivateAPI) overrides.
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | |
|    // - NSThemeFrame and its subclasses will be nil if it's missing at runtime.
 | |
|    if ([BrowserWindowFrame class])
 | |
| @@ -81,6 +85,8 @@
 | |
|    return NO;
 | |
|  }
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  // Handle "Move focus to the window toolbar" configured in System Preferences ->
 | |
|  // Keyboard -> Shortcuts -> Keyboard. Usually Ctrl+F5. The argument (|unknown|)
 | |
|  // tends to just be nil.
 | |
| diff --git a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | |
| index 8416c7c6e052dafb2aad61c0bd3224c36e945d23..cd356beda023ab2409b16d58ca38c70ba3674913 100644
 | |
| --- a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | |
| +++ b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | |
| @@ -4,6 +4,8 @@
 | |
|  
 | |
|  #import "components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.h"
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
| +
 | |
|  @interface NSWindow (PrivateAPI)
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
 | |
|  @end
 | |
| @@ -18,8 +20,12 @@
 | |
|  }
 | |
|  @end
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @implementation NativeWidgetMacFramelessNSWindow
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
| +
 | |
|  + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | |
|    if ([NativeWidgetMacFramelessNSWindowFrame class]) {
 | |
|      return [NativeWidgetMacFramelessNSWindowFrame class];
 | |
| @@ -27,4 +33,6 @@
 | |
|    return [super frameViewClassForStyleMask:windowStyle];
 | |
|  }
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @end
 | |
| diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | |
| index e03bbc724cfd01967e71998394361556df1c4915..783745b11365c04c1e1052197d20d494bc901d45 100644
 | |
| --- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | |
| +++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | |
| @@ -17,6 +17,7 @@ class NativeWidgetNSWindowBridge;
 | |
|  
 | |
|  @protocol WindowTouchBarDelegate;
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
|  // Weak lets Chrome launch even if a future macOS doesn't have the below classes
 | |
|  WEAK_IMPORT_ATTRIBUTE
 | |
|  @interface NSNextStepFrame : NSView
 | |
| @@ -33,6 +34,7 @@ REMOTE_COCOA_APP_SHIM_EXPORT
 | |
|  REMOTE_COCOA_APP_SHIM_EXPORT
 | |
|  @interface NativeWidgetMacNSWindowTitledFrame : NSThemeFrame
 | |
|  @end
 | |
| +#endif
 | |
|  
 | |
|  // The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that
 | |
|  // can only be accomplished by overriding methods.
 | |
| diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | |
| index 757c72d98de11f611309f4f5af8d0d9aab639181..a6319a0760308df6bac6b39ad3500ad77c1b6525 100644
 | |
| --- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | |
| +++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | |
| @@ -16,7 +16,9 @@
 | |
|  #import "ui/base/cocoa/window_size_constants.h"
 | |
|  
 | |
|  @interface NSWindow (Private)
 | |
| +#ifndef MAS_BUILD
 | |
|  + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle;
 | |
| +#endif
 | |
|  - (BOOL)hasKeyAppearance;
 | |
|  - (long long)_resizeDirectionForMouseLocation:(CGPoint)location;
 | |
|  - (BOOL)_isConsideredOpenForPersistentState;
 | |
| @@ -58,6 +60,8 @@
 | |
|  }
 | |
|  @end
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
| +
 | |
|  @implementation NativeWidgetMacNSWindowTitledFrame
 | |
|  - (void)mouseDown:(NSEvent*)event {
 | |
|    if (base::mac::IsAtMostOS10_11() && self.window.isMovable)
 | |
| @@ -84,6 +88,8 @@
 | |
|  }
 | |
|  @end
 | |
|  
 | |
| +#endif  // MAS_BUILD
 | |
| +
 | |
|  @implementation NativeWidgetMacNSWindow {
 | |
|   @private
 | |
|    base::scoped_nsobject<CommandDispatcher> _commandDispatcher;
 | |
| @@ -165,6 +171,8 @@
 | |
|  
 | |
|  // NSWindow overrides.
 | |
|  
 | |
| +#ifndef MAS_BUILD
 | |
| +
 | |
|  + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
 | |
|    if (windowStyle & NSWindowStyleMaskTitled) {
 | |
|      if (Class customFrame = [NativeWidgetMacNSWindowTitledFrame class])
 | |
| @@ -176,6 +184,8 @@
 | |
|    return [super frameViewClassForStyleMask:windowStyle];
 | |
|  }
 | |
|  
 | |
| +#endif
 | |
| +
 | |
|  - (BOOL)_isTitleHidden {
 | |
|    bool shouldShowWindowTitle = YES;
 | |
|    if (_bridge)
 |