be1a3dce83
* build: test windows runner * build: try build windows on windows? * build: take win/cross changes * build: use bash as default shell always * build: configure git for windows build tools * build: bash as default * build: configure windows correctly * build: use sha1sum * build: force windows cipd init and python3 existence * just pain * build: restore cache on windows * build: use build-tools gclient * build: sync gclient vars to build windows job * build: output depshash for debugging * build: past sam was a silly goose * build: depshash logging * build: force lf endings for lock and DEPS * build: platform strings are hard * build: checkout on windows host * sup * no check * idk * sigh * ... * no double checkout * build: yolo some stuff * build: run gn-check for windows on linux hosts for speed * use container... * cry ? * build: e d * e d * no log * fix toolchain on windows cross check * build: use powershell to add mksnapshot_args * build: enable x86 and arm64 windows builds too * clean up * maybe not needed * build: keep action around for post step * build: configure git global on win * build: ia32 zip manifest * build: no patch depot_tools for tests * build: get arm64 windows closer to working * build: windows tar is ass * 32 bit on 32 bit * maybe bash * build: set up nodejs * correct windows sharding * fix some spec runner stuff * fix windows tests * overwrite -Force * sigh * screen res * wat * logs * ... more logs * line endings will be the death of me * remove 1080p force thing * vsctools + logging * disable some fullscreen tests on GHA * no progress * run all CI * install visual studio on arm64 * windows hax for non windows * maybe arm sdk * clean up depshash logic * build: use single check per platform * ensure clean args * fix loop * remove debug * update default build image sha for dispatch * plzzzz * one more try * arm64 vctools * sad * build: fix non-dispatch windows gn check * chore: debug datadog-ci location * chore: update build-tools for newer toolchain * chore: set path for datadog-ci * try this * chore: fixup gn check * fixup gn-check some more * fixup windows gn check * chore: fixup windows gn check * test: use cmd for Windows testing * fixup use cmd for testing on Windows * fixup windows GN check * fixup npm config arch for x86 * Can we set test files via powershell * fixup to set test files via powershell * fixup set test files via powershell * Don't check cross instance cache disk space on Windows * Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing (AGAIN) * use powershell if in powershell * fixup use powershell if in powershell * chore: remove no longer needed changes to depot_tools xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094 and https://chromium-review.googlesource.com/c/chromium/src/+/5844046 * chore: try using 7zip on Windows to extract tarball * Revert "chore: try using 7zip on Windows to extract tarball" This reverts commit c7432b6a37857fd0746b8f1776fbd1103dba0b85. * test: debug failing tests on GHA windows * fix: ftbfs when including simdjson in Node.js (cherry picked from commit 48e44c40d61b7aa843a990d4e0c8dec676b4ce8f) * chore: try to track down Windows testing hang * use correct timeout * try this * see if this helps * try to figure out why node is running * shard tests to try to narrow down WOA lockup * try to narrow down problem test * Narrow down blocking test more * do we need a combo to repro * see if this cleans up the tests * fixup navigator.usb test * remove logging from problematic tests * Revert "shard tests to try to narrow down WOA lockup" This reverts commit a1806583769678491814cb8b008131c32be4e8fb. * remove logging * debug keyboard test * add timeout for Windows since arm64 sometimes hangs * see if this helps * put back original timeout * try to use screenCapture to get screenshots of what is going on on WOA * try using electron screencapture to debug WOA hang * chore: turn off privacy experience * run screenshot on both shards * fixup screencap * try to narrow down hanging spec * chore: cleanup servers left open * cleanup tests * Revert "try to narrow down hanging spec" This reverts commit a0f959f5382f4012a9919ac535d42c5333eb7d5f. * cleanup test debugging * fixup extensions spec * cleanup unneeded items * run wtf with 2 shards instead of 6 * Revert "run wtf with 2 shards instead of 6" This reverts commit ca2d282129ee42c535d80f9876d6fa0dc6c08344. * debug windows version on woa * dump more info * Get detailed CPU info * revert debugging * use same args as AppVeyor WOA for GHA WOA * fixup use same args as AppVeyor WOA for GHA WOA * fixup use same args as AppVeyor WOA for GHA WOA * try to track down which tests trigger hang * one or more of these combinations should hang * break up web contents spec to find hang * further break down api-web-contents to find hang * test: ensure all webContents are closed * test: fix require is not defined error * see if api-web-contents spec is now good * test: ensure all webContents are closed * Revert "try to track down which tests trigger hang" This reverts commit 07298d6ffeb4873ef7615a8ec3d1a6696e354ff4. * chore: use alternate location for windows toolchain * Reapply "try to track down which tests trigger hang" This reverts commit 0321f76d01069ef325339b6fe6ed39700eae2b6b. * try to narrow down problem test * fix TEST_SHARD env var * no, really fix TEST_SHARD env var * see if this fixes it * test: cleanup any remaining windows and webcontents * see if new cleanup helps * dont destroy webcontents for now * fixup dont destroy webcontents for now * Only cleanup right before process.exit * see if this fixes the hang * actually destroy webcontents * Revert "Reapply "try to track down which tests trigger hang"" This reverts commit cdee7de049ce6bb5f67bbcc64882c56aa2c73027. * see if this helps * Revert "see if this helps" This reverts commit 9a15a69cf7dbc456db7a61efa5b6870535bae993. * Is it all about the web contents? * it is all about the webcontents but which one? * Narrow down problem webcontents test * try to speed up git install on WOA * disable problematic test on WOA * remove debugging * remove debugging from choco installs * Revert "disable problematic test on WOA" This reverts commit e060fb0839b73d53cfde1f8acdca634f8e267937. * Revert "remove debugging" This reverts commit f18dd8b1a555f56bb06d0ea996a6eff31b424bf1. * run against all the tests in the failing shard * don't run visibility tests first * remove debugging * 3 is a magic number * Revert "3 is a magic number" This reverts commit 36b91ccf9f03a4b34230cd69ceca482f7d8428c1. * match what Appveyor runs exactly * Revert "match what Appveyor runs exactly" This reverts commit 7260dd432216c62696e4bc864930f17c857eabbe. * chore: sort files alphabetically * find out what spec is leaving stuff open * chore: Checkout PR HEAD commit instead of merge commit * try using app.exit instead of process.exit * test: cleanup BrowserWindows and webContents * Revert "chore: sort files alphabetically" This reverts commit d9e217ffb1522076e150fce9e43a31bf56716acb. * chore: use win32 to match process.platform Needed for build-tools to download from PRs * chore: cache yarn dir * fixup cache yarn * fixup use win32 to match process.platform * fixup use win32 to match process.platform * fixup cache yarn * Add debugging for WOA hang * Add debugging for failing keyboard lock test * Revert "Add debugging for WOA hang" This reverts commit 8df03d568d15a269e4026140d1158e8cdf551dec. * try using process.kill * add more debugging to keyboard.lock test * Revert "Add debugging for failing keyboard lock test" * remove debugging * test: disable keyboard.lock on Windows * test: disable fullscreen tests on Windows * test: only force test suite exit on WOA * fixup test: only force test suite exit on WOA * cleanup tests * extract yarn caching/install to action * try using bash to run windows tests * remove left over debugging * standardize on 'win' for Windows builds * use 'x86' for arch for manifest files * fixup try using bash to run windows tests * fixup use 'x86' for arch for manifest files * standardize on 'win' for Windows builds * fixup use 'x86' for arch for manifest files * fixup try using bash to run windows tests --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com>
384 lines
13 KiB
YAML
384 lines
13 KiB
YAML
name: Build
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
inputs:
|
|
build-image-sha:
|
|
type: string
|
|
description: 'SHA for electron/build image'
|
|
default: 'bc2f48b2415a670de18d13605b1cf0eb5fdbaae1'
|
|
required: true
|
|
skip-macos:
|
|
type: boolean
|
|
description: 'Skip macOS builds'
|
|
default: false
|
|
required: false
|
|
skip-linux:
|
|
type: boolean
|
|
description: 'Skip Linux builds'
|
|
default: false
|
|
required: false
|
|
skip-windows:
|
|
type: boolean
|
|
description: 'Skip Windows builds'
|
|
default: false
|
|
required: false
|
|
skip-lint:
|
|
type: boolean
|
|
description: 'Skip lint check'
|
|
default: false
|
|
required: false
|
|
push:
|
|
branches:
|
|
- main
|
|
- '[1-9][0-9]-x-y'
|
|
pull_request:
|
|
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
|
|
jobs:
|
|
setup:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
pull-requests: read
|
|
outputs:
|
|
docs: ${{ steps.filter.outputs.docs }}
|
|
src: ${{ steps.filter.outputs.src }}
|
|
build-image-sha: ${{ steps.set-output.outputs.build-image-sha }}
|
|
docs-only: ${{ steps.set-output.outputs.docs-only }}
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #v4.0.2
|
|
with:
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
|
|
id: filter
|
|
with:
|
|
filters: |
|
|
docs:
|
|
- 'docs/**'
|
|
src:
|
|
- '!docs/**'
|
|
- name: Set Outputs for Build Image SHA & Docs Only
|
|
id: set-output
|
|
run: |
|
|
if [ -z "${{ inputs.build-image-sha }}" ]; then
|
|
echo "build-image-sha=bc2f48b2415a670de18d13605b1cf0eb5fdbaae1" >> "$GITHUB_OUTPUT"
|
|
else
|
|
echo "build-image-sha=${{ inputs.build-image-sha }}" >> "$GITHUB_OUTPUT"
|
|
fi
|
|
echo "docs-only=${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.src == 'false' }}" >> "$GITHUB_OUTPUT"
|
|
|
|
# Lint Jobs
|
|
lint:
|
|
needs: setup
|
|
if: ${{ !inputs.skip-lint }}
|
|
uses: ./.github/workflows/pipeline-electron-lint.yml
|
|
with:
|
|
container: '{"image":"ghcr.io/electron/build:${{ needs.setup.outputs.build-image-sha }}","options":"--user root"}'
|
|
secrets: inherit
|
|
|
|
# Docs Only Jobs
|
|
docs-only:
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.docs-only == 'true' }}
|
|
uses: ./.github/workflows/pipeline-electron-docs-only.yml
|
|
with:
|
|
container: '{"image":"ghcr.io/electron/build:${{ needs.setup.outputs.build-image-sha }}","options":"--user root"}'
|
|
secrets: inherit
|
|
|
|
# Checkout Jobs
|
|
checkout-macos:
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.src == 'true' && !inputs.skip-macos}}
|
|
runs-on: electron-arc-linux-amd64-32core
|
|
container:
|
|
image: ghcr.io/electron/build:${{ needs.setup.outputs.build-image-sha }}
|
|
options: --user root
|
|
volumes:
|
|
- /mnt/cross-instance-cache:/mnt/cross-instance-cache
|
|
- /var/run/sas:/var/run/sas
|
|
env:
|
|
GCLIENT_EXTRA_ARGS: '--custom-var=checkout_mac=True --custom-var=host_os=mac'
|
|
outputs:
|
|
build-image-sha: ${{ needs.setup.outputs.build-image-sha }}
|
|
steps:
|
|
- name: Checkout Electron
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
|
|
with:
|
|
path: src/electron
|
|
fetch-depth: 0
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
- name: Checkout & Sync & Save
|
|
uses: ./src/electron/.github/actions/checkout
|
|
with:
|
|
generate-sas-token: 'true'
|
|
|
|
checkout-linux:
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.src == 'true' && !inputs.skip-linux}}
|
|
runs-on: electron-arc-linux-amd64-32core
|
|
container:
|
|
image: ghcr.io/electron/build:${{ needs.setup.outputs.build-image-sha }}
|
|
options: --user root
|
|
volumes:
|
|
- /mnt/cross-instance-cache:/mnt/cross-instance-cache
|
|
- /var/run/sas:/var/run/sas
|
|
env:
|
|
GCLIENT_EXTRA_ARGS: '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True'
|
|
PATCH_UP_APP_CREDS: ${{ secrets.PATCH_UP_APP_CREDS }}
|
|
outputs:
|
|
build-image-sha: ${{ needs.setup.outputs.build-image-sha}}
|
|
steps:
|
|
- name: Checkout Electron
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
|
|
with:
|
|
path: src/electron
|
|
fetch-depth: 0
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
- name: Checkout & Sync & Save
|
|
uses: ./src/electron/.github/actions/checkout
|
|
|
|
checkout-windows:
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.src == 'true' && !inputs.skip-windows }}
|
|
runs-on: electron-arc-linux-amd64-32core
|
|
container:
|
|
image: ghcr.io/electron/build:${{ needs.setup.outputs.build-image-sha }}
|
|
options: --user root --device /dev/fuse --cap-add SYS_ADMIN
|
|
volumes:
|
|
- /mnt/cross-instance-cache:/mnt/cross-instance-cache
|
|
env:
|
|
GCLIENT_EXTRA_ARGS: '--custom-var=checkout_win=True'
|
|
TARGET_OS: 'win'
|
|
ELECTRON_DEPOT_TOOLS_WIN_TOOLCHAIN: '1'
|
|
outputs:
|
|
build-image-sha: ${{ needs.setup.outputs.build-image-sha}}
|
|
steps:
|
|
- name: Checkout Electron
|
|
uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29
|
|
with:
|
|
path: src/electron
|
|
fetch-depth: 0
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
- name: Checkout & Sync & Save
|
|
uses: ./src/electron/.github/actions/checkout
|
|
|
|
# GN Check Jobs
|
|
macos-gn-check:
|
|
uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml
|
|
needs: checkout-macos
|
|
with:
|
|
target-platform: macos
|
|
target-archs: x64 arm64
|
|
check-runs-on: macos-14
|
|
gn-build-type: testing
|
|
secrets: inherit
|
|
|
|
linux-gn-check:
|
|
uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml
|
|
needs: checkout-linux
|
|
with:
|
|
target-platform: linux
|
|
target-archs: x64 arm arm64
|
|
check-runs-on: electron-arc-linux-amd64-8core
|
|
check-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root","volumes":["/mnt/cross-instance-cache:/mnt/cross-instance-cache"]}'
|
|
gn-build-type: testing
|
|
secrets: inherit
|
|
|
|
windows-gn-check:
|
|
uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml
|
|
needs: checkout-windows
|
|
with:
|
|
target-platform: win
|
|
target-archs: x64 x86 arm64
|
|
check-runs-on: electron-arc-linux-amd64-8core
|
|
check-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-windows.outputs.build-image-sha }}","options":"--user root --device /dev/fuse --cap-add SYS_ADMIN","volumes":["/mnt/cross-instance-cache:/mnt/cross-instance-cache"]}'
|
|
gn-build-type: testing
|
|
secrets: inherit
|
|
|
|
# Build Jobs - These cascade into testing jobs
|
|
macos-x64:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: checkout-macos
|
|
with:
|
|
build-runs-on: macos-14-xlarge
|
|
test-runs-on: macos-13
|
|
target-platform: macos
|
|
target-arch: x64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
macos-arm64:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: checkout-macos
|
|
with:
|
|
build-runs-on: macos-14-xlarge
|
|
test-runs-on: macos-14
|
|
target-platform: macos
|
|
target-arch: arm64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
linux-x64:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test-and-nan.yml
|
|
needs: checkout-linux
|
|
with:
|
|
build-runs-on: electron-arc-linux-amd64-32core
|
|
test-runs-on: electron-arc-linux-amd64-4core
|
|
build-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root","volumes":["/mnt/cross-instance-cache:/mnt/cross-instance-cache"]}'
|
|
test-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root --privileged --init"}'
|
|
target-platform: linux
|
|
target-arch: x64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
linux-x64-asan:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: checkout-linux
|
|
with:
|
|
build-runs-on: electron-arc-linux-amd64-32core
|
|
test-runs-on: electron-arc-linux-amd64-4core
|
|
build-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root","volumes":["/mnt/cross-instance-cache:/mnt/cross-instance-cache"]}'
|
|
test-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root --privileged --init"}'
|
|
target-platform: linux
|
|
target-arch: x64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
is-asan: true
|
|
secrets: inherit
|
|
|
|
linux-arm:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: checkout-linux
|
|
with:
|
|
build-runs-on: electron-arc-linux-amd64-32core
|
|
test-runs-on: electron-arc-linux-arm64-4core
|
|
build-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root","volumes":["/mnt/cross-instance-cache:/mnt/cross-instance-cache"]}'
|
|
test-container: '{"image":"ghcr.io/electron/test:arm32v7-${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root --privileged --init","volumes":["/home/runner/externals:/mnt/runner-externals"]}'
|
|
target-platform: linux
|
|
target-arch: arm
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
linux-arm64:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: checkout-linux
|
|
with:
|
|
build-runs-on: electron-arc-linux-amd64-32core
|
|
test-runs-on: electron-arc-linux-arm64-4core
|
|
build-container: '{"image":"ghcr.io/electron/build:${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root","volumes":["/mnt/cross-instance-cache:/mnt/cross-instance-cache"]}'
|
|
test-container: '{"image":"ghcr.io/electron/test:arm64v8-${{ needs.checkout-linux.outputs.build-image-sha }}","options":"--user root --privileged --init"}'
|
|
target-platform: linux
|
|
target-arch: arm64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
windows-x64:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.src == 'true' && !inputs.skip-windows }}
|
|
with:
|
|
build-runs-on: electron-arc-windows-amd64-16core
|
|
test-runs-on: windows-latest
|
|
target-platform: win
|
|
target-arch: x64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
windows-x86:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.src == 'true' && !inputs.skip-windows }}
|
|
with:
|
|
build-runs-on: electron-arc-windows-amd64-16core
|
|
test-runs-on: windows-latest
|
|
target-platform: win
|
|
target-arch: x86
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
windows-arm64:
|
|
permissions:
|
|
contents: read
|
|
issues: read
|
|
pull-requests: read
|
|
uses: ./.github/workflows/pipeline-electron-build-and-test.yml
|
|
needs: setup
|
|
if: ${{ needs.setup.outputs.src == 'true' && !inputs.skip-windows }}
|
|
with:
|
|
build-runs-on: electron-arc-windows-amd64-16core
|
|
test-runs-on: electron-hosted-windows-arm64-4core
|
|
target-platform: win
|
|
target-arch: arm64
|
|
is-release: false
|
|
gn-build-type: testing
|
|
generate-symbols: false
|
|
upload-to-storage: '0'
|
|
secrets: inherit
|
|
|
|
gha-done:
|
|
name: GitHub Actions Completed
|
|
runs-on: ubuntu-latest
|
|
needs: [docs-only, macos-x64, macos-arm64, linux-x64, linux-x64-asan, linux-arm, linux-arm64, windows-x64, windows-x86, windows-arm64]
|
|
if: always() && !contains(needs.*.result, 'failure')
|
|
steps:
|
|
- name: GitHub Actions Jobs Done
|
|
run: |
|
|
echo "All GitHub Actions Jobs are done"
|