
* build: test windows runner * build: try build windows on windows? * build: take win/cross changes * build: use bash as default shell always * build: configure git for windows build tools * build: bash as default * build: configure windows correctly * build: use sha1sum * build: force windows cipd init and python3 existence * just pain * build: restore cache on windows * build: use build-tools gclient * build: sync gclient vars to build windows job * build: output depshash for debugging * build: past sam was a silly goose * build: depshash logging * build: force lf endings for lock and DEPS * build: platform strings are hard * build: checkout on windows host * sup * no check * idk * sigh * ... * no double checkout * build: yolo some stuff * build: run gn-check for windows on linux hosts for speed * use container... * cry ? * build: e d * e d * no log * fix toolchain on windows cross check * build: use powershell to add mksnapshot_args * build: enable x86 and arm64 windows builds too * clean up * maybe not needed * build: keep action around for post step * build: configure git global on win * build: ia32 zip manifest * build: no patch depot_tools for tests * build: get arm64 windows closer to working * build: windows tar is ass * 32 bit on 32 bit * maybe bash * build: set up nodejs * correct windows sharding * fix some spec runner stuff * fix windows tests * overwrite -Force * sigh * screen res * wat * logs * ... more logs * line endings will be the death of me * remove 1080p force thing * vsctools + logging * disable some fullscreen tests on GHA * no progress * run all CI * install visual studio on arm64 * windows hax for non windows * maybe arm sdk * clean up depshash logic * build: use single check per platform * ensure clean args * fix loop * remove debug * update default build image sha for dispatch * plzzzz * one more try * arm64 vctools * sad * build: fix non-dispatch windows gn check * chore: debug datadog-ci location * chore: update build-tools for newer toolchain * chore: set path for datadog-ci * try this * chore: fixup gn check * fixup gn-check some more * fixup windows gn check * chore: fixup windows gn check * test: use cmd for Windows testing * fixup use cmd for testing on Windows * fixup windows GN check * fixup npm config arch for x86 * Can we set test files via powershell * fixup to set test files via powershell * fixup set test files via powershell * Don't check cross instance cache disk space on Windows * Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing (AGAIN) * use powershell if in powershell * fixup use powershell if in powershell * chore: remove no longer needed changes to depot_tools xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094 and https://chromium-review.googlesource.com/c/chromium/src/+/5844046 * chore: try using 7zip on Windows to extract tarball * Revert "chore: try using 7zip on Windows to extract tarball" This reverts commit c7432b6a37857fd0746b8f1776fbd1103dba0b85. * test: debug failing tests on GHA windows * fix: ftbfs when including simdjson in Node.js (cherry picked from commit 48e44c40d61b7aa843a990d4e0c8dec676b4ce8f) * chore: try to track down Windows testing hang * use correct timeout * try this * see if this helps * try to figure out why node is running * shard tests to try to narrow down WOA lockup * try to narrow down problem test * Narrow down blocking test more * do we need a combo to repro * see if this cleans up the tests * fixup navigator.usb test * remove logging from problematic tests * Revert "shard tests to try to narrow down WOA lockup" This reverts commit a1806583769678491814cb8b008131c32be4e8fb. * remove logging * debug keyboard test * add timeout for Windows since arm64 sometimes hangs * see if this helps * put back original timeout * try to use screenCapture to get screenshots of what is going on on WOA * try using electron screencapture to debug WOA hang * chore: turn off privacy experience * run screenshot on both shards * fixup screencap * try to narrow down hanging spec * chore: cleanup servers left open * cleanup tests * Revert "try to narrow down hanging spec" This reverts commit a0f959f5382f4012a9919ac535d42c5333eb7d5f. * cleanup test debugging * fixup extensions spec * cleanup unneeded items * run wtf with 2 shards instead of 6 * Revert "run wtf with 2 shards instead of 6" This reverts commit ca2d282129ee42c535d80f9876d6fa0dc6c08344. * debug windows version on woa * dump more info * Get detailed CPU info * revert debugging * use same args as AppVeyor WOA for GHA WOA * fixup use same args as AppVeyor WOA for GHA WOA * fixup use same args as AppVeyor WOA for GHA WOA * try to track down which tests trigger hang * one or more of these combinations should hang * break up web contents spec to find hang * further break down api-web-contents to find hang * test: ensure all webContents are closed * test: fix require is not defined error * see if api-web-contents spec is now good * test: ensure all webContents are closed * Revert "try to track down which tests trigger hang" This reverts commit 07298d6ffeb4873ef7615a8ec3d1a6696e354ff4. * chore: use alternate location for windows toolchain * Reapply "try to track down which tests trigger hang" This reverts commit 0321f76d01069ef325339b6fe6ed39700eae2b6b. * try to narrow down problem test * fix TEST_SHARD env var * no, really fix TEST_SHARD env var * see if this fixes it * test: cleanup any remaining windows and webcontents * see if new cleanup helps * dont destroy webcontents for now * fixup dont destroy webcontents for now * Only cleanup right before process.exit * see if this fixes the hang * actually destroy webcontents * Revert "Reapply "try to track down which tests trigger hang"" This reverts commit cdee7de049ce6bb5f67bbcc64882c56aa2c73027. * see if this helps * Revert "see if this helps" This reverts commit 9a15a69cf7dbc456db7a61efa5b6870535bae993. * Is it all about the web contents? * it is all about the webcontents but which one? * Narrow down problem webcontents test * try to speed up git install on WOA * disable problematic test on WOA * remove debugging * remove debugging from choco installs * Revert "disable problematic test on WOA" This reverts commit e060fb0839b73d53cfde1f8acdca634f8e267937. * Revert "remove debugging" This reverts commit f18dd8b1a555f56bb06d0ea996a6eff31b424bf1. * run against all the tests in the failing shard * don't run visibility tests first * remove debugging * 3 is a magic number * Revert "3 is a magic number" This reverts commit 36b91ccf9f03a4b34230cd69ceca482f7d8428c1. * match what Appveyor runs exactly * Revert "match what Appveyor runs exactly" This reverts commit 7260dd432216c62696e4bc864930f17c857eabbe. * chore: sort files alphabetically * find out what spec is leaving stuff open * chore: Checkout PR HEAD commit instead of merge commit * try using app.exit instead of process.exit * test: cleanup BrowserWindows and webContents * Revert "chore: sort files alphabetically" This reverts commit d9e217ffb1522076e150fce9e43a31bf56716acb. * chore: use win32 to match process.platform Needed for build-tools to download from PRs * chore: cache yarn dir * fixup cache yarn * fixup use win32 to match process.platform * fixup use win32 to match process.platform * fixup cache yarn * Add debugging for WOA hang * Add debugging for failing keyboard lock test * Revert "Add debugging for WOA hang" This reverts commit 8df03d568d15a269e4026140d1158e8cdf551dec. * try using process.kill * add more debugging to keyboard.lock test * Revert "Add debugging for failing keyboard lock test" * remove debugging * test: disable keyboard.lock on Windows * test: disable fullscreen tests on Windows * test: only force test suite exit on WOA * fixup test: only force test suite exit on WOA * cleanup tests * extract yarn caching/install to action * try using bash to run windows tests * remove left over debugging * standardize on 'win' for Windows builds * use 'x86' for arch for manifest files * fixup try using bash to run windows tests * fixup use 'x86' for arch for manifest files * standardize on 'win' for Windows builds * fixup use 'x86' for arch for manifest files * fixup try using bash to run windows tests --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com>
223 lines
9.8 KiB
YAML
223 lines
9.8 KiB
YAML
name: 'Build Electron'
|
|
description: 'Builds Electron & Friends'
|
|
inputs:
|
|
target-arch:
|
|
description: 'Target arch'
|
|
required: true
|
|
target-platform:
|
|
description: 'Target platform, should be linux, win, macos'
|
|
required: true
|
|
artifact-platform:
|
|
description: 'Artifact platform, should be linux, win, darwin or mas'
|
|
required: true
|
|
step-suffix:
|
|
description: 'Suffix for build steps'
|
|
required: false
|
|
default: ''
|
|
is-release:
|
|
description: 'Is release build'
|
|
required: true
|
|
strip-binaries:
|
|
description: 'Strip binaries (Linux only)'
|
|
required: false
|
|
generate-symbols:
|
|
description: 'Generate symbols'
|
|
required: true
|
|
upload-to-storage:
|
|
description: 'Upload to storage'
|
|
required: true
|
|
is-asan:
|
|
description: 'The ASan Linux build'
|
|
required: false
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- name: Set GN_EXTRA_ARGS for MacOS x64 Builds
|
|
shell: bash
|
|
if: ${{ inputs.target-arch == 'x64' && inputs.target-platform == 'macos' }}
|
|
run: |
|
|
GN_APPENDED_ARGS="$GN_EXTRA_ARGS target_cpu=\"x64\" v8_snapshot_toolchain=\"//build/toolchain/mac:clang_x64\""
|
|
echo "GN_EXTRA_ARGS=$GN_APPENDED_ARGS" >> $GITHUB_ENV
|
|
- name: Build Electron ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: |
|
|
rm -rf "src/out/Default/Electron Framework.framework"
|
|
rm -rf src/out/Default/Electron*.app
|
|
|
|
cd src/electron
|
|
# TODO(codebytere): remove this once we figure out why .git/packed-refs is initially missing
|
|
git pack-refs
|
|
cd ..
|
|
|
|
if [ "`uname`" = "Darwin" ]; then
|
|
ulimit -n 10000
|
|
sudo launchctl limit maxfiles 65536 200000
|
|
fi
|
|
|
|
NINJA_SUMMARIZE_BUILD=1 e build -j $NUMBER_OF_NINJA_PROCESSES
|
|
cp out/Default/.ninja_log out/electron_ninja_log
|
|
node electron/script/check-symlinks.js
|
|
- name: Strip Electron Binaries ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
if: ${{ inputs.strip-binaries == 'true' }}
|
|
run: |
|
|
cd src
|
|
electron/script/copy-debug-symbols.py --target-cpu="${{ inputs.target-arch }}" --out-dir=out/Default/debug --compress
|
|
electron/script/strip-binaries.py --target-cpu="${{ inputs.target-arch }}" --verbose
|
|
electron/script/add-debug-link.py --target-cpu="${{ inputs.target-arch }}" --debug-dir=out/Default/debug
|
|
- name: Build Electron dist.zip ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: |
|
|
cd src
|
|
e build --target electron:electron_dist_zip -j $NUMBER_OF_NINJA_PROCESSES
|
|
if [ "${{ inputs.is-asan }}" != "true" ]; then
|
|
target_os=${{ inputs.target-platform == 'macos' && 'mac' || inputs.target-platform }}
|
|
if [ "${{ inputs.artifact-platform }}" = "mas" ]; then
|
|
target_os="${target_os}_mas"
|
|
fi
|
|
electron/script/zip_manifests/check-zip-manifest.py out/Default/dist.zip electron/script/zip_manifests/dist_zip.$target_os.${{ inputs.target-arch }}.manifest
|
|
fi
|
|
- name: Build Mksnapshot ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: |
|
|
cd src
|
|
e build --target electron:electron_mksnapshot -j $NUMBER_OF_NINJA_PROCESSES
|
|
ELECTRON_DEPOT_TOOLS_DISABLE_LOG=1 e d gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args
|
|
# Remove unused args from mksnapshot_args
|
|
SEDOPTION="-i"
|
|
if [ "`uname`" = "Darwin" ]; then
|
|
SEDOPTION="-i ''"
|
|
fi
|
|
sed $SEDOPTION '/.*builtins-pgo/d' out/Default/mksnapshot_args
|
|
sed $SEDOPTION '/--turbo-profiling-input/d' out/Default/mksnapshot_args
|
|
|
|
if [ "${{ inputs.target-platform }}" = "linux" ]; then
|
|
if [ "${{ inputs.target-arch }}" = "arm" ]; then
|
|
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x86_v8_arm/mksnapshot
|
|
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x86_v8_arm/v8_context_snapshot_generator
|
|
elif [ "${{ inputs.target-arch }}" = "arm64" ]; then
|
|
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x64_v8_arm64/mksnapshot
|
|
electron/script/strip-binaries.py --file $PWD/out/Default/clang_x64_v8_arm64/v8_context_snapshot_generator
|
|
else
|
|
electron/script/strip-binaries.py --file $PWD/out/Default/mksnapshot
|
|
electron/script/strip-binaries.py --file $PWD/out/Default/v8_context_snapshot_generator
|
|
fi
|
|
fi
|
|
|
|
e build --target electron:electron_mksnapshot_zip -j $NUMBER_OF_NINJA_PROCESSES
|
|
if [ "${{ inputs.target-platform }}" = "win" ]; then
|
|
cd out/Default
|
|
powershell Compress-Archive -update mksnapshot_args mksnapshot.zip
|
|
powershell Compress-Archive -update gen/v8/embedded.S mksnapshot.zip
|
|
else
|
|
(cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S)
|
|
fi
|
|
- name: Generate Cross-Arch Snapshot (arm/arm64) ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
if: ${{ (inputs.target-arch == 'arm' || inputs.target-arch == 'arm64') && inputs.target-platform == 'linux' }}
|
|
run: |
|
|
cd src
|
|
if [ "${{ inputs.target-arch }}" = "arm" ]; then
|
|
MKSNAPSHOT_PATH="clang_x86_v8_arm"
|
|
elif [ "${{ inputs.target-arch }}" = "arm64" ]; then
|
|
MKSNAPSHOT_PATH="clang_x64_v8_arm64"
|
|
fi
|
|
|
|
cp "out/Default/$MKSNAPSHOT_PATH/mksnapshot" out/Default
|
|
cp "out/Default/$MKSNAPSHOT_PATH/v8_context_snapshot_generator" out/Default
|
|
cp "out/Default/$MKSNAPSHOT_PATH/libffmpeg.so" out/Default
|
|
|
|
python3 electron/script/verify-mksnapshot.py --source-root "$PWD" --build-dir out/Default --create-snapshot-only
|
|
mkdir cross-arch-snapshots
|
|
cp out/Default-mksnapshot-test/*.bin cross-arch-snapshots
|
|
# Clean up so that ninja does not get confused
|
|
rm -f out/Default/libffmpeg.so
|
|
- name: Build Chromedriver ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: |
|
|
cd src
|
|
e build --target electron:electron_chromedriver -j $NUMBER_OF_NINJA_PROCESSES
|
|
e build --target electron:electron_chromedriver_zip
|
|
- name: Build Node.js headers ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: |
|
|
cd src
|
|
e build --target electron:node_headers
|
|
- name: Generate & Zip Symbols ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: |
|
|
# Generate breakpad symbols on release builds
|
|
if [ "${{ inputs.generate-symbols }}" = "true" ]; then
|
|
e build --target electron:electron_symbols
|
|
fi
|
|
cd src
|
|
export BUILD_PATH="$(pwd)/out/Default"
|
|
e build --target electron:licenses
|
|
e build --target electron:electron_version_file
|
|
if [ "${{ inputs.is-release }}" = "true" ]; then
|
|
DELETE_DSYMS_AFTER_ZIP=1 electron/script/zip-symbols.py -b $BUILD_PATH
|
|
else
|
|
electron/script/zip-symbols.py -b $BUILD_PATH
|
|
fi
|
|
- name: Generate FFMpeg ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
if: ${{ inputs.is-release == 'true' }}
|
|
run: |
|
|
cd src
|
|
gn gen out/ffmpeg --args="import(\"//electron/build/args/ffmpeg.gn\") use_remoteexec=true $GN_EXTRA_ARGS"
|
|
e build --target electron:electron_ffmpeg_zip -C ../../out/ffmpeg -j $NUMBER_OF_NINJA_PROCESSES
|
|
- name: Generate Hunspell Dictionaries ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
if: ${{ inputs.is-release == 'true' && inputs.target-platform == 'linux' }}
|
|
run: |
|
|
e build --target electron:hunspell_dictionaries_zip -j $NUMBER_OF_NINJA_PROCESSES
|
|
- name: Generate Libcxx ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
if: ${{ inputs.is-release == 'true' && inputs.target-platform == 'linux' }}
|
|
run: |
|
|
e build --target electron:libcxx_headers_zip -j $NUMBER_OF_NINJA_PROCESSES
|
|
e build --target electron:libcxxabi_headers_zip -j $NUMBER_OF_NINJA_PROCESSES
|
|
e build --target electron:libcxx_objects_zip -j $NUMBER_OF_NINJA_PROCESSES
|
|
- name: Generate TypeScript Definitions ${{ inputs.step-suffix }}
|
|
if: ${{ inputs.is-release == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
cd src/electron
|
|
node script/yarn create-typescript-definitions
|
|
- name: Publish Electron Dist ${{ inputs.step-suffix }}
|
|
if: ${{ inputs.is-release == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
rm -rf src/out/Default/obj
|
|
cd src/electron
|
|
if [ "${{ inputs.upload-to-storage }}" = "1" ]; then
|
|
echo 'Uploading Electron release distribution to Azure'
|
|
script/release/uploaders/upload.py --verbose --upload_to_storage
|
|
else
|
|
echo 'Uploading Electron release distribution to GitHub releases'
|
|
script/release/uploaders/upload.py --verbose
|
|
fi
|
|
- name: Generate Artifact Key
|
|
shell: bash
|
|
run: |
|
|
if [ "${{ inputs.is-asan }}" = "true" ]; then
|
|
ARTIFACT_KEY=${{ inputs.artifact-platform }}_${{ inputs.target-arch }}_asan
|
|
else
|
|
ARTIFACT_KEY=${{ inputs.artifact-platform }}_${{ inputs.target-arch }}
|
|
fi
|
|
echo "ARTIFACT_KEY=$ARTIFACT_KEY" >> $GITHUB_ENV
|
|
# The current generated_artifacts_<< artifact.key >> name was taken from CircleCI
|
|
# to ensure we don't break anything, but we may be able to improve that.
|
|
- name: Move all Generated Artifacts to Upload Folder ${{ inputs.step-suffix }}
|
|
shell: bash
|
|
run: ./src/electron/script/actions/move-artifacts.sh
|
|
- name: Upload Generated Artifacts ${{ inputs.step-suffix }}
|
|
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
|
|
with:
|
|
name: generated_artifacts_${{ env.ARTIFACT_KEY }}
|
|
path: ./generated_artifacts_${{ inputs.artifact-platform }}_${{ inputs.target-arch }}
|
|
- name: Upload Src Artifacts ${{ inputs.step-suffix }}
|
|
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
|
|
with:
|
|
name: src_artifacts_${{ env.ARTIFACT_KEY }}
|
|
path: ./src_artifacts_${{ inputs.artifact-platform }}_${{ inputs.target-arch }}
|