bb7c63c052
* build: fix native_mksnapshot build When we changed our electron_mksnapshot_zip target to include the v8_context_snapshot_generator, this dependency made the `run_mksnapshot` target run which was trying to run an arm/arm64 binary on x64 hardware. Don't use custom build args for native_mksnapshot as they are not needed * Added comment on why snapshot_blob.bin is skipped on arm/arm64 |
||
|---|---|---|
| .. | ||
| .patches | ||
| add_realloc.patch | ||
| array_buffer.patch | ||
| build-torque-with-x64-toolchain-on-arm.patch | ||
| build_gn.patch | ||
| dcheck.patch | ||
| deps_add_missing_handlescope_in_fieldtype_printto.patch | ||
| deps_backport_detailed_line_info_for_cpu_profiler.patch | ||
| deps_cherry-pick_0dd3390_from_upstream_v8.patch | ||
| deps_cherry-pick_09bca09_from_upstream_v8.patch | ||
| deps_cherry-pick_2363cdf_from_upstream_v8.patch | ||
| deps_cherry-pick_a8f6869_from_upstream_v8.patch | ||
| deps_cherry-pick_ba752ea_from_upstream_v8.patch | ||
| deps_cherry-pick_bf5ea81_from_upstream_v8.patch | ||
| deps_cherry-pick_c608122_from_upstream_v8.patch | ||
| deps_cherry-pick_dbfcc48_from_upstream_v8.patch | ||
| deps_cherry-pick_e1a7699_from_upstream_v8.patch | ||
| disable-warning-win.patch | ||
| do_not_run_arm_arm64_mksnapshot_binaries.patch | ||
| export_platform.patch | ||
| expose_mksnapshot.patch | ||
| ostreams.patch | ||
| README.md | ||
Exporting node's patches to v8
$ cd third_party/electron_node
$ CURRENT_NODE_VERSION=vX.Y.Z # e.g. v10.11.0
# Find the last commit with the message "deps: update V8 to <some version>"
# This commit corresponds to node resetting V8 to its pristine upstream
# state at the stated version.
$ LAST_V8_UPDATE="$(git log --grep='^deps: update V8' --format='%H' -1 deps/v8)"
# This creates a patch file containing all changes in deps/v8 from
# $LAST_V8_UPDATE up to the current node version, formatted in a way that
# it will apply cleanly to the V8 repository (i.e. with `deps/v8`
# stripped off the path and excluding the v8/gypfiles directory, which
# isn't present in V8.
$ git format-patch \
--relative=deps/v8 \
$LAST_V8_UPDATE..$CURRENT_NODE_VERSION \
deps/v8 \
':(exclude)deps/v8/gypfiles' \
--stdout
When upgrading to a new version of node, make sure to match node's patches to
v8 by removing all the deps_* patches and re-exporting node's v8 patches
using the process above.