82a59d9894
* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition https://github.com/nodejs/node/pull/57023 * tools: enable linter in test/fixtures/test\-runner/output https://github.com/nodejs/node/pull/57698 * src: improve thread safety of TaskQueue https://github.com/nodejs/node/pull/57910 * buffer: define global v8::CFunction objects as const https://github.com/nodejs/node/pull/57676 * src: disable abseil deadlock detection https://github.com/nodejs/node/pull/57582 * zlib: fix pointer alignment https://github.com/nodejs/node/pull/57727 * chore: fixup patch indices * src: set default config as node.config.json https://github.com/nodejs/node/pull/57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> https://github.com/nodejs/node/pull/57578 * test: disable chmod tests failing in Docker https://github.com/nodejs/node/issues/58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
59 lines
2.4 KiB
Diff
59 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Omer Katz <omerkatz@chromium.org>
|
|
Date: Thu, 19 Sep 2024 10:50:09 +0200
|
|
Subject: cli: remove deprecated V8 flag
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Remove the `--huge-max-old-generation-size` V8 flag from the
|
|
`NODE_OPTIONS` allowlist. That flag was recently deprecated (it
|
|
currently remains as nop, see crrev.com/c/5831467) and will soon be
|
|
completely removed.
|
|
|
|
PR-URL: https://github.com/nodejs/node/pull/54761
|
|
Reviewed-By: Richard Lau <rlau@redhat.com>
|
|
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
|
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
|
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
|
|
|
diff --git a/doc/api/cli.md b/doc/api/cli.md
|
|
index 6f984926a62973ba36bd3c27cc39b01f2bcac819..121d8f2bbd2b1d93067a06a902b1e7b986bcdb49 100644
|
|
--- a/doc/api/cli.md
|
|
+++ b/doc/api/cli.md
|
|
@@ -3404,7 +3404,6 @@ V8 options that are allowed are:
|
|
* `--disallow-code-generation-from-strings`
|
|
* `--enable-etw-stack-walking`
|
|
* `--expose-gc`
|
|
-* `--huge-max-old-generation-size`
|
|
* `--interpreted-frames-native-stack`
|
|
* `--jitless`
|
|
* `--max-old-space-size`
|
|
diff --git a/src/node_options.cc b/src/node_options.cc
|
|
index bb1e80ece4158dfed1b8bab7dc6d00dd56505aac..a9500716f2a955fc591628a969c5fba40783a2e7 100644
|
|
--- a/src/node_options.cc
|
|
+++ b/src/node_options.cc
|
|
@@ -992,11 +992,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
|
|
"disallow eval and friends",
|
|
V8Option{},
|
|
kAllowedInEnvvar);
|
|
- AddOption("--huge-max-old-generation-size",
|
|
- "increase default maximum heap size on machines with 16GB memory "
|
|
- "or more",
|
|
- V8Option{},
|
|
- kAllowedInEnvvar);
|
|
AddOption("--jitless",
|
|
"disable runtime allocation of executable memory",
|
|
V8Option{},
|
|
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
|
|
index c5d74f40e7894980b45713c77cc36f836be73528..53bca572c3405c0357f868aae71fc2c82d973c04 100644
|
|
--- a/test/parallel/test-cli-node-options.js
|
|
+++ b/test/parallel/test-cli-node-options.js
|
|
@@ -76,7 +76,6 @@ if (common.hasCrypto) {
|
|
expect('--abort_on-uncaught_exception', 'B\n');
|
|
expect('--disallow-code-generation-from-strings', 'B\n');
|
|
expect('--expose-gc', 'B\n');
|
|
-expect('--huge-max-old-generation-size', 'B\n');
|
|
expect('--jitless', 'B\n');
|
|
expect('--max-old-space-size=0', 'B\n');
|
|
expect('--max-semi-space-size=0', 'B\n');
|