
* chore: update to Node.js v18
* child_process: improve argument validation
https://github.com/nodejs/node/pull/41305
* bootstrap: support configure-time user-land snapshot
https://github.com/nodejs/node/pull/42466
* chore: update GN patch
* src: disambiguate terms used to refer to builtins and addons
https://github.com/nodejs/node/pull/44135
* src: use a typed array internally for process._exiting
https://github.com/nodejs/node/pull/43883
* chore: lib/internal/bootstrap -> lib/internal/process
* src: disambiguate terms used to refer to builtins and addons
https://github.com/nodejs/node/pull/44135
* chore: remove redudant browserGlobals patch
* chore: update BoringSSL patch
* src: allow embedder-provided PageAllocator in NodePlatform
https://github.com/nodejs/node/pull/38362
* chore: fixup Node.js crypto tests
- https://github.com/nodejs/node/pull/44171
- https://github.com/nodejs/node/pull/41600
* lib: add Promise methods to avoid-prototype-pollution lint rule
https://github.com/nodejs/node/pull/43849
* deps: update V8 to 10.1
https://github.com/nodejs/node/pull/42657
* src: add kNoBrowserGlobals flag for Environment
https://github.com/nodejs/node/pull/40532
* chore: consolidate asar initialization patches
* deps: update V8 to 10.1
https://github.com/nodejs/node/pull/42657
* deps: update V8 to 9.8
https://github.com/nodejs/node/pull/41610
* src,crypto: remove AllocatedBuffers from crypto_spkac
https://github.com/nodejs/node/pull/40752
* build: enable V8's shared read-only heap
https://github.com/nodejs/node/pull/42809
* src: fix ssize_t error from nghttp2.h
https://github.com/nodejs/node/pull/44393
* chore: fixup ESM patch
* chore: fixup patch indices
* src: merge NativeModuleEnv into NativeModuleLoader
https://github.com/nodejs/node/pull/43824
* [API] Pass OOMDetails to OOMErrorCallback
3647827
* src: iwyu in cleanup_queue.cc
* src: return Maybe from a couple of functions
https://github.com/nodejs/node/pull/39603
* src: clean up embedder API
https://github.com/nodejs/node/pull/35897
* src: refactor DH groups to delete crypto_groups.h
https://github.com/nodejs/node/pull/43896
* deps,src: use SIMD for normal base64 encoding
https://github.com/nodejs/node/pull/39775
* chore: remove deleted source file
* chore: update patches
* chore: remove deleted source file
* lib: add fetch
https://github.com/nodejs/node/pull/41749
* chore: remove nonexistent node specs
* test: split report OOM tests
https://github.com/nodejs/node/pull/44389
* src: trace fs async api
https://github.com/nodejs/node/pull/44057
* http: trace http request / response
https://github.com/nodejs/node/pull/44102
* test: split test-crypto-dh.js
https://github.com/nodejs/node/pull/40451
* crypto: introduce X509Certificate API
https://github.com/nodejs/node/pull/36804
* src: split property helpers from node::Environment
https://github.com/nodejs/node/pull/44056
* https://github.com/nodejs/node/pull/38905
bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob
* lib,src: implement WebAssembly Web API
https://github.com/nodejs/node/pull/42701
* fixup! deps,src: use SIMD for normal base64 encoding
* fixup! src: refactor DH groups to delete crypto_groups.h
* chore: fixup base64 GN file
* fix: check that node::InitializeContext() returns true
* chore: delete _noBrowserGlobals usage
* chore: disable fetch in renderer procceses
* dns: default to verbatim=true in dns.lookup()
https://github.com/nodejs/node/pull/39987
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
61 lines
2.8 KiB
Diff
61 lines
2.8 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Shelley Vohr <shelley.vohr@gmail.com>
|
|
Date: Sun, 23 Oct 2022 23:36:19 +0200
|
|
Subject: fix: prevent changing FunctionTemplateInfo after publish
|
|
|
|
Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147
|
|
|
|
Fixes an issue where Node.js would try to call SetClassName on a
|
|
FunctionTemplate twice in some cases. The above CL made it so that
|
|
V8 CHECKs when this occurs. It is fixed by ensuring SetClassName
|
|
is only called once.
|
|
|
|
This should be upstreamed.
|
|
|
|
diff --git a/src/histogram.cc b/src/histogram.cc
|
|
index 3a3228ddc9eb6b53efc0721466479a9f62cd8967..175a67840348ca507d6e8b29835e5ab3b6d3e71a 100644
|
|
--- a/src/histogram.cc
|
|
+++ b/src/histogram.cc
|
|
@@ -340,8 +340,9 @@ void HistogramBase::RegisterExternalReferences(
|
|
}
|
|
|
|
void HistogramBase::Initialize(Environment* env, Local<Object> target) {
|
|
- SetConstructorFunction(
|
|
- env->context(), target, "Histogram", GetConstructorTemplate(env));
|
|
+ SetConstructorFunction(env->context(), target, "Histogram",
|
|
+ GetConstructorTemplate(env),
|
|
+ SetConstructorFunctionFlag::NONE);
|
|
}
|
|
|
|
BaseObjectPtr<BaseObject> HistogramBase::HistogramTransferData::Deserialize(
|
|
@@ -367,6 +368,7 @@ Local<FunctionTemplate> IntervalHistogram::GetConstructorTemplate(
|
|
Isolate* isolate = env->isolate();
|
|
tmpl = NewFunctionTemplate(isolate, nullptr);
|
|
tmpl->Inherit(HandleWrap::GetConstructorTemplate(env));
|
|
+ tmpl->SetClassName(OneByteString(isolate, "Histogram"));
|
|
tmpl->InstanceTemplate()->SetInternalFieldCount(
|
|
HistogramBase::kInternalFieldCount);
|
|
SetProtoMethodNoSideEffect(isolate, tmpl, "count", GetCount);
|
|
diff --git a/src/node_messaging.cc b/src/node_messaging.cc
|
|
index f88270fc75de91610a973c0649e1bc699c3e014d..e47f7a597a6ca0cfd71fec1e42f0fbb75cb539c7 100644
|
|
--- a/src/node_messaging.cc
|
|
+++ b/src/node_messaging.cc
|
|
@@ -1467,13 +1467,16 @@ static void InitMessaging(Local<Object> target,
|
|
t->Inherit(BaseObject::GetConstructorTemplate(env));
|
|
t->InstanceTemplate()->SetInternalFieldCount(
|
|
JSTransferable::kInternalFieldCount);
|
|
- SetConstructorFunction(context, target, "JSTransferable", t);
|
|
+ t->SetClassName(OneByteString(isolate, "JSTransferable"));
|
|
+ SetConstructorFunction(context, target, "JSTransferable", t,
|
|
+ SetConstructorFunctionFlag::NONE);
|
|
}
|
|
|
|
SetConstructorFunction(context,
|
|
target,
|
|
env->message_port_constructor_string(),
|
|
- GetMessagePortConstructorTemplate(env));
|
|
+ GetMessagePortConstructorTemplate(env),
|
|
+ SetConstructorFunctionFlag::NONE);
|
|
|
|
// These are not methods on the MessagePort prototype, because
|
|
// the browser equivalents do not provide them.
|