ab24a1e36d
* Introduce `net.{start|stop}Logging()`
- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls
* Add `net.isLogging` & optional callback param for `net.stopLogging()`
* Fix small regression on --log-net-log
--log-net-log should work again
* Error on empty file path
* Only start with valid file path
* Remove unused var
* Allow setting log file path before URLRequestContextGetter starts logging
* Add net log tests
* Remove redundant checks
* Use brightray::NetLog
* Clean up code
* Should automatically stop listening
* 🎨 Attempt to fix styles
* Only run non-null callback
* Dump file to tmpdir
* Simplify net log spec
Spawned Electron process on Linux CI can fail to launch
* Separate netLog module
* Remove net logging test from net spec
* Add tests for netLog
* Fix header guard
* Clean up code
* Add netLog.currentlyLoggingPath
* Callback with filepath
* Add test for case when only .stopLogging() is called
* Add docs
* Reintroduce error on invalid arg
* Update copyright
* Update error message
* Juggle file path string types
90 lines
2.5 KiB
C++
90 lines
2.5 KiB
C++
// Copyright (c) 2018 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/browser/api/atom_api_net_log.h"
|
|
#include "atom/browser/atom_browser_client.h"
|
|
#include "atom/common/native_mate_converters/callback.h"
|
|
#include "atom/common/native_mate_converters/file_path_converter.h"
|
|
#include "base/callback.h"
|
|
#include "content/public/common/content_switches.h"
|
|
#include "native_mate/dictionary.h"
|
|
#include "native_mate/handle.h"
|
|
|
|
#include "atom/common/node_includes.h"
|
|
|
|
namespace atom {
|
|
|
|
namespace api {
|
|
|
|
NetLog::NetLog(v8::Isolate* isolate) {
|
|
Init(isolate);
|
|
|
|
net_log_ = atom::AtomBrowserClient::Get()->GetNetLog();
|
|
}
|
|
|
|
NetLog::~NetLog() {}
|
|
|
|
// static
|
|
v8::Local<v8::Value> NetLog::Create(v8::Isolate* isolate) {
|
|
return mate::CreateHandle(isolate, new NetLog(isolate)).ToV8();
|
|
}
|
|
|
|
void NetLog::StartLogging(mate::Arguments* args) {
|
|
base::FilePath log_path;
|
|
if (!args->GetNext(&log_path) || log_path.empty()) {
|
|
args->ThrowError("The first parameter must be a valid string");
|
|
return;
|
|
}
|
|
|
|
net_log_->StartDynamicLogging(log_path);
|
|
}
|
|
|
|
bool NetLog::IsCurrentlyLogging() {
|
|
return net_log_->IsDynamicLogging();
|
|
}
|
|
|
|
base::FilePath::StringType NetLog::GetCurrentlyLoggingPath() {
|
|
return net_log_->GetDynamicLoggingPath().value();
|
|
}
|
|
|
|
void NetLog::StopLogging(mate::Arguments* args) {
|
|
base::OnceClosure callback;
|
|
args->GetNext(&callback);
|
|
|
|
net_log_->StopDynamicLogging(std::move(callback));
|
|
}
|
|
|
|
// static
|
|
void NetLog::BuildPrototype(v8::Isolate* isolate,
|
|
v8::Local<v8::FunctionTemplate> prototype) {
|
|
prototype->SetClassName(mate::StringToV8(isolate, "NetLog"));
|
|
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
|
|
.SetProperty("currentlyLogging", &NetLog::IsCurrentlyLogging)
|
|
.SetProperty("currentlyLoggingPath", &NetLog::GetCurrentlyLoggingPath)
|
|
.SetMethod("startLogging", &NetLog::StartLogging)
|
|
.SetMethod("_stopLogging", &NetLog::StopLogging);
|
|
}
|
|
|
|
} // namespace api
|
|
|
|
} // namespace atom
|
|
|
|
namespace {
|
|
|
|
using atom::api::NetLog;
|
|
|
|
void Initialize(v8::Local<v8::Object> exports,
|
|
v8::Local<v8::Value> unused,
|
|
v8::Local<v8::Context> context,
|
|
void* priv) {
|
|
v8::Isolate* isolate = context->GetIsolate();
|
|
|
|
mate::Dictionary dict(isolate, exports);
|
|
dict.Set("netLog", NetLog::Create(isolate));
|
|
dict.Set("NetLog", NetLog::GetConstructor(isolate)->GetFunction());
|
|
}
|
|
|
|
} // namespace
|
|
|
|
NODE_BUILTIN_MODULE_CONTEXT_AWARE(atom_browser_net_log, Initialize)
|