ced2e8779f
* feat: Allow detection of MITM HTTPS proxies like ZScaler For security purposes, Figma heavily restrics the origins that are allowed to load within our Electron app. Unfortunately some corporate environments use MITM proxies like ZScaler, which intercepts our connection to `https://www.figma.com` and serves a redirect to e.g. `https://gateway.zscloud.net` before finally redirecting back to `https://www.figma.com`. In order to detect this situation and handle it gracefully, we need to be able to know whether or not the certificate for our own origin (`https://www.figma.com`) is chained to a known root. We do this by exposesing `CertVerifyResult::is_issued_by_known_root`. If the certification verification passed without the certificate being tied to a known root, we can safely assume that we are dealing with a MITM proxy that has its root CA installed locally on the machine. This means that HTTPS can't be trusted so we might as well make life easier for corporate users by loosening our origin restrictions without any manual steps. * Tweak docs wording
45 lines
1.4 KiB
C++
45 lines
1.4 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <utility>
|
|
|
|
#include "shell/browser/net/cert_verifier_client.h"
|
|
|
|
namespace electron {
|
|
|
|
VerifyRequestParams::VerifyRequestParams() = default;
|
|
|
|
VerifyRequestParams::~VerifyRequestParams() = default;
|
|
|
|
VerifyRequestParams::VerifyRequestParams(const VerifyRequestParams&) = default;
|
|
|
|
CertVerifierClient::CertVerifierClient(CertVerifyProc proc)
|
|
: cert_verify_proc_(proc) {}
|
|
|
|
CertVerifierClient::~CertVerifierClient() = default;
|
|
|
|
void CertVerifierClient::Verify(
|
|
int default_error,
|
|
const net::CertVerifyResult& default_result,
|
|
const scoped_refptr<net::X509Certificate>& certificate,
|
|
const std::string& hostname,
|
|
int flags,
|
|
const absl::optional<std::string>& ocsp_response,
|
|
VerifyCallback callback) {
|
|
VerifyRequestParams params;
|
|
params.hostname = hostname;
|
|
params.default_result = net::ErrorToString(default_error);
|
|
params.error_code = default_error;
|
|
params.certificate = certificate;
|
|
params.validated_certificate = default_result.verified_cert;
|
|
params.is_issued_by_known_root = default_result.is_issued_by_known_root;
|
|
cert_verify_proc_.Run(
|
|
params,
|
|
base::BindOnce(
|
|
[](VerifyCallback callback, const net::CertVerifyResult& result,
|
|
int err) { std::move(callback).Run(err, result); },
|
|
std::move(callback), default_result));
|
|
}
|
|
|
|
} // namespace electron
|