a99c193cf2
Currently, when calling `copyFileOut`, the original extension from the
file is lost, and a generic `*.tmp` is added instead.
This becomes problematic in the scenario where we use
`child_process.execFile` on a Windows Batch script that lives inside the
`asar` package.
Windows relies on the extension being present in order to interpret the
script accordingly, which results in the following bug because the
operating system doesn't know what do to with this `*.tmp` file:
```
Error: spawn UNKNOWN
```
Steps to reproduce:
1. Create a dummy batch script (test.bat):
```
@echo off
echo "Hello world"
```
2. Create an electron app that attemps to call this script with
`child_process.execFile`:
```js
var child_process = require('child_process');
var path = require('path');
child_process.execFile(path.join(__dirname, 'test.bat'), function(error, stdout) {
if (error) throw error;
console.log(stdout);
});
```
3. Package this small application as an asar archive:
```sh
> asar pack mytestapp app.asar
```
4. Execute the application:
```sh
> electron.exe app.asar
```
68 lines
1.7 KiB
C++
68 lines
1.7 KiB
C++
// Copyright (c) 2014 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/common/asar/scoped_temporary_file.h"
|
|
|
|
#include <vector>
|
|
|
|
#include "base/files/file_util.h"
|
|
#include "base/threading/thread_restrictions.h"
|
|
|
|
namespace asar {
|
|
|
|
ScopedTemporaryFile::ScopedTemporaryFile() {
|
|
}
|
|
|
|
ScopedTemporaryFile::~ScopedTemporaryFile() {
|
|
if (!path_.empty()) {
|
|
base::ThreadRestrictions::ScopedAllowIO allow_io;
|
|
// On Windows it is very likely the file is already in use (because it is
|
|
// mostly used for Node native modules), so deleting it now will halt the
|
|
// program.
|
|
#if defined(OS_WIN)
|
|
base::DeleteFileAfterReboot(path_);
|
|
#else
|
|
base::DeleteFile(path_, false);
|
|
#endif
|
|
}
|
|
}
|
|
|
|
bool ScopedTemporaryFile::Init(const base::FilePath::StringType ext) {
|
|
if (!path_.empty())
|
|
return true;
|
|
|
|
base::ThreadRestrictions::ScopedAllowIO allow_io;
|
|
|
|
base::FilePath temporaryPath_;
|
|
if (!base::CreateTemporaryFile(&temporaryPath_)) {
|
|
return false;
|
|
}
|
|
|
|
path_ = temporaryPath_.AddExtension(ext);
|
|
return base::Move(temporaryPath_, path_);
|
|
}
|
|
|
|
bool ScopedTemporaryFile::InitFromFile(base::File* src,
|
|
const base::FilePath::StringType ext,
|
|
uint64 offset, uint64 size) {
|
|
if (!src->IsValid())
|
|
return false;
|
|
|
|
if (!Init(ext))
|
|
return false;
|
|
|
|
std::vector<char> buf(size);
|
|
int len = src->Read(offset, buf.data(), buf.size());
|
|
if (len != static_cast<int>(size))
|
|
return false;
|
|
|
|
base::File dest(path_, base::File::FLAG_OPEN | base::File::FLAG_WRITE);
|
|
if (!dest.IsValid())
|
|
return false;
|
|
|
|
return dest.WriteAtCurrentPos(buf.data(), buf.size()) ==
|
|
static_cast<int>(size);
|
|
}
|
|
|
|
} // namespace asar
|