electron/atom/common/crash_reporter
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
linux chore: breakpad #include compatibility between GN and GYP 2018-07-09 16:53:06 -07:00
win chore: [gn] remove vendor/ from windows include paths (#13432) 2018-06-26 15:03:56 +10:00
crash_reporter.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
crash_reporter.h add new method and mark setExtraParameter for deprecation 2017-11-01 21:57:43 -04:00
crash_reporter_linux.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
crash_reporter_linux.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
crash_reporter_mac.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
crash_reporter_mac.mm Fix up #includes to work with both GYP and GN 2018-05-10 13:38:40 -07:00
crash_reporter_win.cc Fix code triggering new -Wmicrosoft-cast warning in M67 2018-09-11 20:24:03 +02:00
crash_reporter_win.h build: [gn] working on 32bit windows 2018-07-19 17:04:44 -07:00