![electron-roller[bot]](/assets/img/avatar_default.png)
* chore: bump chromium in DEPS to 106.0.5247.1 * chore: update can_create_window.patch Xref:3805043
content/renderer/render_view_impl.cc was removed * chore: update patches/chromium/printing.patch Normal code shear. * chore: update patches/chromium/add_contentgpuclient_precreatemessageloop_callback.patch Xref:3764862
fix minor code shear that caused the patch to not apply * chore: update patches/chromium/picture-in-picture.patch Xref:3781646
Normal code shear. * chore: update patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch Xref:3805043
content/renderer/render_view_impl.cc was removed Xref:3792324
Normal code shear. * chore: update patches/chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch Normal code shear. * chore: update patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch Xref:3798548
Normal code shear. * chore: update patches/chromium/build_disable_print_content_analysis.patch Xref:3810473
Normal code shear. * chore: short-circuit_permissions_checks_in_mediastreamdevicescontroller.patch Xref:3807504
Normal code shear. * chore: update patches * chore: bump chromium in DEPS to 106.0.5249.0 * chore: bump chromium in DEPS to 107.0.5250.0 * chore: bump chromium in DEPS to 107.0.5252.0 * chore: bump chromium in DEPS to 107.0.5254.0 * chore: bump chromium in DEPS to 107.0.5256.1 * chore: update v8 patches * chore: update chromium patches * [CodeHealthRotation] base::Value::Dict (v2) migration for //c/b/ui/zoom Refs3778239
* Add support for snapped window states for lacros3810538
* webui: Migrate /chrome/browser/ui/webui URLDataSources to GetMimeType(GURL) Refs3774560
* Provide explicit template arguments to blink::AssociatedInterfaceRegistry::AddInterface Refs3773459
* Make WebScriptExecutionCallback base::OnceCallback Refs3676532
3724623
3675752
* Add implementation of reduce accept language service Refs3687391
* Add PermissionResult in //content/public. Refs3807504
* [Extensions] Add new Webstore domain to extension URLs and clients Refs3793043
* chore: update node patches * chore: fix lint * chore: update filenames.libcxx.gni * fixup! Make WebScriptExecutionCallback base::OnceCallback * chore: bump chromium in DEPS to 107.0.5266.1 * chore: bump chromium in DEPS to 107.0.5268.0 * chore: bump chromium in DEPS to 107.0.5270.1 * chore: update patches * 3848842: [DevTools] Added 'printing-in-progress' error code. https://chromium-review.googlesource.com/c/chromium/src/+/38488 * 3855766: PA: Move the allocator shim files into partition_allocator/shim/ |3855766
* Change gfx::Rect to blink::mojom::WindowFeatures in AddNewContents and some related functions.3835666
* Use base::FunctionRef for the various ForEachRenderFrameHost helpers.3767487
* [loader] Send cached metadata as part of OnReceiveResponse3811219
* 3832927: [json-schema-compiler] Support abs::optional<int>3832927
* Use unique_ptr for BrowserPluginGuestDelegate::CreateNewGuestWindow3847070
* 3847044: [Android] Dismiss select popup upon entering fullscreen3847044
* chore: update patches * chore: add missing header * Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 123804581
* 3786946: cast pwrite64 arg to long to avoid compilation error on arm3786946
* chore: update patches after rebase * 3846114: float: Implement for lacros p2.3846114
* 3825237: Enable -Wunqualified-std-cast-call3825237
* chore: bump chromium in DEPS to 107.0.5272.0 * chore: update patches * 3835746: Rename PepperPluginInfo to ContentPluginInfo3835746
* 3852542: Plumb drag-image rect from blink to browser to RenderWidgetHostImpl3852542
* 3826169: [json-schema-compiler] Support abs::optional<bool>3826169
Also 3840687: [json-schema-compiler] Support abs::optional<double>3840687
* 3857319: Reland "Remove PrefService::Get"3857319
* 3854614: Rework LinuxUi ownership and creation3854614
* chore: bump chromium in DEPS to 107.0.5274.0 * 3866104: [DownloadBubble] Change download notifications in exclusive_access3866104
* chore: update patches * chore: disable optimization guide for preconnect feature * 3860569: Enable -Wshadow on Linux.3860569
* chore: update patches after rebase * fixup: update to accomodate Wc++98-compat-extra-semi flag * Revert "fixup! Make WebScriptExecutionCallback base::OnceCallback" This reverts commit 0866fe8648671f04e4ea45ceed85db6e4a3b260b. * fixup! Make WebScriptExecutionCallback base::OnceCallback * fixup! Make WebScriptExecutionCallback base::OnceCallback * 3840937: [sandbox] Merge V8_SANDBOXED_POINTERS into V8_ENABLE_SANDBOX3840937
* fixup! chore: update can_create_window.patch * chore: update patches * 53946: Track SSL_ERROR_ZERO_RETURN explicitly. https://boringssl-review.googlesource.com/c/boringssl/+/53946 * fixup: Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 123804581
* 3805932: [headless] Added print compositor support for OOPIF printing.3805932
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
80 lines
3.8 KiB
Diff
80 lines
3.8 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Samuel Attard <samuel.r.attard@gmail.com>
|
|
Date: Thu, 18 Oct 2018 17:07:27 -0700
|
|
Subject: isolate_holder.patch
|
|
|
|
Pass pre allocated isolate for initialization, node platform
|
|
needs to register on an isolate so that it can be used later
|
|
down in the initialization process of an isolate.
|
|
|
|
Specifically, v8::Isolate::Initialize ends up calling
|
|
NodePlatform::GetForegroundTaskRunner, which requires that the
|
|
isolate has previously been registered with NodePlatform::RegisterIsolate.
|
|
However, if we let gin allocate the isolate, there's no opportunity
|
|
for us to register the isolate in between Isolate::Allocate and
|
|
Isolate::Initialize.
|
|
|
|
diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc
|
|
index c254b045494936eca14ce947e1c2de3327820aa2..63c9b9681fcc4e1e9a9590d59d74349bb8aee3b1 100644
|
|
--- a/gin/isolate_holder.cc
|
|
+++ b/gin/isolate_holder.cc
|
|
@@ -73,7 +73,8 @@ IsolateHolder::IsolateHolder(
|
|
IsolateType isolate_type,
|
|
IsolateCreationMode isolate_creation_mode,
|
|
v8::CreateHistogramCallback create_histogram_callback,
|
|
- v8::AddHistogramSampleCallback add_histogram_sample_callback)
|
|
+ v8::AddHistogramSampleCallback add_histogram_sample_callback,
|
|
+ v8::Isolate* isolate)
|
|
: IsolateHolder(task_runner,
|
|
access_mode,
|
|
isolate_type,
|
|
@@ -81,14 +82,16 @@ IsolateHolder::IsolateHolder(
|
|
atomics_wait_mode,
|
|
create_histogram_callback,
|
|
add_histogram_sample_callback),
|
|
- isolate_creation_mode) {}
|
|
+ isolate_creation_mode,
|
|
+ isolate) {}
|
|
|
|
IsolateHolder::IsolateHolder(
|
|
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
|
|
AccessMode access_mode,
|
|
IsolateType isolate_type,
|
|
std::unique_ptr<v8::Isolate::CreateParams> params,
|
|
- IsolateCreationMode isolate_creation_mode)
|
|
+ IsolateCreationMode isolate_creation_mode,
|
|
+ v8::Isolate* isolate)
|
|
: access_mode_(access_mode), isolate_type_(isolate_type) {
|
|
CHECK(Initialized())
|
|
<< "You need to invoke gin::IsolateHolder::Initialize first";
|
|
@@ -99,7 +102,7 @@ IsolateHolder::IsolateHolder(
|
|
v8::ArrayBuffer::Allocator* allocator = params->array_buffer_allocator;
|
|
DCHECK(allocator);
|
|
|
|
- isolate_ = v8::Isolate::Allocate();
|
|
+ isolate_ = isolate ? isolate : v8::Isolate::Allocate();
|
|
isolate_data_ = std::make_unique<PerIsolateData>(isolate_, allocator,
|
|
access_mode_, task_runner);
|
|
// TODO(https://crbug.com/1347092): Refactor such that caller need not
|
|
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
|
|
index f8e5d0246b92fd2f1316313e13ccda7ef6c57495..196e030be4ba5bb5f04aaef0acf8cabe0de93a67 100644
|
|
--- a/gin/public/isolate_holder.h
|
|
+++ b/gin/public/isolate_holder.h
|
|
@@ -83,13 +83,15 @@ class GIN_EXPORT IsolateHolder {
|
|
IsolateType isolate_type,
|
|
IsolateCreationMode isolate_creation_mode = IsolateCreationMode::kNormal,
|
|
v8::CreateHistogramCallback create_histogram_callback = nullptr,
|
|
- v8::AddHistogramSampleCallback add_histogram_sample_callback = nullptr);
|
|
+ v8::AddHistogramSampleCallback add_histogram_sample_callback = nullptr,
|
|
+ v8::Isolate* isolate = nullptr);
|
|
IsolateHolder(
|
|
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
|
|
AccessMode access_mode,
|
|
IsolateType isolate_type,
|
|
std::unique_ptr<v8::Isolate::CreateParams> params,
|
|
- IsolateCreationMode isolate_creation_mode = IsolateCreationMode::kNormal);
|
|
+ IsolateCreationMode isolate_creation_mode = IsolateCreationMode::kNormal,
|
|
+ v8::Isolate* isolate = nullptr);
|
|
IsolateHolder(const IsolateHolder&) = delete;
|
|
IsolateHolder& operator=(const IsolateHolder&) = delete;
|
|
~IsolateHolder();
|