9c019b6147
* chore: bump chromium in DEPS to 136.0.7076.0 * chore: bump chromium in DEPS to 136.0.7077.0 * 6368856: Migrate absl variant.h and utility.h in content (part 2/2) |6368856* 6356528: Clean up LegacyRenderWidgetHostHWND code |6356528* chore: export patches * 6339113: [Viewport Segments] Add CDP commands to override Viewport Segments without overriding other device properties. |6339113* 6352169: [DevTools][MultiInstance] Support new tab in another window on Android |6352169* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) |6368856* 6360858:Clickiness: Wire response from URLLoader to DB, add e2e tests|6360858* chore: bump chromium in DEPS to 136.0.7079.0 * chore: export patches * chore: bump chromium in DEPS to 136.0.7081.0 * chore: export patches * chore: bump chromium in DEPS to 136.0.7083.0 * 6361987: Remove double-declaration with gfx::NativeView and gfx::NativeWindow |6361987* chore: export patches * chore: bump chromium in DEPS to 136.0.7087.0 * chore: export patches * fix: include node patch for missing AtomicsWaitEvent6385540* build: add depot_tools python to path * fix: cppgc init and unregistering v8 isolate6333562CppGc is now initialized earlier so Node can skip reinitializing it. Additionally, gin::IsolateHandle was attempting to destruct an already destructed v8::Isolate upon electron::JavaScriptEnvironment destruction. By removing the call to NodePlatform::UnregisterIsolate, this fixes the crash on app shutdown. * fix: unregister isolate after destruction See code comment. * chore: bump chromium in DEPS to 136.0.7095.0 * chore: sync patches * fix: add script_parsing::ContentScriptType parameter6298395* fix: migrate content::BrowserAccessibilityState methods64014376383275* feat: enableHappyEyeballs option for host resolver6332599* fix: add new cookie exclusion reason6343479* fix: add new url loader method6337340* fix: add new cppgc header file for electron_node headers6348644* fix: disable CREL on Linux ARM64 https://chromium-review.googlesource.com/q/I3a62f02f564f07be63173b0773b4ecaffbe939b9 * fixup! fix: add new cppgc header file for electron_node headers6348644* chore: update corner smoothing patch * fixup! chore: update corner smoothing patch * chore: disable NAN weak tests These two tests are incompatible with a V8 change that disallows running JS code from a weak finalizer callback. Ref:4733273* test: fix task starvation in node test A V8 change makes these contexts get collected in a task that is posted and run asynchronously. The tests were synchronously GC'ing in an infinite loop, preventing the task loop from running the task that would GC these contexts. This change should be upstreamed in some way. Ref:4733273--------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: alice <alice@makenotion.com> Co-authored-by: Samuel Maddock <smaddock@slack-corp.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: clavin <clavin@electronjs.org>
29 lines
1.5 KiB
Diff
29 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Keeley Hammond <khammond@slack-corp.com>
|
|
Date: Wed, 19 Feb 2025 11:18:44 -0800
|
|
Subject: fix: re-enable synchronous spellcheck on Windows
|
|
|
|
This fix partially reverts 6109477: Code Health:
|
|
Clean up stale base::Feature "WinRetrieveSuggestionsOnlyOnDemand"
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/6109477
|
|
by re-adding a synchronous call to FillSuggestionList.
|
|
|
|
This patch can be removed when an asynchronous spellcheck API
|
|
option is added to Electron.
|
|
|
|
diff --git a/components/spellcheck/browser/windows_spell_checker.cc b/components/spellcheck/browser/windows_spell_checker.cc
|
|
index 7b78720e8d25a3dee4821c816bd9629b1526e50a..be89b74fd85983e63c983aec0d10036ce1ca63df 100644
|
|
--- a/components/spellcheck/browser/windows_spell_checker.cc
|
|
+++ b/components/spellcheck/browser/windows_spell_checker.cc
|
|
@@ -240,6 +240,11 @@ std::vector<SpellCheckResult> BackgroundHelper::RequestTextCheckForAllLanguages(
|
|
(action == CORRECTIVE_ACTION_GET_SUGGESTIONS ||
|
|
action == CORRECTIVE_ACTION_REPLACE)) {
|
|
std::vector<std::u16string> suggestions;
|
|
+ // TODO (vertedinde): Perform the synchronous operation of retrieving
|
|
+ // suggestions for all misspelled words while performing a text check.
|
|
+ FillSuggestionList(it->first,
|
|
+ text.substr(start_index, error_length),
|
|
+ &suggestions);
|
|
result_map[std::tuple<ULONG, ULONG>(start_index, error_length)]
|
|
.push_back(suggestions);
|
|
}
|