121 lines
5.1 KiB
Diff
121 lines
5.1 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Anonymous <anonymous@electronjs.org>
|
|
Date: Thu, 20 Sep 2018 17:46:53 -0700
|
|
Subject: web_contents.patch
|
|
|
|
|
|
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
|
index 9f68ff38beffa5840fc3f037df2d4a71f0cbc36a..f38b9d34f8c29658af6120d5422acb635fd1539c 100644
|
|
--- a/content/browser/web_contents/web_contents_impl.cc
|
|
+++ b/content/browser/web_contents/web_contents_impl.cc
|
|
@@ -2071,6 +2071,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
|
|
std::string unique_name;
|
|
frame_tree_.root()->SetFrameName(params.main_frame_name, unique_name);
|
|
|
|
+ if (params.view && params.delegate_view) {
|
|
+ view_.reset(params.view);
|
|
+ render_view_host_delegate_view_ = params.delegate_view;
|
|
+ }
|
|
+
|
|
+ if (!view_) {
|
|
WebContentsViewDelegate* delegate =
|
|
GetContentClient()->browser()->GetWebContentsViewDelegate(this);
|
|
|
|
@@ -2086,6 +2092,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
|
|
&render_view_host_delegate_view_);
|
|
}
|
|
}
|
|
+ } // !view_
|
|
CHECK(render_view_host_delegate_view_);
|
|
CHECK(view_.get());
|
|
|
|
diff --git a/content/browser/web_contents/web_contents_view_guest.cc b/content/browser/web_contents/web_contents_view_guest.cc
|
|
index ecaf30bcb7b916a92a69641dd7b96a3633d407c0..0af625928ca6227a21cd4263a14a42b72095399c 100644
|
|
--- a/content/browser/web_contents/web_contents_view_guest.cc
|
|
+++ b/content/browser/web_contents/web_contents_view_guest.cc
|
|
@@ -68,19 +68,27 @@ gfx::NativeWindow WebContentsViewGuest::GetTopLevelNativeWindow() const {
|
|
|
|
void WebContentsViewGuest::OnGuestAttached(WebContentsView* parent_view) {
|
|
#if defined(USE_AURA)
|
|
+ if (!platform_view_->GetNativeView())
|
|
+ return;
|
|
// In aura, ScreenPositionClient doesn't work properly if we do
|
|
// not have the native view associated with this WebContentsViewGuest in the
|
|
// view hierarchy. We add this view as embedder's child here.
|
|
// This would go in WebContentsViewGuest::CreateView, but that is too early to
|
|
// access embedder_web_contents(). Therefore, we do it here.
|
|
- parent_view->GetNativeView()->AddChild(platform_view_->GetNativeView());
|
|
+ if (parent_view->GetNativeView() != platform_view_->GetNativeView()) {
|
|
+ parent_view->GetNativeView()->AddChild(platform_view_->GetNativeView());
|
|
+ }
|
|
#endif // defined(USE_AURA)
|
|
}
|
|
|
|
void WebContentsViewGuest::OnGuestDetached(WebContentsView* old_parent_view) {
|
|
#if defined(USE_AURA)
|
|
- old_parent_view->GetNativeView()->RemoveChild(
|
|
- platform_view_->GetNativeView());
|
|
+ if (!platform_view_->GetNativeView())
|
|
+ return;
|
|
+ if (old_parent_view->GetNativeView() != platform_view_->GetNativeView()) {
|
|
+ old_parent_view->GetNativeView()->RemoveChild(
|
|
+ platform_view_->GetNativeView());
|
|
+ }
|
|
#endif // defined(USE_AURA)
|
|
}
|
|
|
|
@@ -132,11 +140,22 @@ RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForWidget(
|
|
render_widget_host->GetView());
|
|
}
|
|
|
|
+ RenderWidgetHost* embedder_render_widget_host =
|
|
+ guest_->embedder_web_contents()->GetRenderViewHost()->GetWidget();
|
|
+ RenderWidgetHostViewBase* embedder_render_widget_host_view =
|
|
+ static_cast<RenderWidgetHostViewBase*>(
|
|
+ embedder_render_widget_host->GetView());
|
|
RenderWidgetHostViewBase* platform_widget =
|
|
- platform_view_->CreateViewForWidget(render_widget_host, true);
|
|
-
|
|
- return RenderWidgetHostViewGuest::Create(render_widget_host, guest_,
|
|
- platform_widget->GetWeakPtr());
|
|
+ embedder_render_widget_host_view->CreateViewForWidget(
|
|
+ render_widget_host,
|
|
+ embedder_render_widget_host,
|
|
+ platform_view_.get());
|
|
+ RenderWidgetHostViewGuest* guest_view = RenderWidgetHostViewGuest::Create(
|
|
+ render_widget_host, guest_, platform_widget->GetWeakPtr());
|
|
+ platform_widget->InitAsGuest(embedder_render_widget_host->GetView(),
|
|
+ guest_view);
|
|
+
|
|
+ return guest_view;
|
|
}
|
|
|
|
RenderWidgetHostViewBase* WebContentsViewGuest::CreateViewForChildWidget(
|
|
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
|
|
index 6cf2ca2a0ec5d54eeadd7581eaa2acfd83459965..498d8ed92b6ebbf863a26be91258bb9608e6f31e 100644
|
|
--- a/content/public/browser/web_contents.h
|
|
+++ b/content/public/browser/web_contents.h
|
|
@@ -75,9 +75,12 @@ class BrowserPluginGuestDelegate;
|
|
class InterstitialPage;
|
|
class RenderFrameHost;
|
|
class RenderViewHost;
|
|
+class RenderViewHostDelegateView;
|
|
class RenderWidgetHost;
|
|
class RenderWidgetHostView;
|
|
+class RenderWidgetHostViewBase;
|
|
class WebContentsDelegate;
|
|
+class WebContentsView;
|
|
struct CustomContextMenuContext;
|
|
struct DropData;
|
|
struct MHTMLGenerationParams;
|
|
@@ -213,6 +216,10 @@ class WebContents : public PageNavigator,
|
|
kInitializeAndWarmupRendererProcess,
|
|
} desired_renderer_state;
|
|
|
|
+ // Optionally specify the view and delegate view.
|
|
+ content::WebContentsView* view = nullptr;
|
|
+ content::RenderViewHostDelegateView* delegate_view = nullptr;
|
|
+
|
|
// Sandboxing flags set on the new WebContents.
|
|
blink::WebSandboxFlags starting_sandbox_flags;
|
|
|