b7b9efa875
By default the Chromedriver will send remote-debugging-port=0 to let the browser choose a free port to listen on. The chosen port is written to a known file in the user data dir that is passed to the app through the CLI. This PR does two things. 1. Correctly passes the USER_DATA_DIR to the remote debugging server so it knows where to write the file 2. Adds support for --user-data-dir as we did not support that CLI argument and Chromedriver relies on being able to tell the "browser" where to write this file. Fixes #17354
100 lines
3.3 KiB
TypeScript
100 lines
3.3 KiB
TypeScript
import * as path from 'path'
|
|
|
|
import * as electron from 'electron'
|
|
import { EventEmitter } from 'events'
|
|
|
|
const bindings = process.electronBinding('app')
|
|
const commandLine = process.electronBinding('command_line')
|
|
const { app, App } = bindings
|
|
|
|
// Only one app object permitted.
|
|
export default app
|
|
|
|
const { deprecate, Menu } = electron
|
|
|
|
let dockMenu: Electron.Menu | null = null
|
|
|
|
// App is an EventEmitter.
|
|
Object.setPrototypeOf(App.prototype, EventEmitter.prototype)
|
|
EventEmitter.call(app as any)
|
|
|
|
Object.assign(app, {
|
|
// TODO(codebytere): remove in 7.0
|
|
setApplicationMenu (menu: Electron.Menu | null) {
|
|
return Menu.setApplicationMenu(menu)
|
|
},
|
|
// TODO(codebytere): remove in 7.0
|
|
getApplicationMenu () {
|
|
return Menu.getApplicationMenu()
|
|
},
|
|
commandLine: {
|
|
hasSwitch: (theSwitch: string) => commandLine.hasSwitch(String(theSwitch)),
|
|
getSwitchValue: (theSwitch: string) => commandLine.getSwitchValue(String(theSwitch)),
|
|
appendSwitch: (theSwitch: string, value?: string) => commandLine.appendSwitch(String(theSwitch), typeof value === 'undefined' ? value : String(value)),
|
|
appendArgument: (arg: string) => commandLine.appendArgument(String(arg))
|
|
} as Electron.CommandLine,
|
|
enableMixedSandbox () {
|
|
deprecate.log(`'enableMixedSandbox' is deprecated. Mixed-sandbox mode is now enabled by default. You can safely remove the call to enableMixedSandbox().`)
|
|
}
|
|
})
|
|
|
|
// we define this here because it'd be overly complicated to
|
|
// do in native land
|
|
Object.defineProperty(app, 'applicationMenu', {
|
|
get () {
|
|
return Menu.getApplicationMenu()
|
|
},
|
|
set (menu: Electron.Menu | null) {
|
|
return Menu.setApplicationMenu(menu)
|
|
}
|
|
})
|
|
|
|
app.isPackaged = (() => {
|
|
const execFile = path.basename(process.execPath).toLowerCase()
|
|
if (process.platform === 'win32') {
|
|
return execFile !== 'electron.exe'
|
|
}
|
|
return execFile !== 'electron'
|
|
})()
|
|
|
|
app._setDefaultAppPaths = (packagePath) => {
|
|
// Set the user path according to application's name.
|
|
app.setPath('userData', path.join(app.getPath('appData'), app.getName()))
|
|
app.setPath('userCache', path.join(app.getPath('cache'), app.getName()))
|
|
app.setAppPath(packagePath)
|
|
|
|
// Add support for --user-data-dir=
|
|
const userDataDirFlag = '--user-data-dir='
|
|
const userDataArg = process.argv.find(arg => arg.startsWith(userDataDirFlag))
|
|
if (userDataArg) {
|
|
const userDataDir = userDataArg.substr(userDataDirFlag.length)
|
|
if (path.isAbsolute(userDataDir)) app.setPath('userData', userDataDir)
|
|
}
|
|
}
|
|
|
|
if (process.platform === 'darwin') {
|
|
const setDockMenu = app.dock.setMenu
|
|
app.dock.setMenu = (menu) => {
|
|
dockMenu = menu
|
|
setDockMenu(menu)
|
|
}
|
|
app.dock.getMenu = () => dockMenu
|
|
}
|
|
|
|
// Routes the events to webContents.
|
|
const events = ['login', 'certificate-error', 'select-client-certificate']
|
|
for (const name of events) {
|
|
app.on(name as 'login', (event, webContents, ...args: any[]) => {
|
|
webContents.emit(name, event, ...args)
|
|
})
|
|
}
|
|
|
|
// Function Deprecations
|
|
app.getFileIcon = deprecate.promisify(app.getFileIcon)
|
|
|
|
// Property Deprecations
|
|
deprecate.fnToProperty(app, 'accessibilitySupportEnabled', '_isAccessibilitySupportEnabled', '_setAccessibilitySupportEnabled')
|
|
|
|
// Wrappers for native classes.
|
|
const { DownloadItem } = process.electronBinding('download_item')
|
|
Object.setPrototypeOf(DownloadItem.prototype, EventEmitter.prototype)
|