863faea542
* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto https://github.com/nodejs/node/pull/54911 * crypto: add Date fields for validTo and validFrom https://github.com/nodejs/node/pull/54159 * module: fix discrepancy between .ts and .js https://github.com/nodejs/node/pull/54461 * esm: do not interpret "main" as a URL https://github.com/nodejs/node/pull/55003 * src: modernize likely/unlikely hints https://github.com/nodejs/node/pull/55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate https://github.com/nodejs/node/pull/54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods https://github.com/nodejs/node/pull/54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building https://github.com/nodejs/node/pull/55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes https://github.com/nodejs/node/pull/55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
59 lines
2.4 KiB
Diff
59 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Omer Katz <omerkatz@chromium.org>
|
|
Date: Thu, 19 Sep 2024 10:50:09 +0200
|
|
Subject: cli: remove deprecated V8 flag
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Remove the `--huge-max-old-generation-size` V8 flag from the
|
|
`NODE_OPTIONS` allowlist. That flag was recently deprecated (it
|
|
currently remains as nop, see crrev.com/c/5831467) and will soon be
|
|
completely removed.
|
|
|
|
PR-URL: https://github.com/nodejs/node/pull/54761
|
|
Reviewed-By: Richard Lau <rlau@redhat.com>
|
|
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
|
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
|
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
|
|
|
diff --git a/doc/api/cli.md b/doc/api/cli.md
|
|
index 62d3d37a061f787babe44649143d45010ce90011..1f614cabf0f31d7adff9dd7a039ca591d805d3bd 100644
|
|
--- a/doc/api/cli.md
|
|
+++ b/doc/api/cli.md
|
|
@@ -3177,7 +3177,6 @@ V8 options that are allowed are:
|
|
* `--disallow-code-generation-from-strings`
|
|
* `--enable-etw-stack-walking`
|
|
* `--expose-gc`
|
|
-* `--huge-max-old-generation-size`
|
|
* `--interpreted-frames-native-stack`
|
|
* `--jitless`
|
|
* `--max-old-space-size`
|
|
diff --git a/src/node_options.cc b/src/node_options.cc
|
|
index 6f9a8d3e0884bc6e356413f2f39522a7109c86b5..ccf740bfd631aca608244b6b3998177ca5f47f75 100644
|
|
--- a/src/node_options.cc
|
|
+++ b/src/node_options.cc
|
|
@@ -929,11 +929,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
|
|
"disallow eval and friends",
|
|
V8Option{},
|
|
kAllowedInEnvvar);
|
|
- AddOption("--huge-max-old-generation-size",
|
|
- "increase default maximum heap size on machines with 16GB memory "
|
|
- "or more",
|
|
- V8Option{},
|
|
- kAllowedInEnvvar);
|
|
AddOption("--jitless",
|
|
"disable runtime allocation of executable memory",
|
|
V8Option{},
|
|
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
|
|
index 03ffe7aa03f48156f04bb527316221ec10e7e0df..69bf136559c1a8a18a7bfc444a439d161f622635 100644
|
|
--- a/test/parallel/test-cli-node-options.js
|
|
+++ b/test/parallel/test-cli-node-options.js
|
|
@@ -72,7 +72,6 @@ if (common.hasCrypto) {
|
|
expect('--abort_on-uncaught_exception', 'B\n');
|
|
expect('--disallow-code-generation-from-strings', 'B\n');
|
|
expect('--expose-gc', 'B\n');
|
|
-expect('--huge-max-old-generation-size', 'B\n');
|
|
expect('--jitless', 'B\n');
|
|
expect('--max-old-space-size=0', 'B\n');
|
|
expect('--max-semi-space-size=0', 'B\n');
|