electron/shell/browser/ui
John Kleinschmidt 98adbbb593
chore: bump chromium to 136.0.7062.0 (#45987)
* chore: bump chromium to 135.0.7049.7 (main) (#45900)

chore: bump chromium in DEPS to 135.0.7049.7
(cherry picked from commit bb1c3dff21)

* chore: bump chromium to 136.0.7053.1 (main) (#45906)

* chore: bump chromium in DEPS to 136.0.7052.0

* chore: update mas_avoid_private_macos_api_usage.patch.patch

6318359

patch applied manually due to context shear

* chore: update preconnect_manager.patch

Xref: 6318420

patch applied manually due to context shear

* chore: e patches all

* chore: bump chromium to 136.0.7053.1

* chore: update fix_remove_profiles_from_spellcheck_service.patch

Xref: 6326575

patch applied manually due to context shear

* chore: e patches all

* chore: revert removal of v8 API used by Node.js

* devtools: Remove DevToolsUIBindings::SendJsonRequest() | 6326236

* 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | 6244461

* 6313744: Migrate views::Background factory methods to ColorVariant | 6313744

* 6314545: Remove multiple argument support from base::ToString() | 6314545

* 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | 6317362

* 6308998: Add SettingAccess structured metrics event for DevTools | 6308998

* 6295214: Remove redundant state field in per-extension preferences | 6295214

NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc

* fix: ui/ linter error

This is showing up in an eslint build step in Electron:

> /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts
>   77:23  error  This assertion is unnecessary since the receiver accepts the original type of the expression  @typescript-eslint/no-unnecessary-type-assertion
>
> ✖ 1 problem (1 error, 0 warnings)
>   1 error and 0 warnings potentially fixable with the `--fix` option.

However, removing the assertion causes a typescript build failure:

> gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'.
>   Type 'null' is not assignable to type 'HTMLElement'.
>
> 77         items.indexOf(this.querySelector<HTMLElement>(':focus'));
>                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So I think the two different steps may be picking up typescript definitions.

This patch should be removed after the issue is tracked down
and fixed in a followup task.

* fix: -Wnonnull warning

Fixes this warning:

> 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
> 2025-03-07T01:05:01.8638267Z   257 |     return nullptr;
> 2025-03-07T01:05:01.8638481Z       |            ^~~~~~~
> 2025-03-07T01:05:01.8638700Z 1 error generated.

Not sure why this warning was never triggered before; `git blame`
indicates this code hasn't changed in ages:

> c40a8273ef2 (Michaël Zasso    2024-05-10 09:50:20 +0200 255) #endif  // DEBUG
> 8e2d33f1562 (Anna Henningsen  2018-06-07 16:54:29 +0200 256)     }
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257)     return nullptr;
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258)   }

Presumably this is failing in this Chromium roll due to a
clang version bump.

We should remove this patch after upstreaming it.

* docs: add upstream pr link for Node patch

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit 458b14b8ed)

* chore!: bump chromium to 136.0.7054.0 (main) (#45923)

* chore: bump chromium in DEPS to 136.0.7054.0

* chore: update allow_in-process_windows_to_have_different_web_prefs.patch

Xref: 5906158

patch applied manually due to context shear

* chore: e patches all

* refactor!: Session.clearStorageData(syncable)

Xref: 6309405

Remove syncable type from opts.quota in Session.clearStorageData(opts)
because it that category has been removed upstream.

BREAKING CHANGE: Removed ses.clearDataStorage({ quota: 'syncable' })

* docs: deprecate Session.clearDataStorage({ quota })

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit 20414f66ca)

* chore: bump chromium to 136.0.7058.1 (main) (#45928)

* chore: bump chromium in DEPS to 136.0.7056.0

* chore: update mas_avoid_private_macos_api_usage.patch.patch

no manual changes; patch applied with fuzz

* chore: update fix_adapt_exclusive_access_for_electron_needs.patch

patch applied manually due to context shear

6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | 6319958

* chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch

no manual changes; patch applied with fuzz

6311876: Expose captured surface resolution for MacOS | 6311876

* chore: e patches all

* 6319958: [FS] Replace GURL with url::Origin for Excluisve Access Bubble | 6319958

* 6326673: views: Delete the single-parameter Widget::InitParams constructor. | 6326673

* 6331102

* 6331102: [A11yPerformance] Rename AXMode::kScreenReader to kExtendedProperties | 6331102

Sync with shell/browser/ui/webui/accessibility_ui.cc to
upstream chrome/browser/accessibility/accessibility_ui.cc
changes in 4af8657

* chore: bump Chromium 136.0.7058.1 (#45933)

chore: bump chromium in DEPS to 136.0.7058.1

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit b0c11371e0)

* chore: bump chromium to 136.0.7062.0 (main) (#45957)

* chore: bump chromium in DEPS to 136.0.7059.0

* chore: bump chromium in DEPS to 136.0.7060.0

* chore: bump chromium in DEPS to 136.0.7062.0

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
(cherry picked from commit 2de8fd7d93)

* fixup! chore: bump chromium to 136.0.7053.1 (main) (#45906)

chore: fix patch shear

* chore: remove cherry-pick-521faebc8a7c.patch

fixed upstream @ 521faeb

6334632: Disable setting primtive restart for WebGL in the cmd decoder. | 6334632

* chore: remove cherry-pick-9dacf5694dfd.patch

fixed upstream @ 9dacf56

6330188: Move WebGL primitive restart state setting to the GPU process. | 6330188

* chore: e patches all

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2025-03-12 09:37:36 -04:00
..
cocoa refactor: use C++20's contains() method (#45742) 2025-02-21 17:33:43 -06:00
gtk chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
views chore: bump chromium to 136.0.7062.0 (#45987) 2025-03-12 09:37:36 -04:00
webui chore: bump chromium to 136.0.7062.0 (#45987) 2025-03-12 09:37:36 -04:00
win docs: fix spelling errors in code comments (#45842) 2025-02-28 12:24:00 +01:00
x refactor: remove unused SetWMSpecState (#43347) 2024-08-19 17:15:19 -04:00
accelerator_util.cc perf: prefer base::SplitStringPiece() over base::SplitString() (#45947) 2025-03-10 12:24:36 -05:00
accelerator_util.h perf: prefer base::SplitStringPiece() over base::SplitString() (#45947) 2025-03-10 12:24:36 -05:00
accelerator_util_unittests.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
autofill_popup.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
autofill_popup.h fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h (#44705) 2024-11-19 13:45:18 -06:00
certificate_trust.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
certificate_trust_mac.mm chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
certificate_trust_win.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
devtools_manager_delegate.cc chore: bump chromium to 136.0.7062.0 (#45987) 2025-03-12 09:37:36 -04:00
devtools_manager_delegate.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
devtools_ui.cc fix: add theme data source for devtools. (#44114) 2024-11-13 13:23:37 +01:00
devtools_ui.h fix: add theme data source for devtools. (#44114) 2024-11-13 13:23:37 +01:00
devtools_ui_bundle_data_source.cc fix: add theme data source for devtools. (#44114) 2024-11-13 13:23:37 +01:00
devtools_ui_bundle_data_source.h fix: add theme data source for devtools. (#44114) 2024-11-13 13:23:37 +01:00
devtools_ui_theme_data_source.cc docs: fix spelling errors in code comments (#45842) 2025-02-28 12:24:00 +01:00
devtools_ui_theme_data_source.h fix: add theme data source for devtools. (#44114) 2024-11-13 13:23:37 +01:00
drag_util.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
drag_util.h chore: iwyu mojom-forward header files (#43741) 2024-09-17 12:58:56 -07:00
drag_util_mac.mm chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
drag_util_views.cc chore: cleanup drag_util (#36806) 2023-01-09 10:00:47 +01:00
electron_desktop_window_tree_host_linux.cc fix: context-menu event emitted in draggable regions (#45813) 2025-02-27 14:44:46 -05:00
electron_desktop_window_tree_host_linux.h fix: context-menu event emitted in draggable regions (#45813) 2025-02-27 14:44:46 -05:00
electron_gdk.sigs refactor: use gdk_display_beep() on Linux (#44734) 2024-11-20 16:24:59 -05:00
electron_gdk_pixbuf.sigs fix: keep gdk_pixbuf a dynamic dependency (#44423) 2024-10-29 09:44:20 +09:00
electron_gtk.fragment refactor: use stubs for gdk-pixbuf dependency (#34077) 2022-06-19 17:42:30 -07:00
electron_menu_model.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
electron_menu_model.h fix: modernize-use-equals-default warnings (#44935) 2024-12-03 16:25:48 -06:00
file_dialog.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
file_dialog_linux.cc fix: revert required portal version for file chooser dialogs (#44426) 2024-11-15 09:31:33 -05:00
file_dialog_mac.mm build: make is_mas_build a generated header instead of config (#43737) 2024-09-17 01:38:56 -07:00
file_dialog_win.cc fix: windows save dialog extension bug (#44296) 2024-11-20 17:27:49 -05:00
gtk_util.cc perf: build g_dgettext domain name at compile time (#43960) 2024-09-26 13:10:30 -04:00
gtk_util.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
inspectable_web_contents.cc chore: bump chromium to 136.0.7062.0 (#45987) 2025-03-12 09:37:36 -04:00
inspectable_web_contents.h chore: bump chromium to 136.0.7062.0 (#45987) 2025-03-12 09:37:36 -04:00
inspectable_web_contents_delegate.h fix: modernize-use-equals-default warnings (#44935) 2024-12-03 16:25:48 -06:00
inspectable_web_contents_view.cc refactor: remove InspectableWebContentsViewMac in favor of the Views version (#44628) 2025-01-17 10:21:10 -05:00
inspectable_web_contents_view.h refactor: remove InspectableWebContentsViewMac in favor of the Views version (#44628) 2025-01-17 10:21:10 -05:00
inspectable_web_contents_view_delegate.cc chore: bump chromium to 93.0.4536.0 (main) (#29586) 2021-06-08 15:22:43 -05:00
inspectable_web_contents_view_delegate.h fix: modernize-use-equals-default warnings (#44935) 2024-12-03 16:25:48 -06:00
message_box.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
message_box_gtk.cc refactor: use C++20's contains() method (#45742) 2025-02-21 17:33:43 -06:00
message_box_mac.mm refactor: use C++20's contains() method (#45742) 2025-02-21 17:33:43 -06:00
message_box_win.cc refactor: use C++20's contains() method (#45742) 2025-02-21 17:33:43 -06:00
run_all_unittests.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
status_icon_gtk.cc chore: bump chromium to 134.0.6968.0 (main) (#45172) 2025-01-23 23:07:43 -05:00
status_icon_gtk.h chore: bump chromium to 134.0.6968.0 (main) (#45172) 2025-01-23 23:07:43 -05:00
tray_icon.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
tray_icon.h refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
tray_icon_cocoa.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
tray_icon_cocoa.mm chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
tray_icon_linux.cc chore: bump chromium to 134.0.6968.0 (main) (#45172) 2025-01-23 23:07:43 -05:00
tray_icon_linux.h chore: bump chromium to 134.0.6968.0 (main) (#45172) 2025-01-23 23:07:43 -05:00
tray_icon_observer.h fix: modernize-use-equals-default warnings (#44935) 2024-12-03 16:25:48 -06:00
tray_icon_win.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00