electron/shell
Charles Kerr 054cbcd6eb
fix: don't use deprecate-soon class v8::String::Value (#43518)
* fix: remove use of deprecated v8::String::Value

Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.

The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().

Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk

v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)

History on why we used it:
80c1a9739d
f49ed30f72

* Update shell/common/gin_converters/file_path_converter.h

Co-authored-by: Robo <hop2deep@gmail.com>

* fixup! Update shell/common/gin_converters/file_path_converter.h

do not return success for all non-Null non-Strings

---------

Co-authored-by: Robo <hop2deep@gmail.com>
2024-09-04 08:56:14 -05:00
..
app fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app (#43481) 2024-09-04 12:54:00 +02:00
browser fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app (#43481) 2024-09-04 12:54:00 +02:00
common fix: don't use deprecate-soon class v8::String::Value (#43518) 2024-09-04 08:56:14 -05:00
renderer chore: bump chromium to 129.0.6664.0 (main) (#43329) 2024-08-19 14:52:53 -04:00
services/node feat: support app#login event for utility process net requests (#42631) 2024-08-14 11:36:47 +09:00
utility chore: bump chromium to 129.0.6630.0 (main) (#43087) 2024-08-02 09:02:11 -05:00