91bb748eaa
* refactor: remove InspectableWebContentsViewMac in favor of the Views version
* cherry-pick: refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326)
commit e67ab9a93d
Confilcts not resolved, except removal of the files removed
by the original commit.
* resolved conflicts and build issues after cherry-pick
* cherry-picked: fix: add method allowing to disable headless mode in native widget
https://github.com/electron/electron/pull/42996
fixing
https://github.com/electron/electron/issues/42995
* fix: displaying select popup in window created as fullscreen window
`constrainFrameRect:toScreen:` is not being call for windows created
with `fullscreen: true` therefore `headless` mode was not being removed
and `RenderWidgetHostNSViewBridge::DisplayPopupMenu` ignored displaying
popup.
Issue could be fixed by placing additional removal of `headless` mode
in the `toggleFullScreen:`, but `orderWindow:relativeTo:` is called
both for a regular and a fullscreen window, therefore there will be
a single place fixing both cases.
Because `electron::NativeWindowMac` lifetime may be shorter than
`ElectronNSWindow` on which macOS may execute `orderWindow:relativeTo:`
we need to clear `shell_` when `NativeWindow` is being closed.
Fixes #43010.
* fix: Content visibility when using `vibrancy`
We need to put `NSVisualEffectView` before `ViewsCompositorSuperview`
otherwise when using `vibrancy` in `BrowserWindow` `NSVisualEffectView`
will hide content displayed by the compositor.
Fixes #43003
Fixes #42336
In fact main issues reported in these tickets were not present after
cherry-picking original refactor switching to `views::WebView`, so
text could be selected and click event was properly generated. However
both issues testcases were using `vibrancy` and actual content was
invisible, because it was covered by the `NSVisualEffectView`.
* fix: EXCEPTION_ACCESS_VIOLATION crash on BrowserWindow.destroy()
Restored postponed deletion of the `NativeWindow`.
Restoration caused `DCHECK(new_parent_ui_layer->GetCompositor());` failure
in `BrowserCompositorMac::SetParentUiLayer` after the spec test:
`chrome extensions chrome.webRequest does not take precedence over Electron webRequest - http`
with stack:
```
7 Electron Framework 0x000000011fe07830 content::BrowserCompositorMac::SetParentUiLayer(ui::Layer*) + 628
8 Electron Framework 0x000000011fe0c154 content::RenderWidgetHostViewMac::SetParentUiLayer(ui::Layer*) + 220
9 Electron Framework 0x000000011fe226a8 content::WebContentsViewMac::CreateViewForWidget(content::RenderWidgetHost*) + 600
10 Electron Framework 0x000000011fd37e4c content::WebContentsImpl::CreateRenderWidgetHostViewForRenderManager(content::RenderViewHost*) + 164
11 Electron Framework 0x000000011fb32278 content::RenderFrameHostManager::CreateSpeculativeRenderFrame(content::SiteInstanceImpl*, bool, scoped_refptr<content::BrowsingContextState> const&) + 816
12 Electron Framework 0x000000011fb2ab8c content::RenderFrameHostManager::CreateSpeculativeRenderFrameHost(content::SiteInstanceImpl*, content::SiteInstanceImpl*, bool) + 1308
13 Electron Framework 0x000000011fb28598 content::RenderFrameHostManager::GetFrameHostForNavigation(content::NavigationRequest*, content::BrowsingContextGroupSwap*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) + 1796
14 Electron Framework 0x000000011fa78660 content::NavigationRequest::SelectFrameHostForOnRequestFailedInternal(bool, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&) + 280
15 Electron Framework 0x000000011fa6a994 content::NavigationRequest::OnRequestFailedInternal(network::URLLoaderCompletionStatus const&, bool, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>> const&, bo
+ 1008
16 Electron Framework 0x000000011fa7772c content::NavigationRequest::OnRequestFailed(network::URLLoaderCompletionStatus const&) + 72
17 Electron Framework 0x000000011f8554ac content::NavigationURLLoaderImpl::NotifyRequestFailed(network::URLLoaderCompletionStatus const&) + 248
```
This was probably the reason of removing `NativeWindow` immediately
in order to cleanup `views_host_` in `WebContentsViewMac` to prevent
using layer without compositor in `WebContentsViewMac::CreateViewForWidget`.
`[ElectronNSWindowDelegate windowWillClose:]` is deleting window host
and the compositor used by the `NativeWindow` therefore detach `NativeWindow`
contents from parent. This will clear `views_host_` and prevent failing
mentioned `DCHECK`.
Fixes #42975
* chore: Applied review suggestions
Co-authored-by: Michał Pichliński <michal.pichlinski@here.io>
* refactor: directly cleanup shell
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michał Pichliński <michal.pichlinski@here.io>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
141 lines
6.6 KiB
Text
141 lines
6.6 KiB
Text
build_gn.patch
|
|
accelerator.patch
|
|
blink_local_frame.patch
|
|
can_create_window.patch
|
|
disable_hidden.patch
|
|
dom_storage_limits.patch
|
|
render_widget_host_view_base.patch
|
|
render_widget_host_view_mac.patch
|
|
webview_cross_drag.patch
|
|
gin_enable_disable_v8_platform.patch
|
|
enable_reset_aspect_ratio.patch
|
|
boringssl_build_gn.patch
|
|
gtk_visibility.patch
|
|
resource_file_conflict.patch
|
|
scroll_bounce_flag.patch
|
|
mas_avoid_private_macos_api_usage.patch.patch
|
|
add_didinstallconditionalfeatures.patch
|
|
desktop_media_list.patch
|
|
proxy_config_monitor.patch
|
|
gritsettings_resource_ids.patch
|
|
isolate_holder.patch
|
|
notification_provenance.patch
|
|
dump_syms.patch
|
|
command-ismediakey.patch
|
|
printing.patch
|
|
support_mixed_sandbox_with_zygote.patch
|
|
build_add_electron_tracing_category.patch
|
|
worker_context_will_destroy.patch
|
|
frame_host_manager.patch
|
|
crashpad_pid_check.patch
|
|
network_service_allow_remote_certificate_verification_logic.patch
|
|
add_contentgpuclient_precreatemessageloop_callback.patch
|
|
picture-in-picture.patch
|
|
disable_compositor_recycling.patch
|
|
allow_new_privileges_in_unsandboxed_child_processes.patch
|
|
expose_setuseragent_on_networkcontext.patch
|
|
feat_add_set_theme_source_to_allow_apps_to.patch
|
|
add_webmessageportconverter_entangleandinjectmessageportchannel.patch
|
|
ignore_rc_check.patch
|
|
remove_usage_of_incognito_apis_in_the_spellchecker.patch
|
|
allow_disabling_blink_scheduler_throttling_per_renderview.patch
|
|
hack_plugin_response_interceptor_to_point_to_electron.patch
|
|
feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
|
|
feat_enable_offscreen_rendering_with_viz_compositor.patch
|
|
feat_allow_embedders_to_add_observers_on_created_hunspell.patch
|
|
allow_in-process_windows_to_have_different_web_prefs.patch
|
|
refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
|
|
crash_allow_setting_more_options.patch
|
|
upload_list_add_loadsync_method.patch
|
|
allow_setting_secondary_label_via_simplemenumodel.patch
|
|
feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
|
|
adjust_accessibility_ui_for_electron.patch
|
|
skip_atk_toolchain_check.patch
|
|
worker_feat_add_hook_to_notify_script_ready.patch
|
|
chore_provide_iswebcontentscreationoverridden_with_full_params.patch
|
|
fix_properly_honor_printing_page_ranges.patch
|
|
export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
|
|
fix_export_zlib_symbols.patch
|
|
web_contents.patch
|
|
webview_fullscreen.patch
|
|
disable_unload_metrics.patch
|
|
extend_apply_webpreferences.patch
|
|
build_libc_as_static_library.patch
|
|
build_do_not_depend_on_packed_resource_integrity.patch
|
|
refactor_restore_base_adaptcallbackforrepeating.patch
|
|
hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch
|
|
logging_win32_only_create_a_console_if_logging_to_stderr.patch
|
|
fix_media_key_usage_with_globalshortcuts.patch
|
|
feat_expose_raw_response_headers_from_urlloader.patch
|
|
process_singleton.patch
|
|
add_ui_scopedcliboardwriter_writeunsaferawdata.patch
|
|
feat_add_data_parameter_to_processsingleton.patch
|
|
load_v8_snapshot_in_browser_process.patch
|
|
fix_adapt_exclusive_access_for_electron_needs.patch
|
|
fix_aspect_ratio_with_max_size.patch
|
|
fix_crash_when_saving_edited_pdf_files.patch
|
|
port_autofill_colors_to_the_color_pipeline.patch
|
|
fix_non-client_mouse_tracking_and_message_bubbling_on_windows.patch
|
|
build_make_libcxx_abi_unstable_false_for_electron.patch
|
|
introduce_ozoneplatform_electron_can_call_x11_property.patch
|
|
make_gtk_getlibgtk_public.patch
|
|
custom_protocols_plzserviceworker.patch
|
|
feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
|
|
disable_freezing_flags_after_init_in_node.patch
|
|
short-circuit_permissions_checks_in_mediastreamdevicescontroller.patch
|
|
chore_add_electron_deps_to_gitignores.patch
|
|
chore_allow_chromium_to_handle_synthetic_mouse_events_for_touch.patch
|
|
add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
|
|
add_electron_deps_to_license_credits_file.patch
|
|
fix_crash_loading_non-standard_schemes_in_iframes.patch
|
|
create_browser_v8_snapshot_file_name_fuse.patch
|
|
feat_configure_launch_options_for_service_process.patch
|
|
feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
|
|
fix_on-screen-keyboard_hides_on_input_blur_in_webview.patch
|
|
preconnect_manager.patch
|
|
fix_remove_caption-removing_style_call.patch
|
|
build_allow_electron_to_use_exec_script.patch
|
|
chore_introduce_blocking_api_for_electron.patch
|
|
chore_patch_out_partition_attribute_dcheck_for_webviews.patch
|
|
chore_patch_out_profile_methods_in_profile_selections_cc.patch
|
|
add_gin_converter_support_for_arraybufferview.patch
|
|
chore_defer_usb_service_getdevices_request_until_usb_service_is.patch
|
|
refactor_expose_hostimportmoduledynamically_and.patch
|
|
feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
|
|
fix_remove_profiles_from_spellcheck_service.patch
|
|
chore_patch_out_profile_methods_in_chrome_browser_pdf.patch
|
|
chore_patch_out_profile_methods_in_titlebar_config.patch
|
|
fix_disabling_background_throttling_in_compositor.patch
|
|
fix_select_the_first_menu_item_when_opened_via_keyboard.patch
|
|
fix_return_v8_value_from_localframe_requestexecutescript.patch
|
|
fix_harden_blink_scriptstate_maybefrom.patch
|
|
fix_use_delegated_generic_capturer_when_available.patch
|
|
expose_webblob_path_to_allow_embedders_to_get_file_paths.patch
|
|
fix_move_autopipsettingshelper_behind_branding_buildflag.patch
|
|
revert_remove_the_allowaggressivethrottlingwithwebsocket_feature.patch
|
|
fix_activate_background_material_on_windows.patch
|
|
feat_allow_passing_of_objecttemplate_to_objecttemplatebuilder.patch
|
|
chore_remove_check_is_test_on_script_injection_tracker.patch
|
|
fix_restore_original_resize_performance_on_macos.patch
|
|
feat_allow_code_cache_in_custom_schemes.patch
|
|
build_run_reclient_cfg_generator_after_chrome.patch
|
|
fix_getcursorscreenpoint_wrongly_returns_0_0.patch
|
|
fix_add_support_for_skipping_first_2_no-op_refreshes_in_thumb_cap.patch
|
|
refactor_expose_file_system_access_blocklist.patch
|
|
partially_revert_is_newly_created_to_allow_for_browser_initiated.patch
|
|
feat_add_support_for_missing_dialog_features_to_shell_dialogs.patch
|
|
fix_font_face_resolution_when_renderer_is_blocked.patch
|
|
feat_enable_passing_exit_code_on_service_process_crash.patch
|
|
chore_remove_reference_to_chrome_browser_themes.patch
|
|
feat_enable_customizing_symbol_color_in_framecaptionbutton.patch
|
|
build_expose_webplugininfo_interface_to_electron.patch
|
|
osr_shared_texture_remove_keyed_mutex_on_win_dxgi.patch
|
|
feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch
|
|
chore_partial_revert_of.patch
|
|
fix_software_compositing_infinite_loop.patch
|
|
fix_add_method_which_disables_headless_mode_on_native_widget.patch
|
|
fix_put_nsvisualeffectview_before_viewscompositorsuperview.patch
|
|
refactor_unfilter_unresponsive_events.patch
|
|
build_disable_thin_lto_mac.patch
|
|
build_add_public_config_simdutf_config.patch
|
|
revert_code_health_clean_up_stale_macwebcontentsocclusion.patch
|