* chore: fix cpplint 'include_what_you_use' warnings Typically by including <memory>, <utility> etc. * chore: fix 'static/global string constant' warning Use C style strings instead of std::string. Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables /home/charles/electron/electron-gn/src/electron/script/cpplint.js * refactor: remove global string variables. Fix 'global string variables are not permitted' linter warnings by using the base::NoDestructor<> wrapper to make it explicit that these variables are never destroyed. The style guide's take on globals with nontrivial destructors: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables * fix: initializer error introduced in last commit * fix: remove WIP file that was included by accident * fix: include order * fix: include order * fix: include order * fix: include order, again
		
			
				
	
	
		
			76 lines
		
	
	
	
		
			2.4 KiB
			
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			76 lines
		
	
	
	
		
			2.4 KiB
			
		
	
	
	
		
			C++
		
	
	
	
	
	
// Copyright (c) 2014 GitHub, Inc.
 | 
						|
// Use of this source code is governed by the MIT license that can be
 | 
						|
// found in the LICENSE file.
 | 
						|
 | 
						|
#include "atom/common/native_mate_converters/value_converter.h"
 | 
						|
 | 
						|
#include <memory>
 | 
						|
 | 
						|
#include "atom/common/native_mate_converters/v8_value_converter.h"
 | 
						|
#include "base/values.h"
 | 
						|
 | 
						|
namespace mate {
 | 
						|
 | 
						|
bool Converter<base::DictionaryValue>::FromV8(v8::Isolate* isolate,
 | 
						|
                                              v8::Local<v8::Value> val,
 | 
						|
                                              base::DictionaryValue* out) {
 | 
						|
  atom::V8ValueConverter converter;
 | 
						|
  std::unique_ptr<base::Value> value(
 | 
						|
      converter.FromV8Value(val, isolate->GetCurrentContext()));
 | 
						|
  if (value && value->is_dict()) {
 | 
						|
    out->Swap(static_cast<base::DictionaryValue*>(value.get()));
 | 
						|
    return true;
 | 
						|
  } else {
 | 
						|
    return false;
 | 
						|
  }
 | 
						|
}
 | 
						|
 | 
						|
v8::Local<v8::Value> Converter<base::DictionaryValue>::ToV8(
 | 
						|
    v8::Isolate* isolate,
 | 
						|
    const base::DictionaryValue& val) {
 | 
						|
  atom::V8ValueConverter converter;
 | 
						|
  return converter.ToV8Value(&val, isolate->GetCurrentContext());
 | 
						|
}
 | 
						|
 | 
						|
bool Converter<base::Value>::FromV8(v8::Isolate* isolate,
 | 
						|
                                    v8::Local<v8::Value> val,
 | 
						|
                                    base::Value* out) {
 | 
						|
  atom::V8ValueConverter converter;
 | 
						|
  std::unique_ptr<base::Value> value(
 | 
						|
      converter.FromV8Value(val, isolate->GetCurrentContext()));
 | 
						|
  if (value) {
 | 
						|
    *out = value->Clone();
 | 
						|
    return true;
 | 
						|
  } else {
 | 
						|
    return false;
 | 
						|
  }
 | 
						|
}
 | 
						|
 | 
						|
v8::Local<v8::Value> Converter<base::Value>::ToV8(v8::Isolate* isolate,
 | 
						|
                                                  const base::Value& val) {
 | 
						|
  atom::V8ValueConverter converter;
 | 
						|
  return converter.ToV8Value(&val, isolate->GetCurrentContext());
 | 
						|
}
 | 
						|
 | 
						|
bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
 | 
						|
                                        v8::Local<v8::Value> val,
 | 
						|
                                        base::ListValue* out) {
 | 
						|
  atom::V8ValueConverter converter;
 | 
						|
  std::unique_ptr<base::Value> value(
 | 
						|
      converter.FromV8Value(val, isolate->GetCurrentContext()));
 | 
						|
  if (value->is_list()) {
 | 
						|
    out->Swap(static_cast<base::ListValue*>(value.get()));
 | 
						|
    return true;
 | 
						|
  } else {
 | 
						|
    return false;
 | 
						|
  }
 | 
						|
}
 | 
						|
 | 
						|
v8::Local<v8::Value> Converter<base::ListValue>::ToV8(
 | 
						|
    v8::Isolate* isolate,
 | 
						|
    const base::ListValue& val) {
 | 
						|
  atom::V8ValueConverter converter;
 | 
						|
  return converter.ToV8Value(&val, isolate->GetCurrentContext());
 | 
						|
}
 | 
						|
 | 
						|
}  // namespace mate
 |