547097b036
* security: allow to block desktopCapturer.getSources() calls * return empty instead of error * fix: release resources of DesktopCapturer on exit
112 lines
3.3 KiB
JavaScript
112 lines
3.3 KiB
JavaScript
const chai = require('chai')
|
|
const dirtyChai = require('dirty-chai')
|
|
const { desktopCapturer, ipcRenderer, remote } = require('electron')
|
|
const { screen } = remote
|
|
const features = process.atomBinding('features')
|
|
|
|
const { expect } = chai
|
|
chai.use(dirtyChai)
|
|
|
|
const isCI = remote.getGlobal('isCi')
|
|
|
|
describe('desktopCapturer', () => {
|
|
before(function () {
|
|
if (!features.isDesktopCapturerEnabled() || process.arch.indexOf('arm') === 0) {
|
|
// It's been disabled during build time.
|
|
this.skip()
|
|
return
|
|
}
|
|
|
|
if (isCI && process.platform === 'win32') {
|
|
this.skip()
|
|
}
|
|
})
|
|
|
|
it('should return a non-empty array of sources', done => {
|
|
desktopCapturer.getSources({
|
|
types: ['window', 'screen']
|
|
}, (error, sources) => {
|
|
expect(error).to.be.null()
|
|
expect(sources).to.be.an('array').that.is.not.empty()
|
|
done()
|
|
})
|
|
})
|
|
|
|
it('throws an error for invalid options', done => {
|
|
desktopCapturer.getSources(['window', 'screen'], error => {
|
|
expect(error.message).to.equal('Invalid options')
|
|
done()
|
|
})
|
|
})
|
|
|
|
it('does not throw an error when called more than once (regression)', (done) => {
|
|
let callCount = 0
|
|
const callback = (error, sources) => {
|
|
callCount++
|
|
expect(error).to.be.null()
|
|
expect(sources).to.be.an('array').that.is.not.empty()
|
|
if (callCount === 2) done()
|
|
}
|
|
|
|
desktopCapturer.getSources({ types: ['window', 'screen'] }, callback)
|
|
desktopCapturer.getSources({ types: ['window', 'screen'] }, callback)
|
|
})
|
|
|
|
it('responds to subsequent calls of different options', done => {
|
|
let callCount = 0
|
|
const callback = (error, sources) => {
|
|
callCount++
|
|
expect(error).to.be.null()
|
|
if (callCount === 2) done()
|
|
}
|
|
|
|
desktopCapturer.getSources({ types: ['window'] }, callback)
|
|
desktopCapturer.getSources({ types: ['screen'] }, callback)
|
|
})
|
|
|
|
it('returns an empty display_id for window sources on Windows and Mac', done => {
|
|
// Linux doesn't return any window sources.
|
|
if (process.platform !== 'win32' && process.platform !== 'darwin') {
|
|
return done()
|
|
}
|
|
|
|
const { BrowserWindow } = remote
|
|
const w = new BrowserWindow({ width: 200, height: 200 })
|
|
|
|
desktopCapturer.getSources({ types: ['window'] }, (error, sources) => {
|
|
w.destroy()
|
|
expect(error).to.be.null()
|
|
expect(sources).to.be.an('array').that.is.not.empty()
|
|
for (const { display_id: displayId } of sources) {
|
|
expect(displayId).to.be.a('string').and.be.empty()
|
|
}
|
|
done()
|
|
})
|
|
})
|
|
|
|
it('returns display_ids matching the Screen API on Windows and Mac', done => {
|
|
if (process.platform !== 'win32' && process.platform !== 'darwin') {
|
|
return done()
|
|
}
|
|
|
|
const displays = screen.getAllDisplays()
|
|
desktopCapturer.getSources({ types: ['screen'] }, (error, sources) => {
|
|
expect(error).to.be.null()
|
|
expect(sources).to.be.an('array').of.length(displays.length)
|
|
|
|
for (let i = 0; i < sources.length; i++) {
|
|
expect(sources[i].display_id).to.equal(displays[i].id.toString())
|
|
}
|
|
done()
|
|
})
|
|
|
|
it('returns empty sources when blocked', done => {
|
|
ipcRenderer.send('handle-next-desktop-capturer-get-sources')
|
|
desktopCapturer.getSources({ types: ['screen'] }, (error, sources) => {
|
|
expect(error).to.be.null()
|
|
expect(sources).to.be.empty()
|
|
done()
|
|
})
|
|
})
|
|
})
|
|
})
|