6ff111a141
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
74 lines
2.6 KiB
C++
74 lines
2.6 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ATOM_COMMON_NATIVE_MATE_CONVERTERS_V8_VALUE_CONVERTER_H_
|
|
#define ATOM_COMMON_NATIVE_MATE_CONVERTERS_V8_VALUE_CONVERTER_H_
|
|
|
|
#include "base/compiler_specific.h"
|
|
#include "base/macros.h"
|
|
#include "v8/include/v8.h"
|
|
|
|
namespace base {
|
|
class DictionaryValue;
|
|
class ListValue;
|
|
class Value;
|
|
} // namespace base
|
|
|
|
namespace atom {
|
|
|
|
class V8ValueConverter {
|
|
public:
|
|
V8ValueConverter();
|
|
|
|
void SetRegExpAllowed(bool val);
|
|
void SetFunctionAllowed(bool val);
|
|
void SetStripNullFromObjects(bool val);
|
|
v8::Local<v8::Value> ToV8Value(const base::Value* value,
|
|
v8::Local<v8::Context> context) const;
|
|
base::Value* FromV8Value(v8::Local<v8::Value> value,
|
|
v8::Local<v8::Context> context) const;
|
|
|
|
private:
|
|
class FromV8ValueState;
|
|
class ScopedUniquenessGuard;
|
|
|
|
v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,
|
|
const base::Value* value) const;
|
|
v8::Local<v8::Value> ToV8Array(v8::Isolate* isolate,
|
|
const base::ListValue* list) const;
|
|
v8::Local<v8::Value> ToV8Object(
|
|
v8::Isolate* isolate,
|
|
const base::DictionaryValue* dictionary) const;
|
|
v8::Local<v8::Value> ToArrayBuffer(v8::Isolate* isolate,
|
|
const base::Value* value) const;
|
|
|
|
base::Value* FromV8ValueImpl(FromV8ValueState* state,
|
|
v8::Local<v8::Value> value,
|
|
v8::Isolate* isolate) const;
|
|
base::Value* FromV8Array(v8::Local<v8::Array> array,
|
|
FromV8ValueState* state,
|
|
v8::Isolate* isolate) const;
|
|
base::Value* FromNodeBuffer(v8::Local<v8::Value> value,
|
|
FromV8ValueState* state,
|
|
v8::Isolate* isolate) const;
|
|
base::Value* FromV8Object(v8::Local<v8::Object> object,
|
|
FromV8ValueState* state,
|
|
v8::Isolate* isolate) const;
|
|
|
|
// If true, we will convert RegExp JavaScript objects to string.
|
|
bool reg_exp_allowed_ = false;
|
|
|
|
// If true, we will convert Function JavaScript objects to dictionaries.
|
|
bool function_allowed_ = false;
|
|
|
|
// If true, undefined and null values are ignored when converting v8 objects
|
|
// into Values.
|
|
bool strip_null_from_objects_ = false;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(V8ValueConverter);
|
|
};
|
|
|
|
} // namespace atom
|
|
|
|
#endif // ATOM_COMMON_NATIVE_MATE_CONVERTERS_V8_VALUE_CONVERTER_H_
|