f36ceae024
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc * chore: migrate from base::StringPiece to std::string_view in error_thrower.cc * chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc * chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h * chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc * chore: phase out internal use of base:::StringPiece `base::StringPiece` is being phased out upstream. Its code has been removed upstream and it's just a typedef for `std::string_view`. They haven't removed the typedef yet, so this PR tries to get ahead of future breakage by migrating "internal" use (i.e. leaving alone the places where the `base::StringPiece` name is coming from an upstream method that we override). Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483 Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <string_view>
|
|
|
|
#include "shell/common/gin_helper/error_thrower.h"
|
|
|
|
#include "gin/converter.h"
|
|
|
|
namespace gin_helper {
|
|
|
|
ErrorThrower::ErrorThrower(v8::Isolate* isolate) : isolate_(isolate) {}
|
|
|
|
// This constructor should be rarely if ever used, since
|
|
// v8::Isolate::GetCurrent() uses atomic loads and is thus a bit
|
|
// costly to invoke
|
|
ErrorThrower::ErrorThrower() : isolate_(v8::Isolate::GetCurrent()) {}
|
|
|
|
void ErrorThrower::ThrowError(const std::string_view err_msg) const {
|
|
Throw(v8::Exception::Error, err_msg);
|
|
}
|
|
|
|
void ErrorThrower::ThrowTypeError(const std::string_view err_msg) const {
|
|
Throw(v8::Exception::TypeError, err_msg);
|
|
}
|
|
|
|
void ErrorThrower::ThrowRangeError(const std::string_view err_msg) const {
|
|
Throw(v8::Exception::RangeError, err_msg);
|
|
}
|
|
|
|
void ErrorThrower::ThrowReferenceError(const std::string_view err_msg) const {
|
|
Throw(v8::Exception::ReferenceError, err_msg);
|
|
}
|
|
|
|
void ErrorThrower::ThrowSyntaxError(const std::string_view err_msg) const {
|
|
Throw(v8::Exception::SyntaxError, err_msg);
|
|
}
|
|
|
|
void ErrorThrower::Throw(ErrorGenerator gen,
|
|
const std::string_view err_msg) const {
|
|
v8::Local<v8::Value> exception = gen(gin::StringToV8(isolate_, err_msg), {});
|
|
if (!isolate_->IsExecutionTerminating())
|
|
isolate_->ThrowException(exception);
|
|
}
|
|
|
|
} // namespace gin_helper
|