9011532b2e
* fix: clang variable configuration in generated node headers Co-authored-by: deepak1556 <hop2deep@gmail.com> * chore: restore value in common.gypi Co-authored-by: deepak1556 <hop2deep@gmail.com> * chore: update patches --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
102 lines
5.2 KiB
Diff
102 lines
5.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Cheng Zhao <zcbenz@gmail.com>
|
|
Date: Thu, 4 Oct 2018 14:57:02 -0700
|
|
Subject: fix: also propagate fullscreen state for outer frame
|
|
|
|
When entering fullscreen with Element.requestFullscreen in child frames,
|
|
the parent frame should also enter fullscreen mode too. Chromium handles
|
|
this for iframes, but not for webviews as they are essentially main
|
|
frames instead of child frames.
|
|
|
|
This patch makes webviews propagate the fullscreen state to embedder.It also handles a
|
|
DCHECK preventing guest webcontents from becoming the focused webContents.
|
|
|
|
Note that we also need to manually update embedder's
|
|
`api::WebContents::IsFullscreenForTabOrPending` value.
|
|
|
|
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
|
index b6bda9691f0ae96ee4ba5d0d96d4e57e4fa592c2..67e53ad616687ea17719e3f4f1d00192c5b69d61 100644
|
|
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
|
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
|
@@ -8175,6 +8175,17 @@ void RenderFrameHostImpl::EnterFullscreen(
|
|
}
|
|
}
|
|
|
|
+ // Entering fullscreen from webview should also notify its outer frame.
|
|
+ if (frame_tree_node()->render_manager()->IsMainFrameForInnerDelegate()) {
|
|
+ RenderFrameProxyHost* outer_proxy =
|
|
+ frame_tree_node()->render_manager()->GetProxyToOuterDelegate();
|
|
+ DCHECK(outer_proxy);
|
|
+ if (outer_proxy->is_render_frame_proxy_live()) {
|
|
+ outer_proxy->GetAssociatedRemoteFrame()->WillEnterFullscreen(
|
|
+ options.Clone());
|
|
+ }
|
|
+ }
|
|
+
|
|
// Focus the window if another frame may have delegated the capability.
|
|
if (had_fullscreen_token && !GetView()->HasFocus())
|
|
GetView()->Focus();
|
|
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
|
index 8ab0b226c3e9eb7247840903b7c45339e4080d76..873ed8f1a0162689299c8093f8a319cf60776623 100644
|
|
--- a/content/browser/web_contents/web_contents_impl.cc
|
|
+++ b/content/browser/web_contents/web_contents_impl.cc
|
|
@@ -3930,21 +3930,25 @@ KeyboardEventProcessingResult WebContentsImpl::PreHandleKeyboardEvent(
|
|
const input::NativeWebKeyboardEvent& event) {
|
|
OPTIONAL_TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("content.verbose"),
|
|
"WebContentsImpl::PreHandleKeyboardEvent");
|
|
- auto* outermost_contents = GetOutermostWebContents();
|
|
- // TODO(wjmaclean): Generalize this to forward all key events to the outermost
|
|
- // delegate's handler.
|
|
- if (outermost_contents != this && IsFullscreen() &&
|
|
- event.windows_key_code == ui::VKEY_ESCAPE) {
|
|
- // When an inner WebContents has focus and is fullscreen, redirect <esc>
|
|
- // key events to the outermost WebContents so it can be handled by that
|
|
- // WebContents' delegate.
|
|
- if (outermost_contents->PreHandleKeyboardEvent(event) ==
|
|
- KeyboardEventProcessingResult::HANDLED) {
|
|
+
|
|
+ auto handled = delegate_ ? delegate_->PreHandleKeyboardEvent(this, event)
|
|
+ : KeyboardEventProcessingResult::NOT_HANDLED;
|
|
+
|
|
+ if (IsFullscreen() && event.windows_key_code == ui::VKEY_ESCAPE) {
|
|
+ if (handled == KeyboardEventProcessingResult::HANDLED)
|
|
return KeyboardEventProcessingResult::HANDLED;
|
|
+
|
|
+ // When an inner WebContents has focus and is fullscreen, traverse through
|
|
+ // containing webcontents to any that may handle the escape key.
|
|
+ while (auto* outer_web_contents = GetOuterWebContents()) {
|
|
+ auto result = outer_web_contents->PreHandleKeyboardEvent(event);
|
|
+ if (result == KeyboardEventProcessingResult::HANDLED) {
|
|
+ return KeyboardEventProcessingResult::HANDLED;
|
|
+ }
|
|
}
|
|
}
|
|
- return delegate_ ? delegate_->PreHandleKeyboardEvent(this, event)
|
|
- : KeyboardEventProcessingResult::NOT_HANDLED;
|
|
+
|
|
+ return handled;
|
|
}
|
|
|
|
bool WebContentsImpl::HandleMouseEvent(const blink::WebMouseEvent& event) {
|
|
@@ -4103,7 +4107,7 @@ void WebContentsImpl::EnterFullscreenMode(
|
|
OPTIONAL_TRACE_EVENT0("content", "WebContentsImpl::EnterFullscreenMode");
|
|
DCHECK(CanEnterFullscreenMode(requesting_frame));
|
|
DCHECK(requesting_frame->IsActive());
|
|
- DCHECK(ContainsOrIsFocusedWebContents());
|
|
+ DCHECK(ContainsOrIsFocusedWebContents() || IsGuest());
|
|
if (base::FeatureList::IsEnabled(
|
|
features::kAutomaticFullscreenContentSetting)) {
|
|
// Ensure the window is made active to take input focus. The user may have
|
|
diff --git a/third_party/blink/renderer/core/fullscreen/fullscreen.cc b/third_party/blink/renderer/core/fullscreen/fullscreen.cc
|
|
index f28fe993fa4454d72757c93f7a78428a14d8e073..c1e5598ed3a703bacfe69a64f2df6f1e5169cb88 100644
|
|
--- a/third_party/blink/renderer/core/fullscreen/fullscreen.cc
|
|
+++ b/third_party/blink/renderer/core/fullscreen/fullscreen.cc
|
|
@@ -110,7 +110,7 @@ void FullscreenElementChanged(Document& document,
|
|
// is the iframe element for the out-of-process frame that contains the
|
|
// fullscreen element. Hence, it must match :-webkit-full-screen-ancestor.
|
|
if (new_request_type & FullscreenRequestType::kForCrossProcessDescendant) {
|
|
- DCHECK(IsA<HTMLIFrameElement>(new_element));
|
|
+ // DCHECK(IsA<HTMLIFrameElement>(new_element));
|
|
new_element->SetContainsFullScreenElement(true);
|
|
}
|
|
new_element->SetContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(
|