06cf0406fe
Previously we rely on the v8util.setDestructor to dereference the remote objects in JavaScript, however as documented in V8, it is forbidden to call V8 APIs in object's destructor (e.g. the weak callback), and doing so would result in crashs. This commit removes the JavaScript setDestructor method, and avoids doing the dereference work with V8.
66 lines
2 KiB
C++
66 lines
2 KiB
C++
// Copyright (c) 2015 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ATOM_COMMON_NATIVE_MATE_CONVERTERS_CONTENT_CONVERTER_H_
|
|
#define ATOM_COMMON_NATIVE_MATE_CONVERTERS_CONTENT_CONVERTER_H_
|
|
|
|
#include <utility>
|
|
|
|
#include "content/public/browser/permission_type.h"
|
|
#include "content/public/common/menu_item.h"
|
|
#include "content/public/common/permission_status.mojom.h"
|
|
#include "content/public/common/stop_find_action.h"
|
|
#include "native_mate/converter.h"
|
|
|
|
namespace content {
|
|
struct ContextMenuParams;
|
|
class WebContents;
|
|
}
|
|
|
|
using ContextMenuParamsWithWebContents =
|
|
std::pair<content::ContextMenuParams, content::WebContents*>;
|
|
|
|
namespace mate {
|
|
|
|
template<>
|
|
struct Converter<content::MenuItem::Type> {
|
|
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
|
|
const content::MenuItem::Type& val);
|
|
};
|
|
|
|
template<>
|
|
struct Converter<ContextMenuParamsWithWebContents> {
|
|
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
|
|
const ContextMenuParamsWithWebContents& val);
|
|
};
|
|
|
|
template<>
|
|
struct Converter<content::PermissionStatus> {
|
|
static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
|
|
content::PermissionStatus* out);
|
|
};
|
|
|
|
template<>
|
|
struct Converter<content::PermissionType> {
|
|
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
|
|
const content::PermissionType& val);
|
|
};
|
|
|
|
template<>
|
|
struct Converter<content::StopFindAction> {
|
|
static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
|
|
content::StopFindAction* out);
|
|
};
|
|
|
|
template<>
|
|
struct Converter<content::WebContents*> {
|
|
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
|
|
content::WebContents* val);
|
|
static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
|
|
content::WebContents** out);
|
|
};
|
|
|
|
} // namespace mate
|
|
|
|
#endif // ATOM_COMMON_NATIVE_MATE_CONVERTERS_CONTENT_CONVERTER_H_
|