27aea84411
fix: native View wrapper crash missing when adding child view Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
334 lines
13 KiB
TypeScript
334 lines
13 KiB
TypeScript
import { expect } from 'chai';
|
|
import { BaseWindow, BrowserWindow, View, WebContentsView, webContents, screen } from 'electron/main';
|
|
import { once } from 'node:events';
|
|
|
|
import { closeAllWindows } from './lib/window-helpers';
|
|
import { defer, ifdescribe, waitUntil } from './lib/spec-helpers';
|
|
import { HexColors, ScreenCapture, hasCapturableScreen, nextFrameTime } from './lib/screen-helpers';
|
|
|
|
describe('WebContentsView', () => {
|
|
afterEach(closeAllWindows);
|
|
|
|
it('can be instantiated with no arguments', () => {
|
|
// eslint-disable-next-line no-new
|
|
new WebContentsView();
|
|
});
|
|
|
|
it('can be instantiated with no webPreferences', () => {
|
|
// eslint-disable-next-line no-new
|
|
new WebContentsView({});
|
|
});
|
|
|
|
it('accepts existing webContents object', async () => {
|
|
const currentWebContentsCount = webContents.getAllWebContents().length;
|
|
|
|
const wc = (webContents as typeof ElectronInternal.WebContents).create({ sandbox: true });
|
|
defer(() => wc.destroy());
|
|
await wc.loadURL('about:blank');
|
|
|
|
const webContentsView = new WebContentsView({
|
|
webContents: wc
|
|
});
|
|
|
|
expect(webContentsView.webContents).to.eq(wc);
|
|
expect(webContents.getAllWebContents().length).to.equal(currentWebContentsCount + 1, 'expected only single webcontents to be created');
|
|
});
|
|
|
|
it('should throw error when created with already attached webContents to BrowserWindow', () => {
|
|
const browserWindow = new BrowserWindow();
|
|
defer(() => browserWindow.webContents.destroy());
|
|
|
|
const webContentsView = new WebContentsView();
|
|
defer(() => webContentsView.webContents.destroy());
|
|
|
|
browserWindow.contentView.addChildView(webContentsView);
|
|
defer(() => browserWindow.contentView.removeChildView(webContentsView));
|
|
|
|
expect(() => new WebContentsView({
|
|
webContents: webContentsView.webContents
|
|
})).to.throw('options.webContents is already attached to a window');
|
|
});
|
|
|
|
it('should throw error when created with already attached webContents to other WebContentsView', () => {
|
|
const browserWindow = new BrowserWindow();
|
|
|
|
const webContentsView = new WebContentsView();
|
|
defer(() => webContentsView.webContents.destroy());
|
|
webContentsView.webContents.loadURL('about:blank');
|
|
|
|
expect(() => new WebContentsView({
|
|
webContents: browserWindow.webContents
|
|
})).to.throw('options.webContents is already attached to a window');
|
|
});
|
|
|
|
it('can be used as content view', () => {
|
|
const w = new BaseWindow({ show: false });
|
|
w.setContentView(new WebContentsView());
|
|
});
|
|
|
|
it('can be removed after a close', async () => {
|
|
const w = new BaseWindow({ show: false });
|
|
const v = new View();
|
|
const wcv = new WebContentsView();
|
|
w.setContentView(v);
|
|
v.addChildView(wcv);
|
|
await wcv.webContents.loadURL('about:blank');
|
|
const destroyed = once(wcv.webContents, 'destroyed');
|
|
wcv.webContents.executeJavaScript('window.close()');
|
|
await destroyed;
|
|
expect(wcv.webContents.isDestroyed()).to.be.true();
|
|
v.removeChildView(wcv);
|
|
});
|
|
|
|
it('correctly reorders children', () => {
|
|
const w = new BaseWindow({ show: false });
|
|
const cv = new View();
|
|
w.setContentView(cv);
|
|
|
|
const wcv1 = new WebContentsView();
|
|
const wcv2 = new WebContentsView();
|
|
const wcv3 = new WebContentsView();
|
|
w.contentView.addChildView(wcv1);
|
|
w.contentView.addChildView(wcv2);
|
|
w.contentView.addChildView(wcv3);
|
|
|
|
expect(w.contentView.children).to.deep.equal([wcv1, wcv2, wcv3]);
|
|
|
|
w.contentView.addChildView(wcv1);
|
|
w.contentView.addChildView(wcv2);
|
|
expect(w.contentView.children).to.deep.equal([wcv3, wcv1, wcv2]);
|
|
});
|
|
|
|
function triggerGCByAllocation () {
|
|
const arr = [];
|
|
for (let i = 0; i < 1000000; i++) {
|
|
arr.push([]);
|
|
}
|
|
return arr;
|
|
}
|
|
|
|
it('doesn\'t crash when GCed during allocation', (done) => {
|
|
// eslint-disable-next-line no-new
|
|
new WebContentsView();
|
|
setTimeout(() => {
|
|
// NB. the crash we're testing for is the lack of a current `v8::Context`
|
|
// when emitting an event in WebContents's destructor. V8 is inconsistent
|
|
// about whether or not there's a current context during garbage
|
|
// collection, and it seems that `v8Util.requestGarbageCollectionForTesting`
|
|
// causes a GC in which there _is_ a current context, so the crash isn't
|
|
// triggered. Thus, we force a GC by other means: namely, by allocating a
|
|
// bunch of stuff.
|
|
triggerGCByAllocation();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('can be fullscreened', async () => {
|
|
const w = new BaseWindow();
|
|
const v = new WebContentsView();
|
|
w.setContentView(v);
|
|
await v.webContents.loadURL('data:text/html,<div id="div">This is a simple div.</div>');
|
|
|
|
const enterFullScreen = once(w, 'enter-full-screen');
|
|
await v.webContents.executeJavaScript('document.getElementById("div").requestFullscreen()', true);
|
|
await enterFullScreen;
|
|
expect(w.isFullScreen()).to.be.true('isFullScreen');
|
|
});
|
|
|
|
it('can be added as a child of another View', async () => {
|
|
const w = new BaseWindow();
|
|
const v = new View();
|
|
const wcv = new WebContentsView();
|
|
|
|
await wcv.webContents.loadURL('data:text/html,<div id="div">This is a simple div.</div>');
|
|
|
|
v.addChildView(wcv);
|
|
w.contentView.addChildView(v);
|
|
|
|
expect(w.contentView.children).to.deep.equal([v]);
|
|
expect(v.children).to.deep.equal([wcv]);
|
|
});
|
|
|
|
describe('visibilityState', () => {
|
|
async function haveVisibilityState (view: WebContentsView, state: string) {
|
|
const docVisState = await view.webContents.executeJavaScript('document.visibilityState');
|
|
return docVisState === state;
|
|
}
|
|
|
|
it('is initially hidden', async () => {
|
|
const v = new WebContentsView();
|
|
await v.webContents.loadURL('data:text/html,<script>initialVisibility = document.visibilityState</script>');
|
|
expect(await v.webContents.executeJavaScript('initialVisibility')).to.equal('hidden');
|
|
});
|
|
|
|
it('becomes visible when attached', async () => {
|
|
const v = new WebContentsView();
|
|
await v.webContents.loadURL('about:blank');
|
|
expect(await v.webContents.executeJavaScript('document.visibilityState')).to.equal('hidden');
|
|
const p = v.webContents.executeJavaScript('new Promise(resolve => document.addEventListener("visibilitychange", resolve))');
|
|
// Ensure that the above listener has been registered before we add the
|
|
// view to the window, or else the visibilitychange event might be
|
|
// dispatched before the listener is registered.
|
|
// executeJavaScript calls are sequential so if this one's finished then
|
|
// the previous one must also have been finished :)
|
|
await v.webContents.executeJavaScript('undefined');
|
|
const w = new BaseWindow();
|
|
w.setContentView(v);
|
|
await p;
|
|
expect(await v.webContents.executeJavaScript('document.visibilityState')).to.equal('visible');
|
|
});
|
|
|
|
it('is initially visible if load happens after attach', async () => {
|
|
const w = new BaseWindow();
|
|
const v = new WebContentsView();
|
|
w.contentView = v;
|
|
await v.webContents.loadURL('data:text/html,<script>initialVisibility = document.visibilityState</script>');
|
|
expect(await v.webContents.executeJavaScript('initialVisibility')).to.equal('visible');
|
|
});
|
|
|
|
it('becomes hidden when parent window is hidden', async () => {
|
|
const w = new BaseWindow();
|
|
const v = new WebContentsView();
|
|
w.setContentView(v);
|
|
await v.webContents.loadURL('about:blank');
|
|
await expect(waitUntil(async () => await haveVisibilityState(v, 'visible'))).to.eventually.be.fulfilled();
|
|
const p = v.webContents.executeJavaScript('new Promise(resolve => document.addEventListener("visibilitychange", resolve))');
|
|
// We have to wait until the listener above is fully registered before hiding the window.
|
|
// On Windows, the executeJavaScript and the visibilitychange can happen out of order
|
|
// without this.
|
|
await v.webContents.executeJavaScript('0');
|
|
w.hide();
|
|
await p;
|
|
expect(await v.webContents.executeJavaScript('document.visibilityState')).to.equal('hidden');
|
|
});
|
|
|
|
it('becomes visible when parent window is shown', async () => {
|
|
const w = new BaseWindow({ show: false });
|
|
const v = new WebContentsView();
|
|
w.setContentView(v);
|
|
await v.webContents.loadURL('about:blank');
|
|
expect(await v.webContents.executeJavaScript('document.visibilityState')).to.equal('hidden');
|
|
const p = v.webContents.executeJavaScript('new Promise(resolve => document.addEventListener("visibilitychange", resolve))');
|
|
// We have to wait until the listener above is fully registered before hiding the window.
|
|
// On Windows, the executeJavaScript and the visibilitychange can happen out of order
|
|
// without this.
|
|
await v.webContents.executeJavaScript('0');
|
|
w.show();
|
|
await p;
|
|
expect(await v.webContents.executeJavaScript('document.visibilityState')).to.equal('visible');
|
|
});
|
|
|
|
it('does not change when view is moved between two visible windows', async () => {
|
|
const w = new BaseWindow();
|
|
const v = new WebContentsView();
|
|
w.setContentView(v);
|
|
await v.webContents.loadURL('about:blank');
|
|
await expect(waitUntil(async () => await haveVisibilityState(v, 'visible'))).to.eventually.be.fulfilled();
|
|
|
|
const p = v.webContents.executeJavaScript('new Promise(resolve => document.addEventListener("visibilitychange", () => resolve(document.visibilityState)))');
|
|
// Ensure the listener has been registered.
|
|
await v.webContents.executeJavaScript('undefined');
|
|
const w2 = new BaseWindow();
|
|
w2.setContentView(v);
|
|
// Wait for the visibility state to settle as "visible".
|
|
// On macOS one visibilitychange event is fired but visibilityState
|
|
// remains "visible". On Win/Linux, two visibilitychange events are
|
|
// fired, a "hidden" and a "visible" one. Reconcile these two models
|
|
// by waiting until at least one event has been fired, and then waiting
|
|
// until the visibility state settles as "visible".
|
|
let visibilityState = await p;
|
|
for (let attempts = 0; visibilityState !== 'visible' && attempts < 10; attempts++) {
|
|
visibilityState = await v.webContents.executeJavaScript('new Promise(resolve => document.visibilityState === "visible" ? resolve("visible") : document.addEventListener("visibilitychange", () => resolve(document.visibilityState)))');
|
|
}
|
|
expect(visibilityState).to.equal('visible');
|
|
});
|
|
});
|
|
|
|
describe('setBorderRadius', () => {
|
|
ifdescribe(hasCapturableScreen())('capture', () => {
|
|
let w: Electron.BaseWindow;
|
|
let v: Electron.WebContentsView;
|
|
let display: Electron.Display;
|
|
let corners: Electron.Point[];
|
|
|
|
const backgroundUrl = `data:text/html,<style>html{background:${encodeURIComponent(HexColors.GREEN)}}</style>`;
|
|
|
|
beforeEach(async () => {
|
|
display = screen.getPrimaryDisplay();
|
|
|
|
w = new BaseWindow({
|
|
...display.workArea,
|
|
show: true,
|
|
frame: false,
|
|
hasShadow: false,
|
|
backgroundColor: HexColors.BLUE,
|
|
roundedCorners: false
|
|
});
|
|
|
|
v = new WebContentsView();
|
|
w.setContentView(v);
|
|
v.setBorderRadius(100);
|
|
|
|
const readyForCapture = once(v.webContents, 'ready-to-show');
|
|
v.webContents.loadURL(backgroundUrl);
|
|
|
|
const inset = 10;
|
|
corners = [
|
|
{ x: display.workArea.x + inset, y: display.workArea.y + inset }, // top-left
|
|
{ x: display.workArea.x + display.workArea.width - inset, y: display.workArea.y + inset }, // top-right
|
|
{ x: display.workArea.x + display.workArea.width - inset, y: display.workArea.y + display.workArea.height - inset }, // bottom-right
|
|
{ x: display.workArea.x + inset, y: display.workArea.y + display.workArea.height - inset } // bottom-left
|
|
];
|
|
|
|
await readyForCapture;
|
|
});
|
|
|
|
afterEach(() => {
|
|
w.destroy();
|
|
w = v = null!;
|
|
});
|
|
|
|
it('should render with cutout corners', async () => {
|
|
const screenCapture = new ScreenCapture(display);
|
|
|
|
for (const corner of corners) {
|
|
await screenCapture.expectColorAtPointOnDisplayMatches(HexColors.BLUE, () => corner);
|
|
}
|
|
|
|
// Center should be WebContents page background color
|
|
await screenCapture.expectColorAtCenterMatches(HexColors.GREEN);
|
|
});
|
|
|
|
it('should allow resetting corners', async () => {
|
|
const corner = corners[0];
|
|
v.setBorderRadius(0);
|
|
|
|
await nextFrameTime();
|
|
const screenCapture = new ScreenCapture(display);
|
|
await screenCapture.expectColorAtPointOnDisplayMatches(HexColors.GREEN, () => corner);
|
|
await screenCapture.expectColorAtCenterMatches(HexColors.GREEN);
|
|
});
|
|
|
|
it('should render when set before attached', async () => {
|
|
v = new WebContentsView();
|
|
v.setBorderRadius(100); // must set before
|
|
|
|
w.setContentView(v);
|
|
|
|
const readyForCapture = once(v.webContents, 'ready-to-show');
|
|
v.webContents.loadURL(backgroundUrl);
|
|
await readyForCapture;
|
|
|
|
const corner = corners[0];
|
|
const screenCapture = new ScreenCapture(display);
|
|
await screenCapture.expectColorAtPointOnDisplayMatches(HexColors.BLUE, () => corner);
|
|
await screenCapture.expectColorAtCenterMatches(HexColors.GREEN);
|
|
});
|
|
});
|
|
|
|
it('should allow setting when not attached', async () => {
|
|
const v = new WebContentsView();
|
|
v.setBorderRadius(100);
|
|
});
|
|
});
|
|
});
|