mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser/api
History
Shelley Vohr 49096c2359
fix: throw on invalid webRequest filters (#19337) 
Closes #11371.

Previously, we didn't consider the return value of the webRequest URLPattern mate converter, which meant that when the pattern wasn't correctly parsed owing to invalid filter specification users would not be made aware of that fact and would just think that the filtering itself had failed. This corrects that error by moving the business logic of url pattern parsing out of the converter and into the function itself so that granular and specific errors can be thrown.

There's also no real reason that i'm aware of not to allow wider breadth of filters by letting users use a wildcard for effective TLD, so I also overrode that (default for the 1-arg Parse is not to allow that).

Finally, I added some examples of url filter types for users to reference.
2019-07-25 10:20:02 -07:00
..
views chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
atom_api_app.cc feat: add memory to app.getAppMetrics() (#18831) 2019-07-23 13:41:58 -07:00
atom_api_app.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
atom_api_app_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_app_mas.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_auto_updater.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_auto_updater.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window.cc fix: emit swipe event on macOS (#19319) 2019-07-19 16:21:07 -07:00
atom_api_browser_window.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_content_tracing.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_cookies.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_cookies.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_debugger.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_debugger.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_desktop_capturer.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_desktop_capturer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_dialog.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_download_item.cc refactor: make savePath a property on DownloadItem (#18677) 2019-06-20 10:04:57 -07:00
atom_api_download_item.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_event.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
atom_api_global_shortcut.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
atom_api_global_shortcut.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_in_app_purchase.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_in_app_purchase.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu.cc add toolTip property for MenuItem (#19099) 2019-07-11 17:56:22 +09:00
atom_api_menu.h add toolTip property for MenuItem (#19099) 2019-07-11 17:56:22 +09:00
atom_api_menu_mac.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu_views.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_net.cc feat: implement net module with NetworkService (#19094) 2019-07-04 10:56:19 +09:00
atom_api_net.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_net_log.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
atom_api_net_log.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_notification.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_notification.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
atom_api_power_monitor.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_save_blocker.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_save_blocker.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_protocol.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_protocol.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_protocol_ns.cc chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
atom_api_protocol_ns.h docs: documentation of NetworkService-based protocol module (#18952) 2019-06-28 16:25:30 +09:00
atom_api_screen.cc chore: pass base::StringPiece args by value (#19432) 2019-07-25 10:19:04 -05:00
atom_api_screen.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_session.cc feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_api_session.h feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_api_system_preferences.cc feat: support isHighContrastColorScheme() on macOS (#19331) 2019-07-19 16:04:42 -07:00
atom_api_system_preferences.h feat: add object to subscribe notification callback (#19110) 2019-07-11 10:06:31 -07:00
atom_api_system_preferences_mac.mm refactor: use NativeTheme dark mode detection on macOS 10.14+ 2019-07-16 17:06:31 -07:00
atom_api_system_preferences_win.cc feat: support isHighContrastColorScheme() on macOS (#19331) 2019-07-19 16:04:42 -07:00
atom_api_top_level_window.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
atom_api_top_level_window.h feat: add rotate gesture for macOS (#19294) 2019-07-23 14:42:26 -05:00
atom_api_tray.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_tray.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_url_request.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_url_request.h feat: implement net module with NetworkService (#19094) 2019-07-04 10:56:19 +09:00
atom_api_url_request_ns.cc chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
atom_api_url_request_ns.h chore: bump chromium to 79eae5b7b2d9dac441ac0182ee160 (master) (#19166) 2019-07-24 15:58:51 -07:00
atom_api_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents.cc feat: preliminary support for //extensions (#17440) 2019-07-24 16:01:08 -07:00
atom_api_web_contents.h fix: ignore non-absolute session preload script paths when sandboxed (#19066) 2019-07-03 08:05:45 -07:00
atom_api_web_contents_impl.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_request.cc fix: throw on invalid webRequest filters (#19337) 2019-07-25 10:20:02 -07:00
atom_api_web_request.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_request_ns.cc chore: use dummy WebRequestNS when NetworkService is enabled (#19300) 2019-07-17 11:55:55 -07:00
atom_api_web_request_ns.h chore: use dummy WebRequestNS when NetworkService is enabled (#19300) 2019-07-17 11:55:55 -07:00
atom_api_web_view_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
event.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
event.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
event_emitter.cc fix: correct triggeredByAccelerator Event property behavior (#18865) 2019-06-28 14:38:17 -07:00
event_emitter.h chore: pass base::StringPiece args by value (#19432) 2019-07-25 10:19:04 -05:00
frame_subscriber.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
frame_subscriber.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpu_info_enumerator.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpu_info_enumerator.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpuinfo_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpuinfo_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
process_metric.cc feat: add memory to app.getAppMetrics() (#18831) 2019-07-23 13:41:58 -07:00
process_metric.h feat: add memory to app.getAppMetrics() (#18831) 2019-07-23 13:41:58 -07:00
save_page_handler.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
save_page_handler.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
stream_subscriber.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
stream_subscriber.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
trackable_object.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
trackable_object.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00